Change in osmo-asf4-dfu[master]: minox: use RAM address define instead of hardcoded value

2019-02-15 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12920 )

Change subject: minox: use RAM address define instead of hardcoded value
..

minox: use RAM address define instead of hardcoded value

Change-Id: I81a42637194cbf0b5152fe38c691522021ab7582
---
M usb_dfu_main.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/usb_dfu_main.c b/usb_dfu_main.c
index f431d29..19fe437 100644
--- a/usb_dfu_main.c
+++ b/usb_dfu_main.c
@@ -73,7 +73,7 @@
 * if the SP is not in this range (e.g. flash has been erased) there is 
no valid application
 * the second entry in the vector table is the reset address, 
corresponding to the application start
 */
-   return (0x2000 == ((*application_start_address) & 0xFFF8));
+   return (HSRAM_ADDR == ((*application_start_address) & 0xFFF8));
 }

 /** Start the application

--
To view, visit https://gerrit.osmocom.org/12920
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I81a42637194cbf0b5152fe38c691522021ab7582
Gerrit-Change-Number: 12920
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)


Change in osmo-asf4-dfu[master]: minox: use RAM address define instead of hardcoded value

2019-02-15 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12920 )

Change subject: minox: use RAM address define instead of hardcoded value
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12920
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81a42637194cbf0b5152fe38c691522021ab7582
Gerrit-Change-Number: 12920
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Fri, 15 Feb 2019 10:27:54 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-asf4-dfu[master]: minox: use RAM address define instead of hardcoded value

2019-02-15 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( 
https://gerrit.osmocom.org/12920


Change subject: minox: use RAM address define instead of hardcoded value
..

minox: use RAM address define instead of hardcoded value

Change-Id: I81a42637194cbf0b5152fe38c691522021ab7582
---
M usb_dfu_main.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/20/12920/1

diff --git a/usb_dfu_main.c b/usb_dfu_main.c
index f431d29..19fe437 100644
--- a/usb_dfu_main.c
+++ b/usb_dfu_main.c
@@ -73,7 +73,7 @@
 * if the SP is not in this range (e.g. flash has been erased) there is 
no valid application
 * the second entry in the vector table is the reset address, 
corresponding to the application start
 */
-   return (0x2000 == ((*application_start_address) & 0xFFF8));
+   return (HSRAM_ADDR == ((*application_start_address) & 0xFFF8));
 }

 /** Start the application

--
To view, visit https://gerrit.osmocom.org/12920
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81a42637194cbf0b5152fe38c691522021ab7582
Gerrit-Change-Number: 12920
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon