Change in osmo-bsc[master]: LCLS: log config/control update

2018-12-20 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/12366 )

Change subject: LCLS: log config/control update
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12366
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac493014144ca0e5e1a83081e6e01ea7910deac2
Gerrit-Change-Number: 12366
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 20 Dec 2018 11:31:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: LCLS: log config/control update

2018-12-20 Thread Max 
Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12366 )

Change subject: LCLS: log config/control update
..

LCLS: log config/control update

Change-Id: Iac493014144ca0e5e1a83081e6e01ea7910deac2
---
M src/osmo-bsc/osmo_bsc_lcls.c
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Stefan Sperling: Looks good to me, but someone else must approve
  Max: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_lcls.c b/src/osmo-bsc/osmo_bsc_lcls.c
index 622611d..26b3244 100644
--- a/src/osmo-bsc/osmo_bsc_lcls.c
+++ b/src/osmo-bsc/osmo_bsc_lcls.c
@@ -169,13 +169,17 @@
if (!lcls_is_supported_config(new_cfg_csc->config))
return NULL;
if (conn->lcls.config != new_cfg_csc->config) {
-   /* TODO: logging */
+   LOGPFSM(conn->lcls.fi, "LCLS update Config %s -> %s\n",
+   gsm0808_lcls_config_name(conn->lcls.config),
+   gsm0808_lcls_config_name(new_cfg_csc->config));
conn->lcls.config = new_cfg_csc->config;
}
}
if (new_cfg_csc->control != GSM0808_LCLS_CSC_NA) {
if (conn->lcls.control != new_cfg_csc->control) {
-   /* TODO: logging */
+   LOGPFSM(conn->lcls.fi, "LCLS update Control %s -> %s\n",
+   gsm0808_lcls_control_name(conn->lcls.control),
+   
gsm0808_lcls_control_name(new_cfg_csc->control));
conn->lcls.control = new_cfg_csc->control;
}
}

--
To view, visit https://gerrit.osmocom.org/12366
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac493014144ca0e5e1a83081e6e01ea7910deac2
Gerrit-Change-Number: 12366
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: osmith

Change in osmo-bsc[master]: LCLS: log config/control update

2018-12-20 Thread Stefan Sperling 
Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12366 )

Change subject: LCLS: log config/control update
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12366
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac493014144ca0e5e1a83081e6e01ea7910deac2
Gerrit-Change-Number: 12366
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 20 Dec 2018 11:06:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: LCLS: log config/control update

2018-12-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12366 )

Change subject: LCLS: log config/control update
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12366
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac493014144ca0e5e1a83081e6e01ea7910deac2
Gerrit-Change-Number: 12366
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 19 Dec 2018 15:56:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: LCLS: log config/control update

2018-12-19 Thread Max 
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12366


Change subject: LCLS: log config/control update
..

LCLS: log config/control update

Change-Id: Iac493014144ca0e5e1a83081e6e01ea7910deac2
---
M src/osmo-bsc/osmo_bsc_lcls.c
1 file changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/66/12366/1

diff --git a/src/osmo-bsc/osmo_bsc_lcls.c b/src/osmo-bsc/osmo_bsc_lcls.c
index 622611d..26b3244 100644
--- a/src/osmo-bsc/osmo_bsc_lcls.c
+++ b/src/osmo-bsc/osmo_bsc_lcls.c
@@ -169,13 +169,17 @@
if (!lcls_is_supported_config(new_cfg_csc->config))
return NULL;
if (conn->lcls.config != new_cfg_csc->config) {
-   /* TODO: logging */
+   LOGPFSM(conn->lcls.fi, "LCLS update Config %s -> %s\n",
+   gsm0808_lcls_config_name(conn->lcls.config),
+   gsm0808_lcls_config_name(new_cfg_csc->config));
conn->lcls.config = new_cfg_csc->config;
}
}
if (new_cfg_csc->control != GSM0808_LCLS_CSC_NA) {
if (conn->lcls.control != new_cfg_csc->control) {
-   /* TODO: logging */
+   LOGPFSM(conn->lcls.fi, "LCLS update Control %s -> %s\n",
+   gsm0808_lcls_control_name(conn->lcls.control),
+   
gsm0808_lcls_control_name(new_cfg_csc->control));
conn->lcls.control = new_cfg_csc->control;
}
}

--
To view, visit https://gerrit.osmocom.org/12366
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac493014144ca0e5e1a83081e6e01ea7910deac2
Gerrit-Change-Number: 12366
Gerrit-PatchSet: 1
Gerrit-Owner: Max