Change in osmo-bsc[master]: gscon_forget_lchan(): Clear Request iff no lchans remain
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11310 ) Change subject: gscon_forget_lchan(): Clear Request iff no lchans remain .. gscon_forget_lchan(): Clear Request iff no lchans remain Send a BSSMAP Clear Request only if absolutely no lchan remains associated to the conn, anywhere (Assignment, Handover as well as primary lchan). Conceivable would be a situation where e.g. we're in handover and a new lchan is ready, when just at a time where it doesn't matter anymore the old lchan fails. We could just carry on with the new one then. Change-Id: Ibd8e38ccf7759b8834efdedf742c46c227b26e91 --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index 3c9be56..a8b3183 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -646,7 +646,9 @@ conn->lchan = NULL; if (conn->fi->state != ST_CLEARING - && !conn->lchan) + && !conn->lchan + && !conn->ho.new_lchan + && !conn->assignment.new_lchan) gscon_bssmap_clear(conn, GSM0808_CAUSE_EQUIPMENT_FAILURE); } -- To view, visit https://gerrit.osmocom.org/11310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibd8e38ccf7759b8834efdedf742c46c227b26e91 Gerrit-Change-Number: 11310 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-bsc[master]: gscon_forget_lchan(): Clear Request iff no lchans remain
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11310 ) Change subject: gscon_forget_lchan(): Clear Request iff no lchans remain .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd8e38ccf7759b8834efdedf742c46c227b26e91 Gerrit-Change-Number: 11310 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Fri, 12 Oct 2018 06:20:08 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: gscon_forget_lchan(): Clear Request iff no lchans remain
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11310 Change subject: gscon_forget_lchan(): Clear Request iff no lchans remain .. gscon_forget_lchan(): Clear Request iff no lchans remain Send a BSSMAP Clear Request only if absolutely no lchan remains associated to the conn, anywhere (Assignment, Handover as well as primary lchan). Conceivable would be a situation where e.g. we're in handover and a new lchan is ready, when just at a time where it doesn't matter anymore the old lchan fails. We could just carry on with the new one then. Change-Id: Ibd8e38ccf7759b8834efdedf742c46c227b26e91 --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/10/11310/1 diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index 3c9be56..a8b3183 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -646,7 +646,9 @@ conn->lchan = NULL; if (conn->fi->state != ST_CLEARING - && !conn->lchan) + && !conn->lchan + && !conn->ho.new_lchan + && !conn->assignment.new_lchan) gscon_bssmap_clear(conn, GSM0808_CAUSE_EQUIPMENT_FAILURE); } -- To view, visit https://gerrit.osmocom.org/11310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd8e38ccf7759b8834efdedf742c46c227b26e91 Gerrit-Change-Number: 11310 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr
