Change in osmo-bsc[master]: stats: Count paging requests flushed due to MSC Reset.
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/18427 )
Change subject: stats: Count paging requests flushed due to MSC Reset.
..
stats: Count paging requests flushed due to MSC Reset.
Change-Id: Ie93fc54fecdfcf615483f7f41a36dbcea61a537b
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/paging.c
2 files changed, 6 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index e6a7708..07a0c9d 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1409,6 +1409,7 @@
BTS_CTR_PAGING_RESPONDED,
BTS_CTR_PAGING_EXPIRED,
BTS_CTR_PAGING_NO_ACTIVE_PAGING,
+ BTS_CTR_PAGING_MSC_FLUSH,
BTS_CTR_CHAN_ACT_TOTAL,
BTS_CTR_CHAN_ACT_NACK,
BTS_CTR_RSL_UNKNOWN,
@@ -1455,6 +1456,7 @@
[BTS_CTR_PAGING_RESPONDED] ={"paging:responded", "Paging
attempts with successful paging response."},
[BTS_CTR_PAGING_EXPIRED] = {"paging:expired", "Paging
Request expired because of timeout T3113."},
[BTS_CTR_PAGING_NO_ACTIVE_PAGING] = {"paging:no_active_paging",
"Paging response without an active paging request (arrived after paging
expiration?)."},
+ [BTS_CTR_PAGING_MSC_FLUSH] ={"paging:msc_flush", "Paging
flushed due to MSC Reset BSSMAP message."},
[BTS_CTR_CHAN_ACT_TOTAL] = {"chan_act:total", "Total
number of Channel Activations."},
[BTS_CTR_CHAN_ACT_NACK] = {"chan_act:nack", "Number of
Channel Activations that the BTS NACKed"},
[BTS_CTR_RSL_UNKNOWN] = {"rsl:unknown", "Number of
unknown/unsupported RSL messages received from BTS"},
diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c
index d32cded..7b89dad 100644
--- a/src/osmo-bsc/paging.c
+++ b/src/osmo-bsc/paging.c
@@ -487,6 +487,7 @@
void paging_flush_bts(struct gsm_bts *bts, struct bsc_msc_data *msc)
{
struct gsm_paging_request *req, *req2;
+ int num_cancelled = 0;
paging_init_if_needed(bts);
@@ -496,7 +497,10 @@
/* now give up the data structure */
LOG_BTS(bts, DPAG, LOGL_DEBUG, "Stop paging %s (flush)\n",
bsc_subscr_name(req->bsub));
paging_remove_request(>paging, req);
+ num_cancelled++;
}
+
+ rate_ctr_add(>bts_ctrs->ctr[BTS_CTR_PAGING_MSC_FLUSH],
num_cancelled);
}
/*! Flush all paging requests issued by \a msc on any BTS in \a net */
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18427
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie93fc54fecdfcf615483f7f41a36dbcea61a537b
Gerrit-Change-Number: 18427
Gerrit-PatchSet: 2
Gerrit-Owner: ipse
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in osmo-bsc[master]: stats: Count paging requests flushed due to MSC Reset.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18427 ) Change subject: stats: Count paging requests flushed due to MSC Reset. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie93fc54fecdfcf615483f7f41a36dbcea61a537b Gerrit-Change-Number: 18427 Gerrit-PatchSet: 1 Gerrit-Owner: ipse Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 28 May 2020 08:57:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: stats: Count paging requests flushed due to MSC Reset.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18427 ) Change subject: stats: Count paging requests flushed due to MSC Reset. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie93fc54fecdfcf615483f7f41a36dbcea61a537b Gerrit-Change-Number: 18427 Gerrit-PatchSet: 1 Gerrit-Owner: ipse Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 23 May 2020 11:44:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: stats: Count paging requests flushed due to MSC Reset.
ipse has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/18427 )
Change subject: stats: Count paging requests flushed due to MSC Reset.
..
stats: Count paging requests flushed due to MSC Reset.
Change-Id: Ie93fc54fecdfcf615483f7f41a36dbcea61a537b
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/paging.c
2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/27/18427/1
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 38df1dc..214ad7f 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1414,6 +1414,7 @@
BTS_CTR_PAGING_RESPONDED_ELSEWHERE,
BTS_CTR_PAGING_EXPIRED,
BTS_CTR_PAGING_NO_ACTIVE_PAGING,
+ BTS_CTR_PAGING_MSC_FLUSH,
BTS_CTR_CHAN_ACT_TOTAL,
BTS_CTR_CHAN_ACT_NACK,
BTS_CTR_RSL_UNKNOWN,
@@ -1461,6 +1462,7 @@
[BTS_CTR_PAGING_RESPONDED_ELSEWHERE] = {"paging:responded_elsewhere",
"Paging attempts with paging response received on another BTS with the same
LAC."},
[BTS_CTR_PAGING_EXPIRED] = {"paging:expired", "Paging
Request expired because of timeout T3113."},
[BTS_CTR_PAGING_NO_ACTIVE_PAGING] = {"paging:no_active_paging",
"Paging response without an active paging request (arrived after paging
expiration?)."},
+ [BTS_CTR_PAGING_MSC_FLUSH] ={"paging:msc_flush", "Paging
flushed due to MSC Reset BSSMAP message."},
[BTS_CTR_CHAN_ACT_TOTAL] = {"chan_act:total", "Total
number of Channel Activations."},
[BTS_CTR_CHAN_ACT_NACK] = {"chan_act:nack", "Number of
Channel Activations that the BTS NACKed"},
[BTS_CTR_RSL_UNKNOWN] = {"rsl:unknown", "Number of
unknown/unsupported RSL messages received from BTS"},
diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c
index 3da6ecc..92039f6 100644
--- a/src/osmo-bsc/paging.c
+++ b/src/osmo-bsc/paging.c
@@ -489,6 +489,7 @@
void paging_flush_bts(struct gsm_bts *bts, struct bsc_msc_data *msc)
{
struct gsm_paging_request *req, *req2;
+ int num_cancelled = 0;
paging_init_if_needed(bts);
@@ -498,7 +499,10 @@
/* now give up the data structure */
LOG_BTS(bts, DPAG, LOGL_DEBUG, "Stop paging %s (flush)\n",
bsc_subscr_name(req->bsub));
paging_remove_request(>paging, req);
+ num_cancelled++;
}
+
+ rate_ctr_add(>bts_ctrs->ctr[BTS_CTR_PAGING_MSC_FLUSH],
num_cancelled);
}
/*! Flush all paging requests issued by \a msc on any BTS in \a net */
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18427
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie93fc54fecdfcf615483f7f41a36dbcea61a537b
Gerrit-Change-Number: 18427
Gerrit-PatchSet: 1
Gerrit-Owner: ipse
Gerrit-MessageType: newchange
