Change in osmo-bts[master]: osmo-bts-trx/scheduler: fix: print the last frame number in rx_data_fn()

2019-10-21 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15811 )

Change subject: osmo-bts-trx/scheduler: fix: print the last frame number in 
rx_data_fn()
..

osmo-bts-trx/scheduler: fix: print the last frame number in rx_data_fn()

All other Uplink burst handlers print frame number of the last
(currently received) burst. Let's make rx_data_fn() consistent.

Change-Id: Ie5762a132326be3ef4e4e38cc126f05d51098a20
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index 8662a14..d63987b 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -967,7 +967,7 @@
if ((*mask & 0xf) != 0xf) {
LOGL1S(DL1P, LOGL_NOTICE, l1t, bi->tn, chan, bi->fn,
"Received incomplete data (%u/%u)\n",
-   *first_fn, (*first_fn) % l1ts->mf_period);
+   bi->fn % l1ts->mf_period, l1ts->mf_period);

/* we require first burst to have correct FN */
if (!(*mask & 0x1)) {
@@ -982,7 +982,7 @@
if (rc) {
LOGL1S(DL1P, LOGL_NOTICE, l1t, bi->tn, chan, bi->fn,
"Received bad data (%u/%u)\n",
-   *first_fn, (*first_fn) % l1ts->mf_period);
+   bi->fn % l1ts->mf_period, l1ts->mf_period);
l2_len = 0;
} else
l2_len = GSM_MACBLOCK_LEN;

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15811
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie5762a132326be3ef4e4e38cc126f05d51098a20
Gerrit-Change-Number: 15811
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bts[master]: osmo-bts-trx/scheduler: fix: print the last frame number in rx_data_fn()

2019-10-21 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15811 )

Change subject: osmo-bts-trx/scheduler: fix: print the last frame number in 
rx_data_fn()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15811
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie5762a132326be3ef4e4e38cc126f05d51098a20
Gerrit-Change-Number: 15811
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 21 Oct 2019 11:21:51 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: osmo-bts-trx/scheduler: fix: print the last frame number in rx_data_fn()

2019-10-21 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15811 )

Change subject: osmo-bts-trx/scheduler: fix: print the last frame number in 
rx_data_fn()
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15811
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie5762a132326be3ef4e4e38cc126f05d51098a20
Gerrit-Change-Number: 15811
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 21 Oct 2019 08:47:59 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: osmo-bts-trx/scheduler: fix: print the last frame number in rx_data_fn()

2019-10-19 Thread fixeria 
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15811 )


Change subject: osmo-bts-trx/scheduler: fix: print the last frame number in 
rx_data_fn()
..

osmo-bts-trx/scheduler: fix: print the last frame number in rx_data_fn()

All other Uplink burst handlers print frame number of the last
(currently received) burst. Let's make rx_data_fn() consistent.

Change-Id: Ie5762a132326be3ef4e4e38cc126f05d51098a20
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/11/15811/1

diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index 8662a14..d63987b 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -967,7 +967,7 @@
if ((*mask & 0xf) != 0xf) {
LOGL1S(DL1P, LOGL_NOTICE, l1t, bi->tn, chan, bi->fn,
"Received incomplete data (%u/%u)\n",
-   *first_fn, (*first_fn) % l1ts->mf_period);
+   bi->fn % l1ts->mf_period, l1ts->mf_period);

/* we require first burst to have correct FN */
if (!(*mask & 0x1)) {
@@ -982,7 +982,7 @@
if (rc) {
LOGL1S(DL1P, LOGL_NOTICE, l1t, bi->tn, chan, bi->fn,
"Received bad data (%u/%u)\n",
-   *first_fn, (*first_fn) % l1ts->mf_period);
+   bi->fn % l1ts->mf_period, l1ts->mf_period);
l2_len = 0;
} else
l2_len = GSM_MACBLOCK_LEN;

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15811
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie5762a132326be3ef4e4e38cc126f05d51098a20
Gerrit-Change-Number: 15811
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange