Change in osmo-ccid-firmware[master]: PA11: Increase drive strength to 8mA
Kévin Redon has submitted this change and it was merged. ( https://gerrit.osmocom.org/13034 ) Change subject: PA11: Increase drive strength to 8mA .. PA11: Increase drive strength to 8mA It has been observed that the 20 MHz clock signal doesn't even remotely resemble a square shape unless DRVSTR=1 is set using this patch. Change-Id: I1366e13442eda829756aa4121be81eb15135c73e --- M sysmoOCTSIM/main.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Kévin Redon: Looks good to me, approved diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 09d766e..50e82c6 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -18,6 +18,7 @@ #include #include +#include #include "atmel_start.h" #include "atmel_start_pins.h" @@ -54,6 +55,10 @@ cache_init(); cache_enable(CMCC); + + /* increase drive strength of 20Mhz SIM clock output to 8mA +* (there are 8 inputs + traces to drive!) */ + hri_port_set_PINCFG_DRVSTR_bit(PORT, 0, 11); } int main(void) -- To view, visit https://gerrit.osmocom.org/13034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1366e13442eda829756aa4121be81eb15135c73e Gerrit-Change-Number: 13034 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Kévin Redon
Change in osmo-ccid-firmware[master]: PA11: Increase drive strength to 8mA
Kévin Redon has posted comments on this change. ( https://gerrit.osmocom.org/13034 ) Change subject: PA11: Increase drive strength to 8mA .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1366e13442eda829756aa4121be81eb15135c73e Gerrit-Change-Number: 13034 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Kévin Redon Gerrit-Comment-Date: Tue, 26 Feb 2019 18:08:21 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ccid-firmware[master]: PA11: Increase drive strength to 8mA
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13034 Change subject: PA11: Increase drive strength to 8mA .. PA11: Increase drive strength to 8mA It has been observed that the 20 MHz clock signal doesn't even remotely resemble a square shape unless DRVSTR=1 is set using this patch. Change-Id: I1366e13442eda829756aa4121be81eb15135c73e --- M sysmoOCTSIM/main.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/34/13034/1 diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 09d766e..50e82c6 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -18,6 +18,7 @@ #include #include +#include #include "atmel_start.h" #include "atmel_start_pins.h" @@ -54,6 +55,10 @@ cache_init(); cache_enable(CMCC); + + /* increase drive strength of 20Mhz SIM clock output to 8mA +* (there are 8 inputs + traces to drive!) */ + hri_port_set_PINCFG_DRVSTR_bit(PORT, 0, 11); } int main(void) -- To view, visit https://gerrit.osmocom.org/13034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1366e13442eda829756aa4121be81eb15135c73e Gerrit-Change-Number: 13034 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte