Change in osmo-ccid-firmware[master]: minor: change variable type to remove compiler warning
Kévin Redon has abandoned this change. ( https://gerrit.osmocom.org/13684 ) Change subject: minor: change variable type to remove compiler warning .. Abandoned compiler warning was related to other debug code not present in the commit -- To view, visit https://gerrit.osmocom.org/13684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I8f537d6cbec820ad0406ec2ff0c9735759169fc0 Gerrit-Change-Number: 13684 Gerrit-PatchSet: 9 Gerrit-Owner: Kévin Redon Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Harald Welte
Change in osmo-ccid-firmware[master]: minor: change variable type to remove compiler warning
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13684 ) Change subject: minor: change variable type to remove compiler warning .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/13684/2/sysmoOCTSIM/command.c File sysmoOCTSIM/command.c: https://gerrit.osmocom.org/#/c/13684/2/sysmoOCTSIM/command.c@81 PS2, Line 81: char c = getchar() this is odd, as in POSIX, getchar() is defined as returning an "int", not a "char". -- To view, visit https://gerrit.osmocom.org/13684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f537d6cbec820ad0406ec2ff0c9735759169fc0 Gerrit-Change-Number: 13684 Gerrit-PatchSet: 2 Gerrit-Owner: Kévin Redon Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Harald Welte Gerrit-Comment-Date: Wed, 17 Apr 2019 08:10:00 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-ccid-firmware[master]: minor: change variable type to remove compiler warning
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/13684
Change subject: minor: change variable type to remove compiler warning
..
minor: change variable type to remove compiler warning
Change-Id: I8f537d6cbec820ad0406ec2ff0c9735759169fc0
---
M sysmoOCTSIM/command.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware
refs/changes/84/13684/1
diff --git a/sysmoOCTSIM/command.c b/sysmoOCTSIM/command.c
index 327a1a0..8fbaec4 100644
--- a/sysmoOCTSIM/command.c
+++ b/sysmoOCTSIM/command.c
@@ -78,7 +78,7 @@
/* yield CPU after maximum of 10 received characters */
while (usart_async_rings_is_rx_not_empty(_debug) && (i < 10)) {
gpio_toggle_pin_level(USER_LED); // toggle LED to show we
received something
- int c = getchar();
+ char c = getchar();
if (c < 0)
return;
putchar(c);
--
To view, visit https://gerrit.osmocom.org/13684
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f537d6cbec820ad0406ec2ff0c9735759169fc0
Gerrit-Change-Number: 13684
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon
