Change in osmo-ccid-firmware[master]: minor: improve documentation
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/13683 )
Change subject: minor: improve documentation
..
minor: improve documentation
Change-Id: I250209d45a57c5ad7d1265a68aa71fc31ec06f69
---
M sysmoOCTSIM/ncn8025.h
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved; Verified
Jenkins Builder: Verified
diff --git a/sysmoOCTSIM/ncn8025.h b/sysmoOCTSIM/ncn8025.h
index 89b7f86..a2a6459 100644
--- a/sysmoOCTSIM/ncn8025.h
+++ b/sysmoOCTSIM/ncn8025.h
@@ -15,8 +15,8 @@
};
struct ncn8025_settings {
- bool rstin; /* high: active */
- bool cmdvcc;/* high: active */
+ bool rstin; /* Reset signal (true: asserted low) */
+ bool cmdvcc;/* Command VCC pin. Activation sequence Enable (true:
active low) */
bool simpres; /* high: active */
bool led; /* high: active */
bool interrupt; /* high: active */
--
To view, visit https://gerrit.osmocom.org/13683
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I250209d45a57c5ad7d1265a68aa71fc31ec06f69
Gerrit-Change-Number: 13683
Gerrit-PatchSet: 8
Gerrit-Owner: Kévin Redon
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-ccid-firmware[master]: minor: improve documentation
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13683 ) Change subject: minor: improve documentation .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.osmocom.org/13683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I250209d45a57c5ad7d1265a68aa71fc31ec06f69 Gerrit-Change-Number: 13683 Gerrit-PatchSet: 8 Gerrit-Owner: Kévin Redon Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Wed, 17 Apr 2019 09:56:00 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ccid-firmware[master]: minor: improve documentation
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13683 ) Change subject: minor: improve documentation .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I250209d45a57c5ad7d1265a68aa71fc31ec06f69 Gerrit-Change-Number: 13683 Gerrit-PatchSet: 7 Gerrit-Owner: Kévin Redon Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Wed, 17 Apr 2019 09:50:16 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ccid-firmware[master]: minor: improve documentation
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13683 to look at the new patch set (#7). Change subject: minor: improve documentation .. minor: improve documentation Change-Id: I250209d45a57c5ad7d1265a68aa71fc31ec06f69 --- M sysmoOCTSIM/ncn8025.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/83/13683/7 -- To view, visit https://gerrit.osmocom.org/13683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I250209d45a57c5ad7d1265a68aa71fc31ec06f69 Gerrit-Change-Number: 13683 Gerrit-PatchSet: 7 Gerrit-Owner: Kévin Redon Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-ccid-firmware[master]: minor: improve documentation
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13683 ) Change subject: minor: improve documentation .. Patch Set 2: Code-Review-1 this is no longer the case in master -- To view, visit https://gerrit.osmocom.org/13683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I250209d45a57c5ad7d1265a68aa71fc31ec06f69 Gerrit-Change-Number: 13683 Gerrit-PatchSet: 2 Gerrit-Owner: Kévin Redon Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Wed, 17 Apr 2019 08:09:07 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ccid-firmware[master]: minor: improve documentation
Kévin Redon has uploaded this change for review. (
https://gerrit.osmocom.org/13683
Change subject: minor: improve documentation
..
minor: improve documentation
Change-Id: I250209d45a57c5ad7d1265a68aa71fc31ec06f69
---
M sysmoOCTSIM/ncn8025.h
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware
refs/changes/83/13683/1
diff --git a/sysmoOCTSIM/ncn8025.h b/sysmoOCTSIM/ncn8025.h
index 89b7f86..48d2a58 100644
--- a/sysmoOCTSIM/ncn8025.h
+++ b/sysmoOCTSIM/ncn8025.h
@@ -15,8 +15,8 @@
};
struct ncn8025_settings {
- bool rstin; /* high: active */
- bool cmdvcc;/* high: active */
+ bool rstin; /* Reset signal (true: de-asserted high) */
+ bool cmdvcc;/* Command VCC pin. Activation sequence Enable (true:
active low) */
bool simpres; /* high: active */
bool led; /* high: active */
bool interrupt; /* high: active */
--
To view, visit https://gerrit.osmocom.org/13683
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I250209d45a57c5ad7d1265a68aa71fc31ec06f69
Gerrit-Change-Number: 13683
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon
