Change in osmo-ccid-firmware[master]: remove SWO pin initialisation
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13674 ) Change subject: remove SWO pin initialisation .. remove SWO pin initialisation using the SWO signal on TX has the advantage of being able to have printf debug while still using SERCOM7 in ISO7816 mode for the SIM card, but it has two drawbacks: - SWO outputs data only if a debug session is ongoing (e.g. a SWD debugger is connected). this saves output processing when no SWD is connected, but it is not possible to force output without having an SWD debugger connect (confirmed by Microchip help), which is not convenient for simple UART debugging. - no input is possible (SWO can only output). Thus instead we will still use SERCOM7 for UART debug, allowing commands to be input. SERCOM7 should only be used for UART debug when no card in present in SIM7. This check in not yet implemented. Change-Id: I199d6e356129526e65d5d1075a264eb35904d099 --- M sysmoOCTSIM/driver_init.c 1 file changed, 0 insertions(+), 47 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/sysmoOCTSIM/driver_init.c b/sysmoOCTSIM/driver_init.c index 06184ee..726129d 100644 --- a/sysmoOCTSIM/driver_init.c +++ b/sysmoOCTSIM/driver_init.c @@ -702,53 +702,6 @@ gpio_set_pin_function(SDA1, GPIO_PIN_FUNCTION_OFF); - // GPIO on PB30 - - gpio_set_pin_direction(UART_TX, - // Pin direction - // pad_direction - // Off - // In - // Out - GPIO_DIRECTION_OUT); - - gpio_set_pin_level(UART_TX, - // Initial level - // pad_initial_level - // Low - // High - false); - - gpio_set_pin_pull_mode(UART_TX, - // Pull configuration - // pad_pull_config - // Off - // Pull-up - // Pull-down - GPIO_PULL_OFF); - - gpio_set_pin_function(UART_TX, - // Pin function - // pad_function - // Auto : use driver pinmux if signal is imported by driver, else turn off function - // Auto - // Off - // A - // B - // C - // D - // E - // F - // G - // H - // I - // J - // K - // L - // M - // N - GPIO_PIN_FUNCTION_H); - // GPIO on PC00 // Set pin direction to input -- To view, visit https://gerrit.osmocom.org/13674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I199d6e356129526e65d5d1075a264eb35904d099 Gerrit-Change-Number: 13674 Gerrit-PatchSet: 7 Gerrit-Owner: Kévin Redon Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-ccid-firmware[master]: remove SWO pin initialisation
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13674 ) Change subject: remove SWO pin initialisation .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I199d6e356129526e65d5d1075a264eb35904d099 Gerrit-Change-Number: 13674 Gerrit-PatchSet: 6 Gerrit-Owner: Kévin Redon Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Wed, 17 Apr 2019 09:56:29 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ccid-firmware[master]: remove SWO pin initialisation
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13674 to look at the new patch set (#5). Change subject: remove SWO pin initialisation .. remove SWO pin initialisation using the SWO signal on TX has the advantage of being able to have printf debug while still using SERCOM7 in ISO7816 mode for the SIM card, but it has two drawbacks: - SWO outputs data only if a debug session is ongoing (e.g. a SWD debugger is connected). this saves output processing when no SWD is connected, but it is not possible to force output without having an SWD debugger connect (confirmed by Microchip help), which is not convenient for simple UART debugging. - no input is possible (SWO can only output). Thus instead we will still use SERCOM7 for UART debug, allowing commands to be input. SERCOM7 should only be used for UART debug when no card in present in SIM7. This check in not yet implemented. Change-Id: I199d6e356129526e65d5d1075a264eb35904d099 --- M sysmoOCTSIM/driver_init.c 1 file changed, 0 insertions(+), 47 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/74/13674/5 -- To view, visit https://gerrit.osmocom.org/13674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I199d6e356129526e65d5d1075a264eb35904d099 Gerrit-Change-Number: 13674 Gerrit-PatchSet: 5 Gerrit-Owner: Kévin Redon Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Harald Welte
Change in osmo-ccid-firmware[master]: remove SWO pin initialisation
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13674 ) Change subject: remove SWO pin initialisation .. Patch Set 3: requires explanation in commitlog. -- To view, visit https://gerrit.osmocom.org/13674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I199d6e356129526e65d5d1075a264eb35904d099 Gerrit-Change-Number: 13674 Gerrit-PatchSet: 3 Gerrit-Owner: Kévin Redon Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Harald Welte Gerrit-Comment-Date: Wed, 17 Apr 2019 08:28:41 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-ccid-firmware[master]: remove SWO pin initialisation
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13674 Change subject: remove SWO pin initialisation .. remove SWO pin initialisation Change-Id: I199d6e356129526e65d5d1075a264eb35904d099 --- M sysmoOCTSIM/driver_init.c 1 file changed, 0 insertions(+), 47 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/74/13674/1 diff --git a/sysmoOCTSIM/driver_init.c b/sysmoOCTSIM/driver_init.c index 0d5bb53..8a50925 100644 --- a/sysmoOCTSIM/driver_init.c +++ b/sysmoOCTSIM/driver_init.c @@ -723,53 +723,6 @@ gpio_set_pin_function(SDA1, GPIO_PIN_FUNCTION_OFF); - // GPIO on PB30 - - gpio_set_pin_direction(UART_TX, - // Pin direction - // pad_direction - // Off - // In - // Out - GPIO_DIRECTION_OUT); - - gpio_set_pin_level(UART_TX, - // Initial level - // pad_initial_level - // Low - // High - false); - - gpio_set_pin_pull_mode(UART_TX, - // Pull configuration - // pad_pull_config - // Off - // Pull-up - // Pull-down - GPIO_PULL_OFF); - - gpio_set_pin_function(UART_TX, - // Pin function - // pad_function - // Auto : use driver pinmux if signal is imported by driver, else turn off function - // Auto - // Off - // A - // B - // C - // D - // E - // F - // G - // H - // I - // J - // K - // L - // M - // N - GPIO_PIN_FUNCTION_H); - // GPIO on PC00 // Set pin direction to input -- To view, visit https://gerrit.osmocom.org/13674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I199d6e356129526e65d5d1075a264eb35904d099 Gerrit-Change-Number: 13674 Gerrit-PatchSet: 1 Gerrit-Owner: Kévin Redon
