Change in osmo-dev[master]: 3G+2G.deps: add osmo-trx

2018-10-31 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11389 )

Change subject: 3G+2G.deps: add osmo-trx
..


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11389/2/3G%2B2G.deps
File 3G+2G.deps:

https://gerrit.osmocom.org/#/c/11389/2/3G%2B2G.deps@16
PS2, Line 16: osmo-trx  libosmocore
how about in 2G.deps as well?



--
To view, visit https://gerrit.osmocom.org/11389
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ebf2732694cee0600b602b82c660cf6278958d
Gerrit-Change-Number: 11389
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:11:02 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes


Change in osmo-dev[master]: 3G+2G.deps: add osmo-trx

2018-10-31 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11389 )

Change subject: 3G+2G.deps: add osmo-trx
..


Patch Set 2: Code-Review+1

> I don't seem to have +2 in this repo.

not even I do here, because it's more or less a "private project" (of course 
it's public, but it's something Neels created without clear mandate to improve 
his workflow and shared it with a wider audience) by neels which intrinsically 
he as the original author has the ultimate say.


--
To view, visit https://gerrit.osmocom.org/11389
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ebf2732694cee0600b602b82c660cf6278958d
Gerrit-Change-Number: 11389
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 31 Oct 2018 08:21:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-dev[master]: 3G+2G.deps: add osmo-trx

2018-10-30 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11389 )

Change subject: 3G+2G.deps: add osmo-trx
..


Patch Set 2: Code-Review+1

I don't seem to have +2 in this repo.


--
To view, visit https://gerrit.osmocom.org/11389
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ebf2732694cee0600b602b82c660cf6278958d
Gerrit-Change-Number: 11389
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Tue, 30 Oct 2018 12:34:00 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-dev[master]: 3G+2G.deps: add osmo-trx

2018-10-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11389


Change subject: 3G+2G.deps: add osmo-trx
..

3G+2G.deps: add osmo-trx

Change-Id: Ia4ebf2732694cee0600b602b82c660cf6278958d
---
M 3G+2G.deps
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/89/11389/1

diff --git a/3G+2G.deps b/3G+2G.deps
index 5a17146..0eea175 100644
--- a/3G+2G.deps
+++ b/3G+2G.deps
@@ -13,3 +13,4 @@
 osmo-bsc   libosmo-sccp osmo-mgw
 osmo-sgsn  osmo-iuh osmo-ggsn
 osmo-sip-connector libosmocore
+osmo-trx   libosmocore

-- 
To view, visit https://gerrit.osmocom.org/11389
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4ebf2732694cee0600b602b82c660cf6278958d
Gerrit-Change-Number: 11389
Gerrit-PatchSet: 1
Gerrit-Owner: osmith