Change in osmo-gsm-tester[master]: iperf3: return 0 if iperf results can't be read back

2021-05-03 Thread srs_andre 
Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22037

to look at the new patch set (#15).

Change subject: iperf3: return 0 if iperf results can't be read back
..

iperf3: return 0 if iperf results can't be read back

usually the calling code, i.e. the test, will use the result
of the iperf run to check against a threshold. for that to
work the return value can't be None.

Change-Id: I5a8fe32f0a2bb676dbb80dad500bc6c63c176485
---
M src/osmo_gsm_tester/obj/iperf3.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/37/22037/15
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22037
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I5a8fe32f0a2bb676dbb80dad500bc6c63c176485
Gerrit-Change-Number: 22037
Gerrit-PatchSet: 15
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-gsm-tester[master]: iperf3: return 0 if iperf results can't be read back

2021-02-08 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22037 )

Change subject: iperf3: return 0 if iperf results can't be read back
..


Patch Set 9:

I added +2 here, but thinking about it, does it really make sense to mask the 
exception by default and return 0? I'm not that sure.

Id you really want to mute the exception, I'd do that in the caller of the 
method, not the method itself.


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22037
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I5a8fe32f0a2bb676dbb80dad500bc6c63c176485
Gerrit-Change-Number: 22037
Gerrit-PatchSet: 9
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 08 Feb 2021 17:03:47 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-gsm-tester[master]: iperf3: return 0 if iperf results can't be read back

2021-01-07 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22037 )

Change subject: iperf3: return 0 if iperf results can't be read back
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22037
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I5a8fe32f0a2bb676dbb80dad500bc6c63c176485
Gerrit-Change-Number: 22037
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 07 Jan 2021 17:11:00 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-gsm-tester[master]: iperf3: return 0 if iperf results can't be read back

2021-01-07 Thread srs_andre 
srs_andre has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22037 )


Change subject: iperf3: return 0 if iperf results can't be read back
..

iperf3: return 0 if iperf results can't be read back

usually the calling code, i.e. the test, will use the result
of the iperf run to check against a threshold. for that to
work the return value can't be None.

Change-Id: I5a8fe32f0a2bb676dbb80dad500bc6c63c176485
---
M src/osmo_gsm_tester/obj/iperf3.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/37/22037/1

diff --git a/src/osmo_gsm_tester/obj/iperf3.py 
b/src/osmo_gsm_tester/obj/iperf3.py
index 4785f78..6571491 100644
--- a/src/osmo_gsm_tester/obj/iperf3.py
+++ b/src/osmo_gsm_tester/obj/iperf3.py
@@ -76,7 +76,7 @@
 return recv['bits_per_second']/1e6
 except Exception as e:
 print("Exception while using iperf3 results: %r" % (repr(result)))
-pass
+return 0

 class IPerf3Server(log.Origin):


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22037
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I5a8fe32f0a2bb676dbb80dad500bc6c63c176485
Gerrit-Change-Number: 22037
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-MessageType: newchange