Change in osmo-gsm-tester[master]: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix expecte...
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/10438 ) Change subject: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix expected answer format .. osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix expected answer format Since osmo-hlr.git I1d09fab810a6bb9ab02904de72dbc9e8a414f9f9, USSD processing has been moved to osmo-hlr and prefix routing needs to be configured, otherwise USSD requested are answered back to the MS with an error "ss-NotAvailable (18)". mesage received for extension resolution (*#100#) had its format change, so update to new format (carriage return at the end was dropped). Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d --- M src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl M suites/aoip_ussd/assert_extension.py 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl index ccb8224..014efd3 100644 --- a/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl +++ b/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl @@ -13,3 +13,4 @@ hlr gsup bind ip ${hlr.ip_address.addr} + ussd route prefix *#100# internal own-msisdn diff --git a/suites/aoip_ussd/assert_extension.py b/suites/aoip_ussd/assert_extension.py index 56d853b..475de09 100755 --- a/suites/aoip_ussd/assert_extension.py +++ b/suites/aoip_ussd/assert_extension.py @@ -46,4 +46,5 @@ print('Sending ussd code %s' % USSD_COMMAND_GET_EXTENSION) response = ms.ussd_send(USSD_COMMAND_GET_EXTENSION) -assert ' ' + ms.msisdn + '\r' in response +log('got ussd response: %r' % repr(response)) +assert response.endswith(' ' + ms.msisdn) -- To view, visit https://gerrit.osmocom.org/10438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d Gerrit-Change-Number: 10438 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol
Change in osmo-gsm-tester[master]: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix expecte...
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10438 ) Change subject: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix expected answer format .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d Gerrit-Change-Number: 10438 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 13 Aug 2018 12:53:29 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-gsm-tester[master]: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix expecte...
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10438 to look at the new patch set (#2). Change subject: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix expected answer format .. osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix expected answer format Since osmo-hlr.git I1d09fab810a6bb9ab02904de72dbc9e8a414f9f9, USSD processing has been moved to osmo-hlr and prefix routing needs to be configured, otherwise USSD requested are answered back to the MS with an error "ss-NotAvailable (18)". mesage received for extension resolution (*#100#) had its format change, so update to new format (carriage return at the end was dropped). Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d --- M src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl M suites/aoip_ussd/assert_extension.py 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/38/10438/2 -- To view, visit https://gerrit.osmocom.org/10438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d Gerrit-Change-Number: 10438 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder
Change in osmo-gsm-tester[master]: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100#
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10438 ) Change subject: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d Gerrit-Change-Number: 10438 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 13 Aug 2018 10:09:04 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-gsm-tester[master]: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100#
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10438 Change subject: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# .. osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# Since osmo-hlr.git I1d09fab810a6bb9ab02904de72dbc9e8a414f9f9, USSD processing has been moved to osmo-ghlr and prfix routing needs to be configured, otherwise USSD requested are answered back to the MS with an error "ss-NotAvailable (18)". Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d --- M src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/38/10438/1 diff --git a/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl index ccb8224..014efd3 100644 --- a/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl +++ b/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl @@ -13,3 +13,4 @@ hlr gsup bind ip ${hlr.ip_address.addr} + ussd route prefix *#100# internal own-msisdn -- To view, visit https://gerrit.osmocom.org/10438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d Gerrit-Change-Number: 10438 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol