Change in osmo-gsm-tester[master]: srsue.conf.tmpl: reorder conditions for setting RRC release

2021-01-08 Thread pespin
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22034 )

Change subject: srsue.conf.tmpl: reorder conditions for setting RRC release
..

srsue.conf.tmpl: reorder conditions for setting RRC release

the order of checks needs to go from high to low, i.e. the higher
release feature (e.g. qam256) needs to be checked and set first.

in theory it should also be possible to have a CA-capable UE
that does not support QAM256, but for srsUE we announce both anyway.

Change-Id: I2fa49f0cb5d80db412a811ceeb380359c8ad67a7
---
M src/osmo_gsm_tester/templates/srsue.conf.tmpl
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/templates/srsue.conf.tmpl 
b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
index 120b938..a57857b 100644
--- a/src/osmo_gsm_tester/templates/srsue.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
@@ -147,14 +147,14 @@
 # mbms_service_port: Port of the MBMS service
 #
 [rrc]
-% if int(ue.num_carriers) > 1:
-ue_category   = 7
-release   = 10
-% elif "dl_qam256" in ue.features or "ul_qam64" in ue.features:
+% if "dl_qam256" in ue.features or "ul_qam64" in ue.features:
 ue_category   = 8
 release   = 13
 ue_category_dl= 14
 ue_category_ul= 5
+% elif int(ue.num_carriers) > 1:
+ue_category   = 7
+release   = 10
 % else:
 #ue_category   = 4
 #release   = 8

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22034
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I2fa49f0cb5d80db412a811ceeb380359c8ad67a7
Gerrit-Change-Number: 22034
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-gsm-tester[master]: srsue.conf.tmpl: reorder conditions for setting RRC release

2021-01-07 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22034 )

Change subject: srsue.conf.tmpl: reorder conditions for setting RRC release
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22034
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I2fa49f0cb5d80db412a811ceeb380359c8ad67a7
Gerrit-Change-Number: 22034
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 07 Jan 2021 17:09:01 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-gsm-tester[master]: srsue.conf.tmpl: reorder conditions for setting RRC release

2021-01-07 Thread srs_andre
srs_andre has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22034 )


Change subject: srsue.conf.tmpl: reorder conditions for setting RRC release
..

srsue.conf.tmpl: reorder conditions for setting RRC release

the order of checks needs to go from high to low, i.e. the higher
release feature (e.g. qam256) needs to be checked and set first.

in theory it should also be possible to have a CA-capable UE
that does not support QAM256, but for srsUE we announce both anyway.

Change-Id: I2fa49f0cb5d80db412a811ceeb380359c8ad67a7
---
M src/osmo_gsm_tester/templates/srsue.conf.tmpl
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/34/22034/1

diff --git a/src/osmo_gsm_tester/templates/srsue.conf.tmpl 
b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
index 120b938..a57857b 100644
--- a/src/osmo_gsm_tester/templates/srsue.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
@@ -147,14 +147,14 @@
 # mbms_service_port: Port of the MBMS service
 #
 [rrc]
-% if int(ue.num_carriers) > 1:
-ue_category   = 7
-release   = 10
-% elif "dl_qam256" in ue.features or "ul_qam64" in ue.features:
+% if "dl_qam256" in ue.features or "ul_qam64" in ue.features:
 ue_category   = 8
 release   = 13
 ue_category_dl= 14
 ue_category_ul= 5
+% elif int(ue.num_carriers) > 1:
+ue_category   = 7
+release   = 10
 % else:
 #ue_category   = 4
 #release   = 8

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22034
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I2fa49f0cb5d80db412a811ceeb380359c8ad67a7
Gerrit-Change-Number: 22034
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-MessageType: newchange