Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-20 Thread keith 
Attention is currently required from: neels, pespin, daniel, lynxis lazus.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

Patchset:

PS11:
> Hi, […]
I created a feature request https://osmocom.org/issues/5865

It's not that I don't think this issue could be refined, but I don't think this 
patch does anything badly, per se, and can be built upon if anyway wants 
further functionality. So merging.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: neels 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Fri, 20 Jan 2023 14:02:50 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: keith 
Comment-In-Reply-To: lynxis lazus 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-20 Thread keith 
keith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..

Add vty `reject-cause` to set the reject cause

Allow to set the LU reject cause independently for both of the
following cases; either when an IMSI is unknown to the HLR or
when the mslookup client does not a receive a timely response
to a GSUP request for the remote home HLR.

Original patchset modified by 

Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
---
M include/osmocom/hlr/hlr.h
M include/osmocom/hlr/hlr_vty.h
M src/hlr.c
M src/hlr_vty.c
M src/lu_fsm.c
M src/proxy.c
M tests/test_nodes.vty
7 files changed, 98 insertions(+), 6 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/hlr/hlr.h b/include/osmocom/hlr/hlr.h
index 3acb3c5..b27fb3d 100644
--- a/include/osmocom/hlr/hlr.h
+++ b/include/osmocom/hlr/hlr.h
@@ -23,6 +23,7 @@
 #pragma once

 #include 
+#include 
 #include 
 #include 
 #include 
@@ -55,6 +56,8 @@

struct llist_head euse_list;
struct hlr_euse *euse_default;
+   enum gsm48_gmm_cause reject_cause;
+   enum gsm48_gmm_cause no_proxy_reject_cause;

/* NCSS (call independent) session guard timeout value */
int ncss_guard_timeout;
diff --git a/include/osmocom/hlr/hlr_vty.h b/include/osmocom/hlr/hlr_vty.h
index 10eddc3..83691b8 100644
--- a/include/osmocom/hlr/hlr_vty.h
+++ b/include/osmocom/hlr/hlr_vty.h
@@ -45,5 +45,5 @@

 int hlr_vty_is_config_node(struct vty *vty, int node);
 int hlr_vty_go_parent(struct vty *vty);
-void hlr_vty_init(void);
+void hlr_vty_init(void *hlr_ctx);
 void dgsm_vty_init(void);
diff --git a/src/hlr.c b/src/hlr.c
index c6ae4fc..8183d9b 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -324,7 +324,7 @@
  " Returning slightly 
inaccurate cause 'IMSI Unknown' via GSUP");
return rc;
case -ENOENT:
-   osmo_gsup_req_respond_err(req, GMM_CAUSE_IMSI_UNKNOWN, 
"IMSI unknown");
+   osmo_gsup_req_respond_err(req, g_hlr->reject_cause, 
"IMSI unknown");
return rc;
default:
osmo_gsup_req_respond_err(req, GMM_CAUSE_NET_FAIL, 
"failure to look up IMSI in db");
@@ -759,6 +759,8 @@
g_hlr->db_file_path = talloc_strdup(g_hlr, HLR_DEFAULT_DB_FILE_PATH);
g_hlr->mslookup.server.mdns.domain_suffix = talloc_strdup(g_hlr, 
OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT);
g_hlr->mslookup.client.mdns.domain_suffix = talloc_strdup(g_hlr, 
OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT);
+   g_hlr->reject_cause = GMM_CAUSE_IMSI_UNKNOWN;
+   g_hlr->no_proxy_reject_cause = GMM_CAUSE_IMSI_UNKNOWN;

/* Init default (call independent) SS session guard timeout value */
g_hlr->ncss_guard_timeout = NCSS_GUARD_TIMEOUT_DEFAULT;
@@ -775,7 +777,7 @@
osmo_stats_init(hlr_ctx);
vty_init(_info);
ctrl_vty_init(hlr_ctx);
-   hlr_vty_init();
+   hlr_vty_init(hlr_ctx);
dgsm_vty_init();
osmo_cpu_sched_vty_init(hlr_ctx);
handle_options(argc, argv);
diff --git a/src/hlr_vty.c b/src/hlr_vty.c
index a440c42..02e0cde 100644
--- a/src/hlr_vty.c
+++ b/src/hlr_vty.c
@@ -25,7 +25,10 @@
  *
  */

+#include 
+
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -40,6 +43,36 @@
 #include 
 #include 

+static const struct value_string gsm48_gmm_cause_vty_names[] = {
+   { GMM_CAUSE_IMSI_UNKNOWN,   "imsi-unknown" },
+   { GMM_CAUSE_ILLEGAL_MS, "illegal-ms" },
+   { GMM_CAUSE_PLMN_NOTALLOWED,"plmn-not-allowed" },
+   { GMM_CAUSE_LA_NOTALLOWED,  "la-not-allowed" },
+   { GMM_CAUSE_ROAMING_NOTALLOWED, "roaming-not-allowed" },
+   { GMM_CAUSE_NO_SUIT_CELL_IN_LA, "no-suitable-cell-in-la" },
+   { GMM_CAUSE_NET_FAIL,   "net-fail" },
+   { GMM_CAUSE_CONGESTION, "congestion" },
+   { GMM_CAUSE_GSM_AUTH_UNACCEPT,  "auth-unacceptable" },
+   { GMM_CAUSE_PROTO_ERR_UNSPEC,   "proto-error-unspec" },
+   { 0, NULL },
+};
+
+/* TS 24.008 4.4.4.7 */
+static const struct value_string gsm48_gmm_cause_vty_descs[] = {
+   { GMM_CAUSE_IMSI_UNKNOWN,   " #02: (IMSI unknown in HLR)" },
+   { GMM_CAUSE_ILLEGAL_MS, " #03  (Illegal MS)" },
+   { GMM_CAUSE_PLMN_NOTALLOWED," #11: (PLMN not allowed)" },
+   { GMM_CAUSE_LA_NOTALLOWED,  " #12: (Location Area not allowed)" },
+   { GMM_CAUSE_ROAMING_NOTALLOWED, " #13: (Roaming not allowed in this 
location area)" },
+   { GMM_CAUSE_NO_SUIT_CELL_IN_LA, " #15: (No Suitable Cells In Location 
Area [continue search in PLMN])." },
+   { GMM_CAUSE_NET_FAIL,   " #17: (Network Failure)" },
+   { GMM_CAUSE_CONGESTION, " #22:

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-20 Thread pespin 
Attention is currently required from: neels, keith, daniel, lynxis lazus.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

Patchset:

PS11:
> @pespin: My motivation is for c3 events. The problem here lies in the spec. 
> […]
Hi,
fine go with the merge if you want, since you both seem to have been looking 
more at the problem. I only wanted to make sure this was properly considered.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: neels 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: keith 
Gerrit-Attention: daniel 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Fri, 20 Jan 2023 13:32:34 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: keith 
Comment-In-Reply-To: lynxis lazus 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-19 Thread lynxis lazus 
Attention is currently required from: neels, pespin, keith, daniel.
lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

Patchset:

PS11:
> *from the spec what the intention is, AND HOW the MS behaviour...
@pespin: My motivation is for c3 events. The problem here lies in the spec. 
There isn't the case, you're doing a small network outside of the 3GPP network. 
For c3 events we want to tell other SIM (normal operator) just 
roaming-not-allowed here. Because we will never reach their HLR. IMHO: 
Unknown-in-HLR is just wrong for foreign sim cards.

In the best case we would have a regex to tell our HLR what are valid ranges 
for our simcards. Return Roaming-not-allowed for everything what not matches 
our regex and if it matches our regex but not in our return Unknown-in-HLR.

Go for merge. Thank you Keith!



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: neels 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Attention: keith 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Thu, 19 Jan 2023 23:30:58 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: keith 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-19 Thread keith 
Attention is currently required from: neels, pespin, daniel, lynxis lazus.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

Patchset:

PS11:
> This also would not be the first time that a feature that is entirely (even 
> it it were so) investiga […]
*from the spec what the intention is, AND HOW the MS behaviour...



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: neels 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Thu, 19 Jan 2023 16:54:41 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: keith 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-19 Thread keith 
Attention is currently required from: neels, pespin, daniel, lynxis lazus.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

Patchset:

PS11:
> and I'm not against keeping the functionality clean, and I'm all for 
> questioning the need for patche […]
This also would not be the first time that a feature that is entirely (even it 
it were so) investigation/testing based was included in mainstream osmo

I wonder what does a commercial HLR look like, I mean there are quite some LU 
reject causes. osmo-hlr uses ONE of them, hard coded. Maybe it's one of those 
things in the spec where options kept getting added, but really there's only 
one or two in use. Probably not the HLRs decision anyway?
When would an operator decide between #12 and #15 for example? For me it's 
quite hard to see form the spec what the intention is as to have the MS 
behaviour differs between them.

The difference between "forbidden location areas for regional provision of 
service" and "forbidden location areas for roaming" seems subtle, as does the 
difference between "shall perform a cell selection" and "shall search for a 
suitable cell in another location area" - given that the LAI was added to the 
forbidden list.

Maybe #15 is never intended for use when a SIM attempts to connect to it's HOME 
network. I guess that kind of thing could be automatic in the code;

Is the IMSI "ours"? -> then #12 else #15



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: neels 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Thu, 19 Jan 2023 16:52:46 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: keith 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-19 Thread keith 
Attention is currently required from: neels, pespin, daniel, lynxis lazus.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

Patchset:

PS11:
> I'm not against merging this patch, but I'm raising the topic since we seem 
> to merging a feature whi […]
and I'm not against keeping the functionality clean, and I'm all for 
questioning the need for patches and for hearing more voices on it.

That said, I'm stumped to know how the code would automatically know on which 
site the operator would like to reject [not found at this time in dGSM] IMSIs 
with CONGESTION and on which sites with "ROAMING NOT ALLOWED".

Maybe if I include libosmo-chatgpt.h
;-)

Also, I don't see that this patch, or any other for that matter, that does not 
change default behaviour, but rather adds an OPTIONAL vty param that the user 
is free to ignore, creates a need for the user to configure it.

I am now more curious about what lynxis' motivation at 36c3 was. I sort of 
remember something about it.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: neels 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Thu, 19 Jan 2023 16:31:42 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-19 Thread pespin 
Attention is currently required from: neels, keith, daniel, lynxis lazus.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

Patchset:

PS11:
I'm not against merging this patch, but I'm raising the topic since we seem to 
merging a feature which is actually meant only to "do some tests to find out 
real behavior", so it's not something users will need in the end.
If you have a specific case in dGSM where you'd like to change the returned 
cause based on case "1" or "2" you described, that should be done in the code 
automatically without need for the user to configure it.
I'd like to hear motivations from @lynxis too regarding this patch. If others 
are fine with merging this then feel free to merge.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: neels 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: keith 
Gerrit-Attention: daniel 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Thu, 19 Jan 2023 11:15:36 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-18 Thread keith 
Attention is currently required from: pespin, lynxis lazus.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

Patchset:

PS11:
> Hi @keith, maybe what I'm missing here is the rationale on WHY is this 
> needed. […]
Hi @pespin.
I my case, I was interested to see how the phones were actually behaving with 
the different LU Reject reasons. It seems like they don't really behave as in 
the spec. (TS24.008 4.4.4.7)

I got bored of recompiling osmo-msc with hard coded reject causes and then I 
noticed this patch in CR from @lynxis.

Given the patch originally almost made it through CR, and it seems like it was 
something that lynxis wanted at a c3 event for whatever reason, I decided to 
fix it up and submit a patchset. It might be interesting to know if lynxis 
remembers or still has any interest.

>From my point of view, there is one use case where I might want to configure 
>the LU reject cause at runtime, which has to do with dGSM.

If I reject an MS because no HLR responds to a distributed request for a home 
HLR; this may have happened because, 1) there is no home HLR or 2) the home HLR 
was offline/unreachable at the moment of the LUR.

In the first case, I guess I would like the phone to go away and never LUR 
again, (at least until T3245 expires), in the second case, I might like it to 
try again rather soon. Now, as I said, accord the the spec i mentioned above, 
if I were to send a cause @2 "IMSI unknown in HLR" - which is the current 
default, I would expect: "The mobile station shall set the update status to 
ROAMING NOT ALLOWED (and store it in the SIM/USIM and delete any TMSI, stored 
LAI [etc]
consider the SIM/USIM as invalid for non-GPRS services until switch-off or the 
SIM/USIM is removed or the timer T3245 expires as described in subclause 
4.1.1.6."

Howver, All the ME I tried DON'T do this, but rather they try again every 20 
seconds up to 8 times and then continuously on what seems like the T3212 timer. 
However, with cause #13 the ME seems to NOT retry in the cell again, at least 
not immediately. Anyway, seems like one might like to do some trial and error 
with one's own situation in this and therefore being able to configure this via 
the vty might be "handy" (sorry for unintended bad pun, German speakers)

We have some sites that don't have many phones trying to connect, we also have 
some that have 1000s, so on the busy site, I might prefer to set a cuase then 
makes them back off, at the expense of loosing the odd "orphan" "roaming" user 
(until they power cycles/toggle airplane mode) - whereas on the not busy site, 
I might set a reject cause like CONGESTION that allows that phone to keep 
trying in the hope their home HLR came back online.

@pespin, if you'ld like any of the above in the commit msg for this patchset, 
please feel free to copy and paste, I also have a series of commits related to 
dGSM in the works, including documentation update, so I can include some of the 
above text there also.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Wed, 18 Jan 2023 20:48:32 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-18 Thread pespin 
Attention is currently required from: keith, lynxis lazus.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

Patchset:

PS11:
Hi @keith, maybe what I'm missing here is the rationale on WHY is this needed. 
What's the rationale behind wanting to change the reported cause?



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: keith 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Wed, 18 Jan 2023 14:57:44 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-18 Thread fixeria 
Attention is currently required from: keith, lynxis lazus.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11: Code-Review+2

(5 comments)

Patchset:

PS6:
> CR-1 for incomplete command description. […]
Done


File src/hlr_vty.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/f3deb0b1_35c2f6af
PS4, Line 85: get_value_string_or_null
> We should not get NULL if everything is correct I think.
Done


https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/70fe5a9a_2f73a111
PS4, Line 356: imsi unknown cause
> Given that you're adding a value-string array now, it would be better to 
> generate the command and he […]
Done


https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/982d00c0_09315dd9
PS4, Line 357: GSUP cause
> Saying GSUP/GMM is an option ;) But I don't want to block you here, so you 
> can keep this as is.
Done


File src/hlr_vty.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/262e98ac_6b0de870
PS6, Line 381: imsi unknown cause
> Here I would recommend concatenating all three words using '-', i.e. 
> 'imsi-unknown-cause'. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: keith 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Wed, 18 Jan 2023 11:00:03 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria 
Comment-In-Reply-To: lynxis lazus 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-17 Thread laforge 
Attention is currently required from: fixeria, keith, lynxis lazus.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: keith 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Wed, 18 Jan 2023 06:56:20 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-12 Thread keith 
Attention is currently required from: fixeria, lynxis lazus.
keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..


Patch Set 11:

(1 comment)

File src/hlr_vty.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/43a98a45_ea580d86
PS4, Line 88: imsi_cause_code
> It seems to be a common practice in Osmocom to not print parameters with 
> default values. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: keith 
Gerrit-CC: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Thu, 12 Jan 2023 22:05:29 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Comment-In-Reply-To: lynxis lazus 
Gerrit-MessageType: comment

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-12 Thread keith 
Attention is currently required from: keith, lynxis lazus.
keith has uploaded a new patch set (#10) to the change originally created by 
lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..

Add vty `reject-cause` to set the reject cause

Allow to set the LU reject cause independently for both of the
following cases; either when an IMSI is unknown to the HLR or
when the mslookup client does not a receive a timely response
to a GSUP request for the remote home HLR.

Original patchset modified by 

Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
---
M include/osmocom/hlr/hlr.h
M include/osmocom/hlr/hlr_vty.h
M src/hlr.c
M src/hlr_vty.c
M src/lu_fsm.c
M src/proxy.c
M tests/test_nodes.vty
7 files changed, 98 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/08/16808/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: pespin 
Gerrit-Attention: keith 
Gerrit-Attention: lynxis lazus 
Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-12 Thread keith 
Attention is currently required from: keith, lynxis lazus.
keith has uploaded a new patch set (#9) to the change originally created by 
lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..

Add vty `reject-cause` to set the reject cause

Allow to set the reject cause when an IMSI is unknown to the HLR.
Most common on reject causes are GMM_CAUSE_IMSI_UNKNOWN (2) or
CAUSE_ROAMING_NOTALLOWED (11).

Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
---
M include/osmocom/hlr/hlr.h
M include/osmocom/hlr/hlr_vty.h
M src/hlr.c
M src/hlr_vty.c
M src/lu_fsm.c
M src/proxy.c
M tests/test_nodes.vty
7 files changed, 98 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/08/16808/9
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: pespin 
Gerrit-Attention: keith 
Gerrit-Attention: lynxis lazus 
Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-12 Thread keith 
Attention is currently required from: keith, lynxis lazus.
keith has uploaded a new patch set (#8) to the change originally created by 
lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..

Add vty `reject-cause` to set the reject cause

Allow to set the reject cause when an IMSI is unknown to the HLR.
Most common on reject causes are GMM_CAUSE_IMSI_UNKNOWN (2) or
CAUSE_ROAMING_NOTALLOWED (11).

Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
---
M include/osmocom/hlr/hlr.h
M include/osmocom/hlr/hlr_vty.h
M src/hlr.c
M src/hlr_vty.c
M tests/test_nodes.vty
5 files changed, 87 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/08/16808/8
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: pespin 
Gerrit-Attention: keith 
Gerrit-Attention: lynxis lazus 
Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

2023-01-12 Thread keith 
Attention is currently required from: lynxis lazus.
keith has uploaded a new patch set (#7) to the change originally created by 
lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )

Change subject: Add vty `reject-cause` to set the reject cause
..

Add vty `reject-cause` to set the reject cause

Allow to set the reject cause when an IMSI is unknown to the HLR.
Most common on reject causes are GMM_CAUSE_IMSI_UNKNOWN (2) or
CAUSE_ROAMING_NOTALLOWED (11).

Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
---
M include/osmocom/hlr/hlr.h
M src/hlr.c
M src/hlr_vty.c
M tests/test_nodes.vty
4 files changed, 75 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/08/16808/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a
Gerrit-Change-Number: 16808
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-MessageType: newpatchset