Change in osmo-mgw[master]: osmux.h: Document enum osmux_state

2018-10-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11382 )

Change subject: osmux.h: Document enum osmux_state
..

osmux.h: Document enum osmux_state

Port for openbsc 9ae32d0d0607f270f20239b8104e09ec20352301.
Change-Id: I28978fa505d259f144457f29af4ba615aeaac74c
---
M include/osmocom/mgcp/osmux.h
1 file changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/mgcp/osmux.h b/include/osmocom/mgcp/osmux.h
index ea849c8..685be9c 100644
--- a/include/osmocom/mgcp/osmux.h
+++ b/include/osmocom/mgcp/osmux.h
@@ -24,10 +24,10 @@
 int osmux_used_cid(void);

 enum osmux_state {
-   OSMUX_STATE_DISABLED = 0,
-   OSMUX_STATE_NEGOTIATING,
-   OSMUX_STATE_ACTIVATING,
-   OSMUX_STATE_ENABLED,
+   OSMUX_STATE_DISABLED = 0, /* Osmux not being currently used by endp */
+   OSMUX_STATE_NEGOTIATING,  /* Osmux was locally requested in MGCP CRCX */
+   OSMUX_STATE_ACTIVATING,   /* Osmux was accepted in MGCP CRCX ACK. It 
can now be enabled by \ref osmux_enable_endpoint. */
+   OSMUX_STATE_ENABLED,  /* Osmux was initialized by \ref 
osmux_enable_endpoint and can process frames */
 };

 enum osmux_usage {
@@ -35,4 +35,3 @@
OSMUX_USAGE_ON = 1,
OSMUX_USAGE_ONLY = 2,
 };
-

--
To view, visit https://gerrit.osmocom.org/11382
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I28978fa505d259f144457f29af4ba615aeaac74c
Gerrit-Change-Number: 11382
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)


Change in osmo-mgw[master]: osmux.h: Document enum osmux_state

2018-10-16 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11382 )

Change subject: osmux.h: Document enum osmux_state
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11382
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28978fa505d259f144457f29af4ba615aeaac74c
Gerrit-Change-Number: 11382
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 16 Oct 2018 20:44:54 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-mgw[master]: osmux.h: Document enum osmux_state

2018-10-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11382


Change subject: osmux.h: Document enum osmux_state
..

osmux.h: Document enum osmux_state

Port for openbsc 9ae32d0d0607f270f20239b8104e09ec20352301.
Change-Id: I28978fa505d259f144457f29af4ba615aeaac74c
---
M include/osmocom/mgcp/osmux.h
1 file changed, 4 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/82/11382/1

diff --git a/include/osmocom/mgcp/osmux.h b/include/osmocom/mgcp/osmux.h
index ea849c8..685be9c 100644
--- a/include/osmocom/mgcp/osmux.h
+++ b/include/osmocom/mgcp/osmux.h
@@ -24,10 +24,10 @@
 int osmux_used_cid(void);

 enum osmux_state {
-   OSMUX_STATE_DISABLED = 0,
-   OSMUX_STATE_NEGOTIATING,
-   OSMUX_STATE_ACTIVATING,
-   OSMUX_STATE_ENABLED,
+   OSMUX_STATE_DISABLED = 0, /* Osmux not being currently used by endp */
+   OSMUX_STATE_NEGOTIATING,  /* Osmux was locally requested in MGCP CRCX */
+   OSMUX_STATE_ACTIVATING,   /* Osmux was accepted in MGCP CRCX ACK. It 
can now be enabled by \ref osmux_enable_endpoint. */
+   OSMUX_STATE_ENABLED,  /* Osmux was initialized by \ref 
osmux_enable_endpoint and can process frames */
 };

 enum osmux_usage {
@@ -35,4 +35,3 @@
OSMUX_USAGE_ON = 1,
OSMUX_USAGE_ONLY = 2,
 };
-

--
To view, visit https://gerrit.osmocom.org/11382
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I28978fa505d259f144457f29af4ba615aeaac74c
Gerrit-Change-Number: 11382
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol