Change in osmo-msc[master]: Turn off secure_delete in sqlite
keith has submitted this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/28341 )
Change subject: Turn off secure_delete in sqlite
..
Turn off secure_delete in sqlite
libsqlite3 that ships with some distributions may have secure_delete
activated by default. This means all database records are overwritten
with zeros on DELETE. We don't needs this extra overhead.
Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
---
M src/libmsc/db.c
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
keith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/libmsc/db.c b/src/libmsc/db.c
index 0237716..d12f04c 100644
--- a/src/libmsc/db.c
+++ b/src/libmsc/db.c
@@ -569,6 +569,13 @@
/* non-fatal */
}
+ rc = sqlite3_exec(g_dbc->db, "PRAGMA secure_delete=0;", 0, 0, _msg);
+ if (rc != SQLITE_OK) {
+ LOGP(DDB, LOGL_ERROR, "Unable to disable SECURE_DELETE: %s\n",
err_msg);
+ sqlite3_free(err_msg);
+ /* non-fatal */
+ }
+
return 0;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
Gerrit-Change-Number: 28341
Gerrit-PatchSet: 5
Gerrit-Owner: keith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: keith
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-msc[master]: Turn off secure_delete in sqlite
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28341 ) Change subject: Turn off secure_delete in sqlite .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e Gerrit-Change-Number: 28341 Gerrit-PatchSet: 5 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 08 Jul 2022 00:09:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: Turn off secure_delete in sqlite
Attention is currently required from: keith. Hello Jenkins Builder, fixeria, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28341 to look at the new patch set (#5). Change subject: Turn off secure_delete in sqlite .. Turn off secure_delete in sqlite libsqlite3 that ships with some distributions may have secure_delete activated by default. This means all database records are overwritten with zeros on DELETE. We don't needs this extra overhead. Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e --- M src/libmsc/db.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/28341/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e Gerrit-Change-Number: 28341 Gerrit-PatchSet: 5 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: keith Gerrit-MessageType: newpatchset
Change in osmo-msc[master]: Turn off secure_delete in sqlite
Attention is currently required from: keith. Hello Jenkins Builder, fixeria, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28341 to look at the new patch set (#4). Change subject: Turn off secure_delete in sqlite .. Turn off secure_delete in sqlite libsqlite3 that ships with some distributions may have secure_delete activated by default. This means all database records are overwritten with zeros on DELETE. We don't needs this extra overhead. Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e --- M src/libmsc/db.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/28341/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e Gerrit-Change-Number: 28341 Gerrit-PatchSet: 4 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: keith Gerrit-MessageType: newpatchset
Change in osmo-msc[master]: Turn off secure_delete in sqlite
Attention is currently required from: keith. Hello Jenkins Builder, fixeria, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28341 to look at the new patch set (#3). Change subject: Turn off secure_delete in sqlite .. Turn off secure_delete in sqlite libsqlite3 that ships with some distributions may have secure_delete activated by default. This means all database records are overwritten with zeros on DELETE. We don't needs this extra overhead. Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e --- M src/libmsc/db.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/28341/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e Gerrit-Change-Number: 28341 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: keith Gerrit-MessageType: newpatchset
Change in osmo-msc[master]: Turn off secure_delete in sqlite
Attention is currently required from: keith. Hello Jenkins Builder, fixeria, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28341 to look at the new patch set (#2). Change subject: Turn off secure_delete in sqlite .. Turn off secure_delete in sqlite libsqlite3 that ships with some distributions may have secure_delete activated by default. This means all database records are overwritten with zeros on DELETE. We don't needs this extra overhead. Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e --- M src/libmsc/db.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/28341/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e Gerrit-Change-Number: 28341 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: keith Gerrit-MessageType: newpatchset
Change in osmo-msc[master]: Turn off secure_delete in sqlite
Attention is currently required from: keith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28341 ) Change subject: Turn off secure_delete in sqlite .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e Gerrit-Change-Number: 28341 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: keith Gerrit-Comment-Date: Thu, 07 Jul 2022 09:39:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: Turn off secure_delete in sqlite
Attention is currently required from: keith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28341 ) Change subject: Turn off secure_delete in sqlite .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e Gerrit-Change-Number: 28341 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: keith Gerrit-Comment-Date: Mon, 04 Jul 2022 09:00:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: Turn off secure_delete in sqlite
Attention is currently required from: keith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28341 ) Change subject: Turn off secure_delete in sqlite .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e Gerrit-Change-Number: 28341 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: keith Gerrit-Comment-Date: Mon, 20 Jun 2022 08:57:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: Turn off secure_delete in sqlite
keith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-msc/+/28341 )
Change subject: Turn off secure_delete in sqlite
..
Turn off secure_delete in sqlite
libsqlite3 that ships with some distributions may have secure_delete
activated by default. This means all database records are overwritten with
zeros on DELETE. We don't needs this extra overhead.
Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
---
M src/libmsc/db.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/28341/1
diff --git a/src/libmsc/db.c b/src/libmsc/db.c
index ea0fef3..b310fae 100644
--- a/src/libmsc/db.c
+++ b/src/libmsc/db.c
@@ -585,6 +585,12 @@
sqlite3_free(err_msg);
/* non-fatal */
}
+ rc = sqlite3_exec(g_dbc->db, "PRAGMA secure_delete=0;", 0, 0, _msg);
+ if (rc != SQLITE_OK) {
+ LOGP(DDB, LOGL_ERROR, "Unable to disable SECURE_DELETE: %s\n",
err_msg);
+ sqlite3_free(err_msg);
+ /* non-fatal */
+ }
rc = sqlite3_exec(g_dbc->db, "PRAGMA temp_store=MEMORY;", 0, 0,
_msg);
if (rc != SQLITE_OK) {
LOGP(DDB, LOGL_ERROR, "Unable to set TEMP_STORE: %s\n",
err_msg);
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e
Gerrit-Change-Number: 28341
Gerrit-PatchSet: 1
Gerrit-Owner: keith
Gerrit-MessageType: newchange
