Change in osmo-msc[master]: Use proper type for tch_rtp_connect() parameter

2018-12-18 Thread Max 
Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12330 )

Change subject: Use proper type for tch_rtp_connect() parameter
..

Use proper type for tch_rtp_connect() parameter

Change-Id: I6e2efcd2e25d6ec2ff35a4b8cfcda02abe97fa59
---
M src/libmsc/gsm_04_08_cc.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Max: Looks good to me, approved
  Stefan Sperling: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, but someone else must approve



diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c
index 15c6d9d..5500f6f 100644
--- a/src/libmsc/gsm_04_08_cc.c
+++ b/src/libmsc/gsm_04_08_cc.c
@@ -1761,10 +1761,9 @@
return 0;
 }

-static int tch_rtp_connect(struct gsm_network *net, void *arg)
+static int tch_rtp_connect(struct gsm_network *net, struct gsm_mncc_rtp *rtp)
 {
struct gsm_trans *trans;
-   struct gsm_mncc_rtp *rtp = arg;
struct in_addr addr;

/* FIXME: in *rtp we should get the codec information of the remote

--
To view, visit https://gerrit.osmocom.org/12330
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e2efcd2e25d6ec2ff35a4b8cfcda02abe97fa59
Gerrit-Change-Number: 12330
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: osmith

Change in osmo-msc[master]: Use proper type for tch_rtp_connect() parameter

2018-12-18 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/12330 )

Change subject: Use proper type for tch_rtp_connect() parameter
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12330
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e2efcd2e25d6ec2ff35a4b8cfcda02abe97fa59
Gerrit-Change-Number: 12330
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 18 Dec 2018 17:12:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: Use proper type for tch_rtp_connect() parameter

2018-12-18 Thread Stefan Sperling 
Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12330 )

Change subject: Use proper type for tch_rtp_connect() parameter
..


Patch Set 2: Code-Review+1

Yeah ok.


--
To view, visit https://gerrit.osmocom.org/12330
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e2efcd2e25d6ec2ff35a4b8cfcda02abe97fa59
Gerrit-Change-Number: 12330
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 18 Dec 2018 15:27:53 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: Use proper type for tch_rtp_connect() parameter

2018-12-17 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12330 )

Change subject: Use proper type for tch_rtp_connect() parameter
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12330
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e2efcd2e25d6ec2ff35a4b8cfcda02abe97fa59
Gerrit-Change-Number: 12330
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Mon, 17 Dec 2018 13:13:08 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: Use proper type for tch_rtp_connect() parameter

2018-12-17 Thread Max 
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12330


Change subject: Use proper type for tch_rtp_connect() parameter
..

Use proper type for tch_rtp_connect() parameter

Change-Id: I6e2efcd2e25d6ec2ff35a4b8cfcda02abe97fa59
---
M src/libmsc/gsm_04_08_cc.c
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/30/12330/1

diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c
index a172b47..3fe427e 100644
--- a/src/libmsc/gsm_04_08_cc.c
+++ b/src/libmsc/gsm_04_08_cc.c
@@ -1761,10 +1761,9 @@
return 0;
 }

-static int tch_rtp_connect(struct gsm_network *net, void *arg)
+static int tch_rtp_connect(struct gsm_network *net, struct gsm_mncc_rtp *rtp)
 {
struct gsm_trans *trans;
-   struct gsm_mncc_rtp *rtp = arg;
struct in_addr addr;

/* FIXME: in *rtp we should get the codec information of the remote

--
To view, visit https://gerrit.osmocom.org/12330
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e2efcd2e25d6ec2ff35a4b8cfcda02abe97fa59
Gerrit-Change-Number: 12330
Gerrit-PatchSet: 1
Gerrit-Owner: Max