Change in osmo-msc[master]: VLR: drop unused struct members
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12335 )
Change subject: VLR: drop unused struct members
..
VLR: drop unused struct members
Change-Id: I322072653b41cf250aa2c1e346e00bae884feb84
---
M include/osmocom/msc/vlr.h
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Max: Looks good to me, approved
Pau Espin Pedrol: Looks good to me, but someone else must approve
Stefan Sperling: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/include/osmocom/msc/vlr.h b/include/osmocom/msc/vlr.h
index 68e0759..2f31063 100644
--- a/include/osmocom/msc/vlr.h
+++ b/include/osmocom/msc/vlr.h
@@ -171,9 +171,6 @@
/* PS (SGSN) specific parts */
struct {
struct llist_head pdp_list;
- uint8_t rac;
- uint8_t sac;
- struct gprs_mm_ctx *mmctx;
} ps;
/* CS (NITB/CSCN) specific parts */
struct {
--
To view, visit https://gerrit.osmocom.org/12335
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I322072653b41cf250aa2c1e346e00bae884feb84
Gerrit-Change-Number: 12335
Gerrit-PatchSet: 4
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: Stefan Sperling
Change in osmo-msc[master]: VLR: drop unused struct members
Max has posted comments on this change. ( https://gerrit.osmocom.org/12335 ) Change subject: VLR: drop unused struct members .. Patch Set 3: Code-Review+2 Since there're 2 votes for it already, let's merge this and nuke entire thing in a separate commit if possible/necessary. -- To view, visit https://gerrit.osmocom.org/12335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I322072653b41cf250aa2c1e346e00bae884feb84 Gerrit-Change-Number: 12335 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Comment-Date: Tue, 18 Dec 2018 17:57:25 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-msc[master]: VLR: drop unused struct members
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12335 ) Change subject: VLR: drop unused struct members .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I322072653b41cf250aa2c1e346e00bae884feb84 Gerrit-Change-Number: 12335 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Comment-Date: Tue, 18 Dec 2018 17:17:19 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-msc[master]: VLR: drop unused struct members
Max has posted comments on this change. ( https://gerrit.osmocom.org/12335 ) Change subject: VLR: drop unused struct members .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12335/3/include/osmocom/msc/vlr.h File include/osmocom/msc/vlr.h: https://gerrit.osmocom.org/#/c/12335/3/include/osmocom/msc/vlr.h@174 PS3, Line 174: } ps; > Any reason we keep 'ps' around if there's only one list left as a struct > member? See my earlier comment on this patch. -- To view, visit https://gerrit.osmocom.org/12335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I322072653b41cf250aa2c1e346e00bae884feb84 Gerrit-Change-Number: 12335 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Comment-Date: Tue, 18 Dec 2018 15:31:12 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-msc[master]: VLR: drop unused struct members
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12335 ) Change subject: VLR: drop unused struct members .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12335/3/include/osmocom/msc/vlr.h File include/osmocom/msc/vlr.h: https://gerrit.osmocom.org/#/c/12335/3/include/osmocom/msc/vlr.h@174 PS3, Line 174: } ps; Any reason we keep 'ps' around if there's only one list left as a struct member? -- To view, visit https://gerrit.osmocom.org/12335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I322072653b41cf250aa2c1e346e00bae884feb84 Gerrit-Change-Number: 12335 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Comment-Date: Tue, 18 Dec 2018 15:29:07 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-msc[master]: VLR: drop unused struct members
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12335 ) Change subject: VLR: drop unused struct members .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I322072653b41cf250aa2c1e346e00bae884feb84 Gerrit-Change-Number: 12335 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Comment-Date: Tue, 18 Dec 2018 14:31:59 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-msc[master]: VLR: drop unused struct members
Hello Stefan Sperling, Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12335 to look at the new patch set (#2). Change subject: VLR: drop unused struct members .. VLR: drop unused struct members Change-Id: I322072653b41cf250aa2c1e346e00bae884feb84 --- M include/osmocom/msc/vlr.h 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/35/12335/2 -- To view, visit https://gerrit.osmocom.org/12335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I322072653b41cf250aa2c1e346e00bae884feb84 Gerrit-Change-Number: 12335 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling
