Change in osmo-msc[master]: charts: add full MO and MT voice call diagram

2019-11-04 Thread laforge
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15945 )

Change subject: charts: add full MO and MT voice call diagram
..

charts: add full MO and MT voice call diagram

Add voice_call_full.msc, generated from a real 2G<->3G voice call log fed to
msc_log_to_ladder.py.

The idea is to document how the voice call sequence of events changes in
upcoming patches.

Change-Id: I8a907d6a4ece1f3ad78da75a8c3e3e76afd5418d
---
M doc/sequence_charts/Makefile.am
A doc/sequence_charts/voice_call_full.msc
2 files changed, 126 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/doc/sequence_charts/Makefile.am b/doc/sequence_charts/Makefile.am
index f1775c8..6782f44 100644
--- a/doc/sequence_charts/Makefile.am
+++ b/doc/sequence_charts/Makefile.am
@@ -13,18 +13,20 @@
inter_bsc_ho.png \
inter_msc_ho.png \
mncc_call_fsm.png \
+   voice_call_full.png \
$(NULL)

 msc: \
$(builddir)/mncc_call_fsm.png \
$(builddir)/inter_bsc_ho.png \
$(builddir)/inter_msc_ho.png \
+   $(builddir)/voice_call_full.png \
$(NULL)

 dot: \
$(NULL)

-$(builddir)/%.png: $(srcdir)/%.msc
+$(builddir)/%.png: %.msc
mscgen -T png -o $@ $<

 $(builddir)/%.png: $(srcdir)/%.dot
diff --git a/doc/sequence_charts/voice_call_full.msc 
b/doc/sequence_charts/voice_call_full.msc
new file mode 100644
index 000..75fcef2
--- /dev/null
+++ b/doc/sequence_charts/voice_call_full.msc
@@ -0,0 +1,123 @@
+# Generated by msc_log_to_ladder.py
+msc {
+hscale="3";
+moms[label="MS,BSS (MO)\nUE,hNodeB (MO)"],momgw[label="MGW for MSC 
(MO)"],momsc[label="MSC (MO)"],sip[label="MNCC to PBX 
via\nosmo-sip-connector"],mtmsc[label="MSC (MT)"],mtmgw[label="MGW for MSC 
(MT)"],mtms[label="BSS,MS (MT)\nhNodeB,UE (MT)"];
+moms =>> momsc [label="MM CM_SERV_REQ"];
+moms <<= momsc [label="MM AUTH_REQ"];
+moms =>> momsc [label="MM AUTH_RESP"];
+moms <<= momsc [label="(BSSMAP) CIPHER_MODE_COMMAND"];
+moms =>> momsc [label="(BSSMAP) Ciphering Mode Complete"];
+moms =>> momsc [label="RR CIPH_M_COMPL"];
+moms =>> momsc [label="CC SETUP"];
+momsc note momsc   [label="CC starts guard timer (180s)"];
+momsc abox momsc   [label="CC state:\nINITIATED"];
+momsc =>> sip  [label="MNCC_SETUP_IND"];
+momsc <<= sip  [label="MNCC_RTP_CREATE"];
+momgw <<= momsc[label="for RAN: CRCX\nrtpbridge/*@msc"];
+momgw =>> momsc[label="for RAN: CRCX OK\nEP-1 CI-1"];
+moms <<= momsc [label="(BSSMAP) ASSIGNMENT_COMMAND"];
+moms =>> momsc [label="(BSSMAP) Assignment Complete"];
+momgw <<= momsc[label="for RAN: MDCX\nEP-1 CI-1"];
+momgw =>> momsc[label="for RAN: MDCX OK\nEP-1 CI-1"];
+momgw <<= momsc[label="for CN: CRCX\nEP-1"];
+momgw =>> momsc[label="for CN: CRCX OK\nEP-1 CI-2"];
+momsc =>> sip  [label="MNCC_RTP_CREATE\nIP:port-1"];
+momsc <<= sip  [label="MNCC_CALL_PROC_REQ"];
+momsc note momsc   [label="CC stops guard timer"];
+momsc note momsc   [label="CC starts guard timer (180s)"];
+momsc abox momsc   [label="CC state:\nMO_CALL_PROC"];
+moms <<= momsc [label="CC CALL_PROC"];
+mtmsc <<= sip  [label="MNCC_SETUP_REQ"];
+mtms <<= mtmsc [label="Paging"];
+mtms =>> mtmsc [label="RR PAG_RESP"];
+mtms <<= mtmsc [label="MM AUTH_REQ"];
+mtms =>> mtmsc [label="MM NULL"];
+mtms =>> mtmsc [label="MM AUTH_RESP"];
+mtms <<= mtmsc [label="(RANAP) SecurityModeCommand"];
+mtms =>> mtmsc [label="(RANAP) SecurityModeControl successfulOutcome"];
+mtms <<= mtmsc [label="(RANAP) CommonId"];
+mtmsc note mtmsc   [label="CC starts timer T303 (30s)"];
+mtmsc abox mtmsc   [label="CC state:\nCALL_PRESENT"];
+mtms <<= mtmsc [label="CC SETUP"];
+mtms =>> mtmsc [label="CC CALL_CONF"];
+mtmsc note mtmsc   [label="CC stops timer T303"];
+mtmsc note mtmsc   [label="CC starts timer T310 (30s)"];
+mtmsc abox mtmsc   [label="CC state:\nMO_TERM_CALL_CONF"];
+mtmgw <<= mtmsc[label="for RAN: CRCX\nrtpbridge/*@msc"];
+mtmsc =>> sip  [label="MNCC_CALL_CONF_IND"];
+mtmsc <<= sip  [label="MNCC_RTP_CREATE"];
+mtmgw =>> mtmsc[label="for RAN: CRCX OK\nEP-2 CI-3"];
+mtms <<= mtmsc [label="(RANAP) RAB AssignmentRequest"];
+mtms =>> mtmsc [label="(RANAP) RAB Assignment Response"];
+mtmgw <<= mtmsc[label="for RAN: MDCX\nEP-2 CI-3"];
+mtmgw =>> mtmsc[label="for RAN: MDCX OK\nEP-2 CI-3"];
+mtmgw <<= mtmsc[label="for CN: CRCX\nEP-2"];
+mtmgw =>> mtmsc[label="for CN: CRCX OK\nEP-2 CI-4"];
+mtmsc =>> sip  [label="MNCC_RTP_CREATE\nIP:port-2"];
+mtms =>> mtmsc [label="CC ALERTING"];
+mtmsc note mtmsc   [label="CC stops timer T310"];
+mtmsc note mtmsc   [label="CC starts timer T301 (180s)"];
+mtmsc abox mtmsc   [label="CC state:\nCALL_RECEIVED"];
+mtmsc =>> sip  [label="MNCC_ALERT_IND"];
+momsc <<= sip  

Change in osmo-msc[master]: charts: add full MO and MT voice call diagram

2019-11-04 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15945 )

Change subject: charts: add full MO and MT voice call diagram
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15945
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8a907d6a4ece1f3ad78da75a8c3e3e76afd5418d
Gerrit-Change-Number: 15945
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 04 Nov 2019 10:12:47 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-msc[master]: charts: add full MO and MT voice call diagram

2019-11-04 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15945 )

Change subject: charts: add full MO and MT voice call diagram
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15945
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8a907d6a4ece1f3ad78da75a8c3e3e76afd5418d
Gerrit-Change-Number: 15945
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 04 Nov 2019 10:12:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-msc[master]: charts: add full MO and MT voice call diagram

2019-11-03 Thread neels
neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15945 )


Change subject: charts: add full MO and MT voice call diagram
..

charts: add full MO and MT voice call diagram

Add voice_call_full.msc, generated from a real 2G<->3G voice call log fed to
msc_log_to_ladder.py.

The idea is to document how the voice call sequence of events changes in
upcoming patches.

Change-Id: I8a907d6a4ece1f3ad78da75a8c3e3e76afd5418d
---
M doc/sequence_charts/Makefile.am
A doc/sequence_charts/voice_call_full.msc
2 files changed, 126 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/45/15945/1

diff --git a/doc/sequence_charts/Makefile.am b/doc/sequence_charts/Makefile.am
index f1775c8..6782f44 100644
--- a/doc/sequence_charts/Makefile.am
+++ b/doc/sequence_charts/Makefile.am
@@ -13,18 +13,20 @@
inter_bsc_ho.png \
inter_msc_ho.png \
mncc_call_fsm.png \
+   voice_call_full.png \
$(NULL)

 msc: \
$(builddir)/mncc_call_fsm.png \
$(builddir)/inter_bsc_ho.png \
$(builddir)/inter_msc_ho.png \
+   $(builddir)/voice_call_full.png \
$(NULL)

 dot: \
$(NULL)

-$(builddir)/%.png: $(srcdir)/%.msc
+$(builddir)/%.png: %.msc
mscgen -T png -o $@ $<

 $(builddir)/%.png: $(srcdir)/%.dot
diff --git a/doc/sequence_charts/voice_call_full.msc 
b/doc/sequence_charts/voice_call_full.msc
new file mode 100644
index 000..75fcef2
--- /dev/null
+++ b/doc/sequence_charts/voice_call_full.msc
@@ -0,0 +1,123 @@
+# Generated by msc_log_to_ladder.py
+msc {
+hscale="3";
+moms[label="MS,BSS (MO)\nUE,hNodeB (MO)"],momgw[label="MGW for MSC 
(MO)"],momsc[label="MSC (MO)"],sip[label="MNCC to PBX 
via\nosmo-sip-connector"],mtmsc[label="MSC (MT)"],mtmgw[label="MGW for MSC 
(MT)"],mtms[label="BSS,MS (MT)\nhNodeB,UE (MT)"];
+moms =>> momsc [label="MM CM_SERV_REQ"];
+moms <<= momsc [label="MM AUTH_REQ"];
+moms =>> momsc [label="MM AUTH_RESP"];
+moms <<= momsc [label="(BSSMAP) CIPHER_MODE_COMMAND"];
+moms =>> momsc [label="(BSSMAP) Ciphering Mode Complete"];
+moms =>> momsc [label="RR CIPH_M_COMPL"];
+moms =>> momsc [label="CC SETUP"];
+momsc note momsc   [label="CC starts guard timer (180s)"];
+momsc abox momsc   [label="CC state:\nINITIATED"];
+momsc =>> sip  [label="MNCC_SETUP_IND"];
+momsc <<= sip  [label="MNCC_RTP_CREATE"];
+momgw <<= momsc[label="for RAN: CRCX\nrtpbridge/*@msc"];
+momgw =>> momsc[label="for RAN: CRCX OK\nEP-1 CI-1"];
+moms <<= momsc [label="(BSSMAP) ASSIGNMENT_COMMAND"];
+moms =>> momsc [label="(BSSMAP) Assignment Complete"];
+momgw <<= momsc[label="for RAN: MDCX\nEP-1 CI-1"];
+momgw =>> momsc[label="for RAN: MDCX OK\nEP-1 CI-1"];
+momgw <<= momsc[label="for CN: CRCX\nEP-1"];
+momgw =>> momsc[label="for CN: CRCX OK\nEP-1 CI-2"];
+momsc =>> sip  [label="MNCC_RTP_CREATE\nIP:port-1"];
+momsc <<= sip  [label="MNCC_CALL_PROC_REQ"];
+momsc note momsc   [label="CC stops guard timer"];
+momsc note momsc   [label="CC starts guard timer (180s)"];
+momsc abox momsc   [label="CC state:\nMO_CALL_PROC"];
+moms <<= momsc [label="CC CALL_PROC"];
+mtmsc <<= sip  [label="MNCC_SETUP_REQ"];
+mtms <<= mtmsc [label="Paging"];
+mtms =>> mtmsc [label="RR PAG_RESP"];
+mtms <<= mtmsc [label="MM AUTH_REQ"];
+mtms =>> mtmsc [label="MM NULL"];
+mtms =>> mtmsc [label="MM AUTH_RESP"];
+mtms <<= mtmsc [label="(RANAP) SecurityModeCommand"];
+mtms =>> mtmsc [label="(RANAP) SecurityModeControl successfulOutcome"];
+mtms <<= mtmsc [label="(RANAP) CommonId"];
+mtmsc note mtmsc   [label="CC starts timer T303 (30s)"];
+mtmsc abox mtmsc   [label="CC state:\nCALL_PRESENT"];
+mtms <<= mtmsc [label="CC SETUP"];
+mtms =>> mtmsc [label="CC CALL_CONF"];
+mtmsc note mtmsc   [label="CC stops timer T303"];
+mtmsc note mtmsc   [label="CC starts timer T310 (30s)"];
+mtmsc abox mtmsc   [label="CC state:\nMO_TERM_CALL_CONF"];
+mtmgw <<= mtmsc[label="for RAN: CRCX\nrtpbridge/*@msc"];
+mtmsc =>> sip  [label="MNCC_CALL_CONF_IND"];
+mtmsc <<= sip  [label="MNCC_RTP_CREATE"];
+mtmgw =>> mtmsc[label="for RAN: CRCX OK\nEP-2 CI-3"];
+mtms <<= mtmsc [label="(RANAP) RAB AssignmentRequest"];
+mtms =>> mtmsc [label="(RANAP) RAB Assignment Response"];
+mtmgw <<= mtmsc[label="for RAN: MDCX\nEP-2 CI-3"];
+mtmgw =>> mtmsc[label="for RAN: MDCX OK\nEP-2 CI-3"];
+mtmgw <<= mtmsc[label="for CN: CRCX\nEP-2"];
+mtmgw =>> mtmsc[label="for CN: CRCX OK\nEP-2 CI-4"];
+mtmsc =>> sip  [label="MNCC_RTP_CREATE\nIP:port-2"];
+mtms =>> mtmsc [label="CC ALERTING"];
+mtmsc note mtmsc   [label="CC stops timer T310"];
+mtmsc note mtmsc   [label="CC starts timer T301 (180s)"];
+mtmsc abox mtmsc   [label="CC state:\nCALL_RECEIVED"];
+mtmsc =>> sip  [label="MNCC_ALERT_IND"];
+momsc <<= sip  [label="MNCC_ALERT_REQ"];
+momsc note momsc   [label="CC stops