Change in osmo-msc[master]: msc_vty: display current RAN type

2018-12-19 Thread dexter 
dexter has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12345 )

Change subject: msc_vty: display current RAN type
..

msc_vty: display current RAN type

When a subscriber is displayed the RAN type is not included in the
overview. Meanwhile the MSC supports multiple different ran types it
becomes important to see in which RAN the subscriber is currently
active.

Change-Id: I000cafd5e41b9951d51b6bd6672ee68a224b8212
Related: OS#3615
---
M src/libmsc/msc_vty.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved
  Stefan Sperling: Looks good to me, but someone else must approve
  Vadim Yanitskiy: Looks good to me, but someone else must approve



diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index b39775f..5622c02 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -632,6 +632,8 @@
VTY_NEWLINE);
vty_out(vty, "LAC: %d/0x%x%s",
vsub->lac, vsub->lac, VTY_NEWLINE);
+   vty_out(vty, "RAN: %s%s",
+   ran_type_name(vsub->cs.attached_via_ran), VTY_NEWLINE);
vty_out(vty, "IMSI: %s%s", vsub->imsi, VTY_NEWLINE);
if (vsub->tmsi != GSM_RESERVED_TMSI)
vty_out(vty, "TMSI: %08X%s", vsub->tmsi,

--
To view, visit https://gerrit.osmocom.org/12345
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I000cafd5e41b9951d51b6bd6672ee68a224b8212
Gerrit-Change-Number: 12345
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: dexter

Change in osmo-msc[master]: msc_vty: display current RAN type

2018-12-18 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12345 )

Change subject: msc_vty: display current RAN type
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12345
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000cafd5e41b9951d51b6bd6672ee68a224b8212
Gerrit-Change-Number: 12345
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 18 Dec 2018 21:44:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: msc_vty: display current RAN type

2018-12-18 Thread Stefan Sperling 
Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12345 )

Change subject: msc_vty: display current RAN type
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12345
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000cafd5e41b9951d51b6bd6672ee68a224b8212
Gerrit-Change-Number: 12345
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Tue, 18 Dec 2018 17:33:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: msc_vty: display current RAN type

2018-12-18 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12345 )

Change subject: msc_vty: display current RAN type
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12345
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I000cafd5e41b9951d51b6bd6672ee68a224b8212
Gerrit-Change-Number: 12345
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 18 Dec 2018 11:18:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: msc_vty: display current RAN type

2018-12-18 Thread dexter 
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12345


Change subject: msc_vty: display current RAN type
..

msc_vty: display current RAN type

When a subscriber is displayed the RAN type is not included in the
overview. Meanwhile the MSC supports multiple different ran types it
becomes important to see in which RAN the subscriber is currently
active.

Change-Id: I000cafd5e41b9951d51b6bd6672ee68a224b8212
Related: OS#3615
---
M src/libmsc/msc_vty.c
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/45/12345/1

diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index 7e30165..4cd1c18 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -632,6 +632,8 @@
VTY_NEWLINE);
vty_out(vty, "LAC: %d/0x%x%s",
vsub->lac, vsub->lac, VTY_NEWLINE);
+   vty_out(vty, "RAN: %s%s",
+   ran_type_name(vsub->cs.attached_via_ran), VTY_NEWLINE);
vty_out(vty, "IMSI: %s%s", vsub->imsi, VTY_NEWLINE);
if (vsub->tmsi != GSM_RESERVED_TMSI)
vty_out(vty, "TMSI: %08X%s", vsub->tmsi,

--
To view, visit https://gerrit.osmocom.org/12345
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I000cafd5e41b9951d51b6bd6672ee68a224b8212
Gerrit-Change-Number: 12345
Gerrit-PatchSet: 1
Gerrit-Owner: dexter