Change in osmo-msc[master]: msc_vty: display subscriber flags

2018-12-19 Thread dexter 
dexter has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12344 )

Change subject: msc_vty: display subscriber flags
..

msc_vty: display subscriber flags

When a VLR subscriber is displayed on the VTY we get a lot of meta
information, but there are also some flags to handle the internal
subscriber status e.g. conf_by_radio_contact_ind. Lets display those
flags as well as this information can be very helpful when debugging
problems in the VLR

Change-Id: I59a9145a4daad50d68de3fd5c3291f027256917f
---
M src/libmsc/msc_vty.c
1 file changed, 19 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index 4e71e26..b39775f 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -640,6 +640,25 @@
vty_out(vty, "new TMSI: %08X%s", vsub->tmsi_new,
VTY_NEWLINE);

+   vty_out(vty, "Flags: %s", VTY_NEWLINE);
+   vty_out(vty, " IMSI detached: %s%s",
+   vsub->imsi_detached_flag ? "true" : "false", VTY_NEWLINE);
+   vty_out(vty, " Conf. by radio contact:%s%s",
+   vsub->conf_by_radio_contact_ind ? "true" : "false",
+   VTY_NEWLINE);
+   vty_out(vty, " Subscr. data conf. by HLR: %s%s",
+   vsub->sub_dataconf_by_hlr_ind ? "true" : "false", VTY_NEWLINE);
+   vty_out(vty, " Location conf. in HLR: %s%s",
+   vsub->loc_conf_in_hlr_ind ? "true" : "false", VTY_NEWLINE);
+   vty_out(vty, " Subscriber dormant:%s%s",
+   vsub->dormant_ind ? "true" : "false", VTY_NEWLINE);
+   vty_out(vty, " Received cancel locataion: %s%s",
+   vsub->cancel_loc_rx ? "true" : "false", VTY_NEWLINE);
+   vty_out(vty, " MS not reachable:  %s%s",
+   vsub->ms_not_reachable_flag ? "true" : "false", VTY_NEWLINE);
+   vty_out(vty, " LA allowed:%s%s",
+   vsub->la_allowed ? "true" : "false", VTY_NEWLINE);
+
 #if 0
/* TODO: add this to vlr_subscr? */
if (vsub->auth_info.auth_algo != AUTH_ALGO_NONE) {

--
To view, visit https://gerrit.osmocom.org/12344
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I59a9145a4daad50d68de3fd5c3291f027256917f
Gerrit-Change-Number: 12344
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: dexter

Change in osmo-msc[master]: msc_vty: display subscriber flags

2018-12-18 Thread Stefan Sperling 
Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12344 )

Change subject: msc_vty: display subscriber flags
..


Patch Set 2: -Code-Review


--
To view, visit https://gerrit.osmocom.org/12344
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59a9145a4daad50d68de3fd5c3291f027256917f
Gerrit-Change-Number: 12344
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Tue, 18 Dec 2018 17:31:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: msc_vty: display subscriber flags

2018-12-18 Thread Stefan Sperling 
Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12344 )

Change subject: msc_vty: display subscriber flags
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/12344/2/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/12344/2/src/libmsc/msc_vty.c@659
PS2, Line 659:  vty_out(vty, " Received cancel locataion: %s%s",
typo: "location"



--
To view, visit https://gerrit.osmocom.org/12344
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59a9145a4daad50d68de3fd5c3291f027256917f
Gerrit-Change-Number: 12344
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Tue, 18 Dec 2018 17:31:27 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: msc_vty: display subscriber flags

2018-12-18 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12344 )

Change subject: msc_vty: display subscriber flags
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12344
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59a9145a4daad50d68de3fd5c3291f027256917f
Gerrit-Change-Number: 12344
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 18 Dec 2018 13:36:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: msc_vty: display subscriber flags

2018-12-18 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12344 )

Change subject: msc_vty: display subscriber flags
..


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/12344/2/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/12344/2/src/libmsc/msc_vty.c@652
PS2, Line 652:  VTY_NEWLINE);
Can you put this one in same line with true and false?



--
To view, visit https://gerrit.osmocom.org/12344
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59a9145a4daad50d68de3fd5c3291f027256917f
Gerrit-Change-Number: 12344
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 18 Dec 2018 11:20:07 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: msc_vty: display subscriber flags

2018-12-18 Thread dexter 
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12344


Change subject: msc_vty: display subscriber flags
..

msc_vty: display subscriber flags

When a VLR subscriber is displayed on the VTY we get a lot of meta
information, but there are also some flags to handle the internal
subscriber status e.g. conf_by_radio_contact_ind. Lets display those
flags as well as this information can be very helpful when debugging
problems in the VLR

Change-Id: I59a9145a4daad50d68de3fd5c3291f027256917f
---
M src/libmsc/msc_vty.c
1 file changed, 19 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/44/12344/1

diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index adcf1b1..7e30165 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -644,6 +644,25 @@
if (strlen(vsub->imeisv))
vty_out(vty, "IMEISV: %s%s", vsub->imeisv, VTY_NEWLINE);

+   vty_out(vty, "Flags: %s", VTY_NEWLINE);
+   vty_out(vty, " IMSI detached: %s%s",
+   vsub->imsi_detached_flag ? "true" : "false", VTY_NEWLINE);
+   vty_out(vty, " Conf. by radio contact:%s%s",
+   vsub->conf_by_radio_contact_ind ? "true" : "false",
+   VTY_NEWLINE);
+   vty_out(vty, " Subscr. data conf. by HLR: %s%s",
+   vsub->sub_dataconf_by_hlr_ind ? "true" : "false", VTY_NEWLINE);
+   vty_out(vty, " Location conf. in HLR: %s%s",
+   vsub->loc_conf_in_hlr_ind ? "true" : "false", VTY_NEWLINE);
+   vty_out(vty, " Subscriber dormant:%s%s",
+   vsub->dormant_ind ? "true" : "false", VTY_NEWLINE);
+   vty_out(vty, " Received cancel locataion: %s%s",
+   vsub->cancel_loc_rx ? "true" : "false", VTY_NEWLINE);
+   vty_out(vty, " MS not reachable:  %s%s",
+   vsub->ms_not_reachable_flag ? "true" : "false", VTY_NEWLINE);
+   vty_out(vty, " LA allowed:%s%s",
+   vsub->la_allowed ? "true" : "false", VTY_NEWLINE);
+
 #if 0
/* TODO: add this to vlr_subscr? */
if (vsub->auth_info.auth_algo != AUTH_ALGO_NONE) {

--
To view, visit https://gerrit.osmocom.org/12344
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59a9145a4daad50d68de3fd5c3291f027256917f
Gerrit-Change-Number: 12344
Gerrit-PatchSet: 1
Gerrit-Owner: dexter