Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-17 Thread Neels Hofmeyr 
Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12236 )

Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..

vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

There is no state transition from INIT to WAIT_IMEI, only to WAIT_SUB_PRES.

If there were code to skip WAIT_SUB_PRES, the allowed state transitions would
have to be the same as for WAIT_SUB_PRES, i.e. also WAIT_IMEI_TMSI and
WAIT_TMSI_CNF. For now just opt for the status quo.

Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
---
M src/libvlr/vlr_lu_fsm.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Stefan Sperling: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c
index a0cbcab..5d171d5 100644
--- a/src/libvlr/vlr_lu_fsm.c
+++ b/src/libvlr/vlr_lu_fsm.c
@@ -555,8 +555,7 @@
[LU_COMPL_VLR_S_INIT] = {
.in_event_mask = S(LU_COMPL_VLR_E_START),
.out_state_mask = S(LU_COMPL_VLR_S_DONE) |
- S(LU_COMPL_VLR_S_WAIT_SUB_PRES) |
- S(LU_COMPL_VLR_S_WAIT_IMEI),
+ S(LU_COMPL_VLR_S_WAIT_SUB_PRES),
.name = OSMO_STRINGIFY(LU_COMPL_VLR_S_INIT),
.action = lu_compl_vlr_init,
},

--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-CC: Max

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-17 Thread Stefan Sperling 
Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12236 )

Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-CC: Max 
Gerrit-Comment-Date: Mon, 17 Dec 2018 11:51:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-14 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/12236 )

Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..


Patch Set 2:

Do you need to update some .adoc or .msc as well or this isn't documented?


--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-CC: Max 
Gerrit-Comment-Date: Fri, 14 Dec 2018 12:54:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-12 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12236 )

Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12236/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12236/1//COMMIT_MSG@12
PS1, Line 12: have to be the same as for WAIT_SUB_PRES, i.e. also 
WAIT_IMEI_TMSI and
> Don't you mean WAIT_IMEI_TMSI (IMEI, not IEMI)? :-P
now you're confusing me! There is no IEMI, is there?? if you carry on I will 
write WAUT_UNEU_UNSU



--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 11:37:10 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-12 Thread Neels Hofmeyr 
Neels Hofmeyr has removed a vote on this change.

Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..


Removed Code-Review+1 by Neels Hofmeyr 
--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-12 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12236 )

Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..


Patch Set 2: Code-Review+1

trying out whether we have +3 now...


--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 12 Dec 2018 11:34:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-11 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12236 )

Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Tue, 11 Dec 2018 11:54:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-11 Thread Neels Hofmeyr 
Hello Stefan Sperling, Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12236

to look at the new patch set (#2).

Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..

vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

There is no state transition from INIT to WAIT_IMEI, only to WAIT_SUB_PRES.

If there were code to skip WAIT_SUB_PRES, the allowed state transitions would
have to be the same as for WAIT_SUB_PRES, i.e. also WAIT_IMEI_TMSI and
WAIT_TMSI_CNF. For now just opt for the status quo.

Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
---
M src/libvlr/vlr_lu_fsm.c
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/36/12236/2
--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-11 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12236 )

Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Tue, 11 Dec 2018 11:41:03 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-11 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12236 )

Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12236/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12236/1//COMMIT_MSG@12
PS1, Line 12: have to be the same as for WAIT_SUB_PRES, i.e. also 
WAIT_IMEI_IMSI and
> Don't you mean WAIT_IEMI_TMSI (TMSI, not IMSI)?
Don't you mean WAIT_IMEI_TMSI (IMEI, not IEMI)? :-P



--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 11 Dec 2018 11:40:39 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-11 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12236 )

Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12236/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12236/1//COMMIT_MSG@12
PS1, Line 12: have to be the same as for WAIT_SUB_PRES, i.e. also 
WAIT_IMEI_IMSI and
> Don't you mean WAIT_IEMI_TMSI (TMSI, not IMSI)?
gah, that's what happens if you once decide to type instead of ctrl-p



--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Tue, 11 Dec 2018 11:39:26 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-11 Thread Stefan Sperling 
Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12236 )

Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/12236/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12236/1//COMMIT_MSG@12
PS1, Line 12: have to be the same as for WAIT_SUB_PRES, i.e. also 
WAIT_IMEI_IMSI and
Don't you mean WAIT_IEMI_TMSI (TMSI, not IMSI)?



--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Tue, 11 Dec 2018 09:48:03 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

2018-12-10 Thread Neels Hofmeyr 
Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12236


Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..

vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI

There is no state transition from INIT to WAIT_IMEI, only to WAIT_SUB_PRES.

If there were code to skip WAIT_SUB_PRES, the allowed state transitions would
have to be the same as for WAIT_SUB_PRES, i.e. also WAIT_IMEI_IMSI and
WAIT_TMSI_CNF. For now just opt for the status quo.

Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
---
M src/libvlr/vlr_lu_fsm.c
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/36/12236/1

diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c
index a0cbcab..5d171d5 100644
--- a/src/libvlr/vlr_lu_fsm.c
+++ b/src/libvlr/vlr_lu_fsm.c
@@ -555,8 +555,7 @@
[LU_COMPL_VLR_S_INIT] = {
.in_event_mask = S(LU_COMPL_VLR_E_START),
.out_state_mask = S(LU_COMPL_VLR_S_DONE) |
- S(LU_COMPL_VLR_S_WAIT_SUB_PRES) |
- S(LU_COMPL_VLR_S_WAIT_IMEI),
+ S(LU_COMPL_VLR_S_WAIT_SUB_PRES),
.name = OSMO_STRINGIFY(LU_COMPL_VLR_S_INIT),
.action = lu_compl_vlr_init,
},

--
To view, visit https://gerrit.osmocom.org/12236
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I18ef9e8c96b52401d98f49dc410f13681231b533
Gerrit-Change-Number: 12236
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr