Change in osmo-pcu[master]: Move tbf ul_ack_state to osmocom FSM
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25108 ) Change subject: Move tbf ul_ack_state to osmocom FSM .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icf23bf5a4b85fbcbf1542cebceb76b9ba7185d30 Gerrit-Change-Number: 25108 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 23 Aug 2021 16:27:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Move tbf ul_ack_state to osmocom FSM
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25108 ) Change subject: Move tbf ul_ack_state to osmocom FSM .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icf23bf5a4b85fbcbf1542cebceb76b9ba7185d30 Gerrit-Change-Number: 25108 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 30 Jul 2021 15:48:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Move tbf ul_ack_state to osmocom FSM
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25108 to look at the new patch set (#5). Change subject: Move tbf ul_ack_state to osmocom FSM .. Move tbf ul_ack_state to osmocom FSM Related: OS#2709 Change-Id: Icf23bf5a4b85fbcbf1542cebceb76b9ba7185d30 --- M src/Makefile.am M src/encoding.cpp M src/encoding.h M src/gprs_rlcmac_sched.cpp M src/pdch.cpp M src/tbf.cpp M src/tbf.h M src/tbf_dl.cpp M src/tbf_ul.cpp M src/tbf_ul.h A src/tbf_ul_ack_fsm.c A src/tbf_ul_ack_fsm.h M tests/tbf/TbfTest.cpp M tests/tbf/TbfTest.err M tests/types/TypesTest.cpp M tests/types/TypesTest.err 16 files changed, 489 insertions(+), 173 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/08/25108/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icf23bf5a4b85fbcbf1542cebceb76b9ba7185d30 Gerrit-Change-Number: 25108 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: Move tbf ul_ack_state to osmocom FSM
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25108 ) Change subject: Move tbf ul_ack_state to osmocom FSM .. Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/gprs_rlcmac_sched.cpp File src/gprs_rlcmac_sched.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/gprs_rlcmac_sched.cpp@176 PS4, Line 176: //msg = tbfs->ul_ack->create_ul_ack(fn, ts); > looks like it's not on purpose? Ack https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/tbf_ul_ack_fsm.c File src/tbf_ul_ack_fsm.c: https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/tbf_ul_ack_fsm.c@253 PS4, Line 253: /* FIXME: validate FN and TS match: && ctx->poll_fn = fn && ctx->poll_ts == ts */ > * indentation […] Yes, it's out of the scope since it was not done beforehand. I'm just adding it here to remember in the future to add this kind of checks in the future (I already do it for instance in NACC FSM). It's easy to do it, but doing so would change the logic or add further restrictions which would show up a bug, and I'm not willing to change behavior in this patchset. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icf23bf5a4b85fbcbf1542cebceb76b9ba7185d30 Gerrit-Change-Number: 25108 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith Gerrit-Comment-Date: Fri, 30 Jul 2021 15:04:01 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment
Change in osmo-pcu[master]: Move tbf ul_ack_state to osmocom FSM
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25108 ) Change subject: Move tbf ul_ack_state to osmocom FSM .. Patch Set 4: (3 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/gprs_rlcmac_sched.cpp File src/gprs_rlcmac_sched.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/gprs_rlcmac_sched.cpp@176 PS4, Line 176: //msg = tbfs->ul_ack->create_ul_ack(fn, ts); looks like it's not on purpose? https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/tbf_ul.h File src/tbf_ul.h: https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/tbf_ul.h@a58 PS4, Line 58: bool ctrl_ack_to_toggle(); can be deleted https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/tbf_ul_ack_fsm.c File src/tbf_ul_ack_fsm.c: https://gerrit.osmocom.org/c/osmo-pcu/+/25108/4/src/tbf_ul_ack_fsm.c@253 PS4, Line 253: /* FIXME: validate FN and TS match: && ctx->poll_fn = fn && ctx->poll_ts == ts */ * indentation * is this out of scope for the patch? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icf23bf5a4b85fbcbf1542cebceb76b9ba7185d30 Gerrit-Change-Number: 25108 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith Gerrit-Comment-Date: Fri, 30 Jul 2021 14:02:57 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-pcu[master]: Move tbf ul_ack_state to osmocom FSM
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25108 to look at the new patch set (#3). Change subject: Move tbf ul_ack_state to osmocom FSM .. Move tbf ul_ack_state to osmocom FSM Related: OS#2709 Change-Id: Icf23bf5a4b85fbcbf1542cebceb76b9ba7185d30 --- M src/Makefile.am M src/encoding.cpp M src/encoding.h M src/gprs_rlcmac_sched.cpp M src/pdch.cpp M src/tbf.cpp M src/tbf.h M src/tbf_dl.cpp M src/tbf_ul.cpp M src/tbf_ul.h A src/tbf_ul_ack_fsm.c A src/tbf_ul_ack_fsm.h M tests/tbf/TbfTest.cpp M tests/tbf/TbfTest.err M tests/types/TypesTest.cpp M tests/types/TypesTest.err 16 files changed, 491 insertions(+), 171 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/08/25108/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icf23bf5a4b85fbcbf1542cebceb76b9ba7185d30 Gerrit-Change-Number: 25108 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: Move tbf ul_ack_state to osmocom FSM
pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/25108 ) Change subject: Move tbf ul_ack_state to osmocom FSM .. Move tbf ul_ack_state to osmocom FSM Related: OS#2709 Change-Id: Icf23bf5a4b85fbcbf1542cebceb76b9ba7185d30 --- M src/Makefile.am M src/encoding.cpp M src/encoding.h M src/gprs_rlcmac_sched.cpp M src/pdch.cpp M src/tbf.cpp M src/tbf.h M src/tbf_dl.cpp M src/tbf_ul.cpp M src/tbf_ul.h A src/tbf_ul_ack_fsm.c A src/tbf_ul_ack_fsm.h M tests/tbf/TbfTest.cpp M tests/tbf/TbfTest.err M tests/types/TypesTest.cpp M tests/types/TypesTest.err 16 files changed, 487 insertions(+), 171 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/08/25108/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icf23bf5a4b85fbcbf1542cebceb76b9ba7185d30 Gerrit-Change-Number: 25108 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset
