Change in osmo-pcu[master]: jenkins.sh: use flag --enable-werror for sysmo and none
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9696 ) Change subject: jenkins.sh: use flag --enable-werror for sysmo and none .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9696 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66a43822f8a40764d7d6e09503892cea6030e697 Gerrit-Change-Number: 9696 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Thu, 21 Jun 2018 17:12:56 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: jenkins.sh: use flag --enable-werror for sysmo and none
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9696 ) Change subject: jenkins.sh: use flag --enable-werror for sysmo and none .. jenkins.sh: use flag --enable-werror for sysmo and none The lc15 flavour still contains compilation warnings and thus the flag cannot be enabled while building it. Change-Id: I66a43822f8a40764d7d6e09503892cea6030e697 --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified Vadim Yanitskiy: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 2527127..5f81978 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -26,7 +26,7 @@ # Collect configure options for osmo-pcu PCU_CONFIG="" if [ "$with_dsp" = sysmo ]; then - PCU_CONFIG="$PCU_CONFIG --enable-sysmocom-dsp --with-sysmobts=$inst/include/" + PCU_CONFIG="$PCU_CONFIG --enable-werror --enable-sysmocom-dsp --with-sysmobts=$inst/include/" # For direct sysmo DSP access, provide the SysmoBTS Layer 1 API cd "$deps" @@ -43,7 +43,7 @@ elif [ -z "$with_dsp" -o "$with_dsp" = none ]; then echo "Direct DSP access disabled, sanitizer enabled" - PCU_CONFIG="$PCU_CONFIG --enable-sanitize" + PCU_CONFIG="$PCU_CONFIG --enable-werror --enable-sanitize" else echo 'Invalid $with_dsp value:' $with_dsp exit 1 -- To view, visit https://gerrit.osmocom.org/9696 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I66a43822f8a40764d7d6e09503892cea6030e697 Gerrit-Change-Number: 9696 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy
Change in osmo-pcu[master]: jenkins.sh: use flag --enable-werror for sysmo and none
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9696 ) Change subject: jenkins.sh: use flag --enable-werror for sysmo and none .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/9696 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66a43822f8a40764d7d6e09503892cea6030e697 Gerrit-Change-Number: 9696 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Thu, 21 Jun 2018 13:52:20 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: jenkins.sh: use flag --enable-werror for sysmo and none
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9696 Change subject: jenkins.sh: use flag --enable-werror for sysmo and none .. jenkins.sh: use flag --enable-werror for sysmo and none The lc15 flavour still contains compilation warnings and thus the flag cannot be enabled while building it. Change-Id: I66a43822f8a40764d7d6e09503892cea6030e697 --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/96/9696/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 2527127..5f81978 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -26,7 +26,7 @@ # Collect configure options for osmo-pcu PCU_CONFIG="" if [ "$with_dsp" = sysmo ]; then - PCU_CONFIG="$PCU_CONFIG --enable-sysmocom-dsp --with-sysmobts=$inst/include/" + PCU_CONFIG="$PCU_CONFIG --enable-werror --enable-sysmocom-dsp --with-sysmobts=$inst/include/" # For direct sysmo DSP access, provide the SysmoBTS Layer 1 API cd "$deps" @@ -43,7 +43,7 @@ elif [ -z "$with_dsp" -o "$with_dsp" = none ]; then echo "Direct DSP access disabled, sanitizer enabled" - PCU_CONFIG="$PCU_CONFIG --enable-sanitize" + PCU_CONFIG="$PCU_CONFIG --enable-werror --enable-sanitize" else echo 'Invalid $with_dsp value:' $with_dsp exit 1 -- To view, visit https://gerrit.osmocom.org/9696 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I66a43822f8a40764d7d6e09503892cea6030e697 Gerrit-Change-Number: 9696 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol
