Change in osmo-pcu[master]: pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown gsmtap...

2020-04-30 Thread pespin 
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17982 )

Change subject: pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown 
gsmtap blocks
..

pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown gsmtap blocks

It's actually counter-productive when analyzing wireshark traces, since
one may not spot a decoding issue and assume PACCH is sent on the wrong
TS.

Change-Id: I7a96148f1ca1ebfa88a3ff714ea3bb8798866046
---
M src/pcu_l1_if.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index 37a0705..30d22bd 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -347,7 +347,7 @@

if (rc < 0 && (bts->gsmtap_categ_mask & (1 arfcn | 
GSMTAP_ARFCN_F_UPLINK, data_ind->ts_nr,
-   GSMTAP_CHANNEL_PACCH, 0, data_ind->fn, 0, 0, 
data_ind->data, data_ind->len);
+   GSMTAP_CHANNEL_UNKNOWN, 0, data_ind->fn, 0, 0, 
data_ind->data, data_ind->len);
}

return rc;

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17982
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7a96148f1ca1ebfa88a3ff714ea3bb8798866046
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-pcu[master]: pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown gsmtap...

2020-04-29 Thread fixeria 
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17982 )

Change subject: pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown 
gsmtap blocks
..


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17982/1/src/pcu_l1_if.cpp
File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/17982/1/src/pcu_l1_if.cpp@348
PS1, Line 348: rc < 0
It's not good that we basically depend on rc here. If either 
pcu_rx_data_ind_pdtch() or pcu_rx_data_ind_pdtch() fails for some reason, it 
does not mean that GSMTAP channel type is unknown...



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17982
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7a96148f1ca1ebfa88a3ff714ea3bb8798866046
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Wed, 29 Apr 2020 20:29:02 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown gsmtap...

2020-04-29 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17982 )


Change subject: pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown 
gsmtap blocks
..

pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown gsmtap blocks

It's actually counter-productive when analyzing wireshark traces, since
one may not spot a decoding issue and assume PACCH is sent on the wrong
TS.

Change-Id: I7a96148f1ca1ebfa88a3ff714ea3bb8798866046
---
M src/pcu_l1_if.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/82/17982/1

diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index 37a0705..30d22bd 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -347,7 +347,7 @@

if (rc < 0 && (bts->gsmtap_categ_mask & (1 arfcn | 
GSMTAP_ARFCN_F_UPLINK, data_ind->ts_nr,
-   GSMTAP_CHANNEL_PACCH, 0, data_ind->fn, 0, 0, 
data_ind->data, data_ind->len);
+   GSMTAP_CHANNEL_UNKNOWN, 0, data_ind->fn, 0, 0, 
data_ind->data, data_ind->len);
}

return rc;

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17982
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7a96148f1ca1ebfa88a3ff714ea3bb8798866046
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange