Change in osmo-remsim[master]: bankd: Fix log print during removeMapping
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-remsim/+/16488 )
Change subject: bankd: Fix log print during removeMapping
..
bankd: Fix log print during removeMapping
We need to dereference 'rreq' nor 'creq' in the remove handling.
Change-Id: I04e9e2447336f7d1aaeb932928a79bb705aa0c5a
---
M src/bankd/bankd_main.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c
index 7851a2b..7b50a73 100644
--- a/src/bankd/bankd_main.c
+++ b/src/bankd/bankd_main.c
@@ -190,11 +190,11 @@
rreq = >msg.choice.removeMappingReq;
if (rreq->bank.bankId != g_bankd->srvc.bankd.bank_id) {
LOGPFSML(srvc->fi, LOGL_ERROR, "removeMapping specifies
invalid Bank ID %lu "
-"(we are %u)\n", creq->bank.bankId,
g_bankd->srvc.bankd.bank_id);
+"(we are %u)\n", rreq->bank.bankId,
g_bankd->srvc.bankd.bank_id);
resp =
rspro_gen_RemoveMappingRes(ResultCode_illegalBankId);
} else if (rreq->bank.slotNr >= g_bankd->srvc.bankd.num_slots) {
LOGPFSML(srvc->fi, LOGL_ERROR, "removeMapping specifies
invalid Slot Nr %lu "
-"(we have %u)\n", creq->bank.slotNr,
g_bankd->srvc.bankd.num_slots);
+"(we have %u)\n", rreq->bank.slotNr,
g_bankd->srvc.bankd.num_slots);
resp =
rspro_gen_RemoveMappingRes(ResultCode_illegalSlotId);
} else {
rspro2bank_slot(, >bank);
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/16488
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I04e9e2447336f7d1aaeb932928a79bb705aa0c5a
Gerrit-Change-Number: 16488
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in osmo-remsim[master]: bankd: Fix log print during removeMapping
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/16488 ) Change subject: bankd: Fix log print during removeMapping .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/16488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I04e9e2447336f7d1aaeb932928a79bb705aa0c5a Gerrit-Change-Number: 16488 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 04 Dec 2019 21:11:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-remsim[master]: bankd: Fix log print during removeMapping
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-remsim/+/16488 )
Change subject: bankd: Fix log print during removeMapping
..
bankd: Fix log print during removeMapping
We need to dereference 'rreq' nor 'creq' in the remove handling.
Change-Id: I04e9e2447336f7d1aaeb932928a79bb705aa0c5a
---
M src/bankd/bankd_main.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/88/16488/1
diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c
index 7851a2b..7b50a73 100644
--- a/src/bankd/bankd_main.c
+++ b/src/bankd/bankd_main.c
@@ -190,11 +190,11 @@
rreq = >msg.choice.removeMappingReq;
if (rreq->bank.bankId != g_bankd->srvc.bankd.bank_id) {
LOGPFSML(srvc->fi, LOGL_ERROR, "removeMapping specifies
invalid Bank ID %lu "
-"(we are %u)\n", creq->bank.bankId,
g_bankd->srvc.bankd.bank_id);
+"(we are %u)\n", rreq->bank.bankId,
g_bankd->srvc.bankd.bank_id);
resp =
rspro_gen_RemoveMappingRes(ResultCode_illegalBankId);
} else if (rreq->bank.slotNr >= g_bankd->srvc.bankd.num_slots) {
LOGPFSML(srvc->fi, LOGL_ERROR, "removeMapping specifies
invalid Slot Nr %lu "
-"(we have %u)\n", creq->bank.slotNr,
g_bankd->srvc.bankd.num_slots);
+"(we have %u)\n", rreq->bank.slotNr,
g_bankd->srvc.bankd.num_slots);
resp =
rspro_gen_RemoveMappingRes(ResultCode_illegalSlotId);
} else {
rspro2bank_slot(, >bank);
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/16488
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I04e9e2447336f7d1aaeb932928a79bb705aa0c5a
Gerrit-Change-Number: 16488
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
