Change in osmo-sgsn[master]: gprs_gmm: Cancel Location: use detach type IMSI

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9254 )

Change subject: gprs_gmm: Cancel Location: use detach type IMSI
..

gprs_gmm: Cancel Location: use detach type IMSI

The detach type network side is defined as
- Reattach required
- Reattach not required
- IMSI detach (after VLR failure)

IMSI detach seems to be more close. Howeever the standard
isn't clear about this.

Change-Id: I27da6dc5165819cccd1ae0a98b132b45a01f38bb
---
M src/gprs/gprs_gmm.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index 57d3883..6a5c5d9 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -1150,7 +1150,7 @@
  get_value_string(gsm48_gmm_cause_names, gmm_cause),
  gmm_cause);
gsm48_tx_gmm_detach_req(
-   ctx, GPRS_DET_T_MT_REATT_NOTREQ, gmm_cause);
+   ctx, GPRS_DET_T_MT_IMSI, gmm_cause);

mm_ctx_cleanup_free(ctx, "auth lost");
break;

--
To view, visit https://gerrit.osmocom.org/9254
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I27da6dc5165819cccd1ae0a98b132b45a01f38bb
Gerrit-Change-Number: 9254
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 

Change in osmo-sgsn[master]: gprs_gmm: Cancel Location: use detach type IMSI

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9254 )

Change subject: gprs_gmm: Cancel Location: use detach type IMSI
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9254
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I27da6dc5165819cccd1ae0a98b132b45a01f38bb
Gerrit-Change-Number: 9254
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 29 May 2018 14:41:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sgsn[master]: gprs_gmm: Cancel Location: use detach type IMSI

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9254


Change subject: gprs_gmm: Cancel Location: use detach type IMSI
..

gprs_gmm: Cancel Location: use detach type IMSI

The detach type network side is defined as
- Reattach required
- Reattach not required
- IMSI detach (after VLR failure)

IMSI detach seems to be more close. Howeever the standard
isn't clear about this.

Change-Id: I27da6dc5165819cccd1ae0a98b132b45a01f38bb
---
M src/gprs/gprs_gmm.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/54/9254/1

diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index 93d64a4..4593dde 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -1150,7 +1150,7 @@
  get_value_string(gsm48_gmm_cause_names, gmm_cause),
  gmm_cause);
gsm48_tx_gmm_detach_req(
-   ctx, GPRS_DET_T_MT_REATT_NOTREQ, gmm_cause);
+   ctx, GPRS_DET_T_MT_IMSI, gmm_cause);

mm_ctx_cleanup_free(ctx, "auth lost");
break;

--
To view, visit https://gerrit.osmocom.org/9254
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I27da6dc5165819cccd1ae0a98b132b45a01f38bb
Gerrit-Change-Number: 9254
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus