Change in osmo-sgsn[master]: gprs_gmm: make extract_subscr_msisdn extract_subscr_hlr public

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9256 )

Change subject: gprs_gmm: make extract_subscr_msisdn extract_subscr_hlr public
..

gprs_gmm: make extract_subscr_msisdn extract_subscr_hlr public

Change-Id: I54168e1a58dd36b38c53c13bbb5cdb4311f34410
---
M include/osmocom/sgsn/gprs_gmm.h
M src/gprs/gprs_gmm.c
2 files changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/sgsn/gprs_gmm.h b/include/osmocom/sgsn/gprs_gmm.h
index b89eff5..3c93efc 100644
--- a/include/osmocom/sgsn/gprs_gmm.h
+++ b/include/osmocom/sgsn/gprs_gmm.h
@@ -40,4 +40,7 @@
uint8_t gmm_cause);
 int gsm48_tx_gmm_att_ack(struct sgsn_mm_ctx *mm);

+/* TODO: move extract_subscr_* when gsm48_gmm_authorize() got removed */
+void extract_subscr_msisdn(struct sgsn_mm_ctx *ctx);
+void extract_subscr_hlr(struct sgsn_mm_ctx *ctx);
 #endif /* _GPRS_GMM_H */
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index df498c1..57d3883 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -848,7 +848,7 @@
return rc;
 }

-static void extract_subscr_msisdn(struct sgsn_mm_ctx *ctx)
+void extract_subscr_msisdn(struct sgsn_mm_ctx *ctx)
 {
struct gsm_mncc_number called;
uint8_t msisdn[sizeof(ctx->subscr->sgsn_data->msisdn) + 1];
@@ -879,7 +879,7 @@
}
 }

-static void extract_subscr_hlr(struct sgsn_mm_ctx *ctx)
+void extract_subscr_hlr(struct sgsn_mm_ctx *ctx)
 {
struct gsm_mncc_number called;
uint8_t hlr_number[sizeof(ctx->subscr->sgsn_data->hlr) + 1];

--
To view, visit https://gerrit.osmocom.org/9256
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I54168e1a58dd36b38c53c13bbb5cdb4311f34410
Gerrit-Change-Number: 9256
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-sgsn[master]: gprs_gmm: make extract_subscr_msisdn extract_subscr_hlr public

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9256 )

Change subject: gprs_gmm: make extract_subscr_msisdn extract_subscr_hlr public
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9256
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54168e1a58dd36b38c53c13bbb5cdb4311f34410
Gerrit-Change-Number: 9256
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 23 May 2018 16:06:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sgsn[master]: gprs_gmm: make extract_subscr_msisdn extract_subscr_hlr public

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9256


Change subject: gprs_gmm: make extract_subscr_msisdn extract_subscr_hlr public
..

gprs_gmm: make extract_subscr_msisdn extract_subscr_hlr public

Change-Id: I54168e1a58dd36b38c53c13bbb5cdb4311f34410
---
M include/osmocom/sgsn/gprs_gmm.h
M src/gprs/gprs_gmm.c
2 files changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/56/9256/1

diff --git a/include/osmocom/sgsn/gprs_gmm.h b/include/osmocom/sgsn/gprs_gmm.h
index b89eff5..3c93efc 100644
--- a/include/osmocom/sgsn/gprs_gmm.h
+++ b/include/osmocom/sgsn/gprs_gmm.h
@@ -40,4 +40,7 @@
uint8_t gmm_cause);
 int gsm48_tx_gmm_att_ack(struct sgsn_mm_ctx *mm);

+/* TODO: move extract_subscr_* when gsm48_gmm_authorize() got removed */
+void extract_subscr_msisdn(struct sgsn_mm_ctx *ctx);
+void extract_subscr_hlr(struct sgsn_mm_ctx *ctx);
 #endif /* _GPRS_GMM_H */
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index df498c1..57d3883 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -848,7 +848,7 @@
return rc;
 }

-static void extract_subscr_msisdn(struct sgsn_mm_ctx *ctx)
+void extract_subscr_msisdn(struct sgsn_mm_ctx *ctx)
 {
struct gsm_mncc_number called;
uint8_t msisdn[sizeof(ctx->subscr->sgsn_data->msisdn) + 1];
@@ -879,7 +879,7 @@
}
 }

-static void extract_subscr_hlr(struct sgsn_mm_ctx *ctx)
+void extract_subscr_hlr(struct sgsn_mm_ctx *ctx)
 {
struct gsm_mncc_number called;
uint8_t hlr_number[sizeof(ctx->subscr->sgsn_data->hlr) + 1];

--
To view, visit https://gerrit.osmocom.org/9256
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54168e1a58dd36b38c53c13bbb5cdb4311f34410
Gerrit-Change-Number: 9256
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus