Change in osmo-sgsn[master]: vty: Add cmd to disable echo loop explictly
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/9948 )
Change subject: vty: Add cmd to disable echo loop explictly
..
vty: Add cmd to disable echo loop explictly
Change-Id: I0598427257533ce8ae9e9afa787293d7c98fed15
---
M src/gprs/sgsn_vty.c
1 file changed, 17 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
diff --git a/src/gprs/sgsn_vty.c b/src/gprs/sgsn_vty.c
index 9f9332c..8092158 100644
--- a/src/gprs/sgsn_vty.c
+++ b/src/gprs/sgsn_vty.c
@@ -185,6 +185,9 @@
if (gctx->echo_interval != -1)
vty_out(vty, " ggsn %u echo-interval %"PRId32"%s",
gctx->id, gctx->echo_interval, VTY_NEWLINE);
+ else
+ vty_out(vty, " ggsn %u no echo-interval%s",
+ gctx->id, VTY_NEWLINE);
}
if (sgsn->cfg.dynamic_lookup)
@@ -380,6 +383,19 @@
return CMD_SUCCESS;
}
+DEFUN(cfg_ggsn_no_echo_interval, cfg_ggsn_no_echo_interval_cmd,
+ "ggsn <0-255> no echo-interval",
+ GGSN_STR "GGSN Number\n"
+ NO_STR "Send an echo request to this static GGSN every interval.\n")
+{
+ uint32_t id = atoi(argv[0]);
+ struct sgsn_ggsn_ctx *ggc = sgsn_ggsn_ctx_find_alloc(id);
+
+ ggc->echo_interval = -1;
+
+ return CMD_SUCCESS;
+}
+
DEFUN(cfg_ggsn_dynamic_lookup, cfg_ggsn_dynamic_lookup_cmd,
"ggsn dynamic",
GGSN_STR
@@ -1302,6 +1318,7 @@
//install_element(SGSN_NODE, _ggsn_remote_port_cmd);
install_element(SGSN_NODE, _ggsn_gtp_version_cmd);
install_element(SGSN_NODE, _ggsn_echo_interval_cmd);
+ install_element(SGSN_NODE, _ggsn_no_echo_interval_cmd);
install_element(SGSN_NODE, _imsi_acl_cmd);
install_element(SGSN_NODE, _auth_policy_cmd);
install_element(SGSN_NODE, _encrypt_cmd);
--
To view, visit https://gerrit.osmocom.org/9948
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0598427257533ce8ae9e9afa787293d7c98fed15
Gerrit-Change-Number: 9948
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Change in osmo-sgsn[master]: vty: Add cmd to disable echo loop explictly
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9948 ) Change subject: vty: Add cmd to disable echo loop explictly .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0598427257533ce8ae9e9afa787293d7c98fed15 Gerrit-Change-Number: 9948 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 11 Jul 2018 20:09:49 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-sgsn[master]: vty: Add cmd to disable echo loop explictly
Pau Espin Pedrol has uploaded this change for review. (
https://gerrit.osmocom.org/9948
Change subject: vty: Add cmd to disable echo loop explictly
..
vty: Add cmd to disable echo loop explictly
Change-Id: I0598427257533ce8ae9e9afa787293d7c98fed15
---
M src/gprs/sgsn_vty.c
1 file changed, 17 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/48/9948/1
diff --git a/src/gprs/sgsn_vty.c b/src/gprs/sgsn_vty.c
index 9f9332c..8092158 100644
--- a/src/gprs/sgsn_vty.c
+++ b/src/gprs/sgsn_vty.c
@@ -185,6 +185,9 @@
if (gctx->echo_interval != -1)
vty_out(vty, " ggsn %u echo-interval %"PRId32"%s",
gctx->id, gctx->echo_interval, VTY_NEWLINE);
+ else
+ vty_out(vty, " ggsn %u no echo-interval%s",
+ gctx->id, VTY_NEWLINE);
}
if (sgsn->cfg.dynamic_lookup)
@@ -380,6 +383,19 @@
return CMD_SUCCESS;
}
+DEFUN(cfg_ggsn_no_echo_interval, cfg_ggsn_no_echo_interval_cmd,
+ "ggsn <0-255> no echo-interval",
+ GGSN_STR "GGSN Number\n"
+ NO_STR "Send an echo request to this static GGSN every interval.\n")
+{
+ uint32_t id = atoi(argv[0]);
+ struct sgsn_ggsn_ctx *ggc = sgsn_ggsn_ctx_find_alloc(id);
+
+ ggc->echo_interval = -1;
+
+ return CMD_SUCCESS;
+}
+
DEFUN(cfg_ggsn_dynamic_lookup, cfg_ggsn_dynamic_lookup_cmd,
"ggsn dynamic",
GGSN_STR
@@ -1302,6 +1318,7 @@
//install_element(SGSN_NODE, _ggsn_remote_port_cmd);
install_element(SGSN_NODE, _ggsn_gtp_version_cmd);
install_element(SGSN_NODE, _ggsn_echo_interval_cmd);
+ install_element(SGSN_NODE, _ggsn_no_echo_interval_cmd);
install_element(SGSN_NODE, _imsi_acl_cmd);
install_element(SGSN_NODE, _auth_policy_cmd);
install_element(SGSN_NODE, _encrypt_cmd);
--
To view, visit https://gerrit.osmocom.org/9948
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0598427257533ce8ae9e9afa787293d7c98fed15
Gerrit-Change-Number: 9948
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol
