Change in osmo-trx[master]: lms: fix LMS_StartStream() handling for multiple channels

2018-06-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9616 )

Change subject: lms: fix LMS_StartStream() handling for multiple channels
..

lms: fix LMS_StartStream() handling for multiple channels

LMS_StartStream() (in LMSDevice::start()) was moved to separate loop. It
is because LMS_SetupStream() would fail for second channel if streaming
has already been started (LMS_StartStream()) for single channel
configuration.

Change-Id: I6704bb92864aa81417507c4ae24a22f41dc529c1
---
M Transceiver52M/device/lms/LMSDevice.cpp
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Transceiver52M/device/lms/LMSDevice.cpp 
b/Transceiver52M/device/lms/LMSDevice.cpp
index 9c74c0a..ad6f67b 100644
--- a/Transceiver52M/device/lms/LMSDevice.cpp
+++ b/Transceiver52M/device/lms/LMSDevice.cpp
@@ -205,6 +205,7 @@

unsigned int i;

+   /* configure the channels/streams */
for (i=0; ihttps://gerrit.osmocom.org/9616
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6704bb92864aa81417507c4ae24a22f41dc529c1
Gerrit-Change-Number: 9616
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder


Change in osmo-trx[master]: lms: fix LMS_StartStream() handling for multiple channels

2018-06-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9616 )

Change subject: lms: fix LMS_StartStream() handling for multiple channels
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9616
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6704bb92864aa81417507c4ae24a22f41dc529c1
Gerrit-Change-Number: 9616
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 13 Jun 2018 21:45:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-trx[master]: lms: fix LMS_StartStream() handling for multiple channels

2018-06-13 Thread Harald Welte
Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/9616


Change subject: lms: fix LMS_StartStream() handling for multiple channels
..

lms: fix LMS_StartStream() handling for multiple channels

LMS_StartStream() (in LMSDevice::start()) was moved to separate loop. It
is because LMS_SetupStream() would fail for second channel if streaming
has already been started (LMS_StartStream()) for single channel
configuration.

Change-Id: I6704bb92864aa81417507c4ae24a22f41dc529c1
---
M Transceiver52M/device/lms/LMSDevice.cpp
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/16/9616/1

diff --git a/Transceiver52M/device/lms/LMSDevice.cpp 
b/Transceiver52M/device/lms/LMSDevice.cpp
index 9c74c0a..ad6f67b 100644
--- a/Transceiver52M/device/lms/LMSDevice.cpp
+++ b/Transceiver52M/device/lms/LMSDevice.cpp
@@ -205,6 +205,7 @@

unsigned int i;

+   /* configure the channels/streams */
for (i=0; ihttps://gerrit.osmocom.org/9616
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6704bb92864aa81417507c4ae24a22f41dc529c1
Gerrit-Change-Number: 9616
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte