Change in osmo-ttcn3-hacks[master]: MSC: fix TC_iu_cmserv_imsi_unknown: do not call f_mm_auth()
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16889 ) Change subject: MSC: fix TC_iu_cmserv_imsi_unknown: do not call f_mm_auth() .. Patch Set 1: hmm, interesting. So a CM Service Reject with "LU Required" should happen because the VLR doesn't know the IMSI yet, but not sure whether it should authenticate first. Probably not, right? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16889 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26fe18093e49bc9f53ac0234338c2b5cf9e4f07c Gerrit-Change-Number: 16889 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 30 Apr 2020 14:05:02 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: MSC: fix TC_iu_cmserv_imsi_unknown: do not call f_mm_auth()
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16889 ) Change subject: MSC: fix TC_iu_cmserv_imsi_unknown: do not call f_mm_auth() .. Patch Set 1: (stupid Gerrit UI, I cannot add comments / reviewers without starting review) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16889 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26fe18093e49bc9f53ac0234338c2b5cf9e4f07c Gerrit-Change-Number: 16889 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 20 Apr 2020 10:04:36 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: MSC: fix TC_iu_cmserv_imsi_unknown: do not call f_mm_auth()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16889 ) Change subject: MSC: fix TC_iu_cmserv_imsi_unknown: do not call f_mm_auth() .. Patch Set 1: I think the problem is that somebody modified the test beyond what it originally intended to do. As the comment states, it is about an "IMSI that has never performed a LU before" (i.e. IMSI unknown to the VLR). It doesn't state that this IMSI is unknown to the HLR and hence should be rejected. That probably also explains the commented-out LU accept line in the test... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16889 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26fe18093e49bc9f53ac0234338c2b5cf9e4f07c Gerrit-Change-Number: 16889 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Fri, 17 Jan 2020 15:23:30 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: MSC: fix TC_iu_cmserv_imsi_unknown: do not call f_mm_auth()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16889 ) Change subject: MSC: fix TC_iu_cmserv_imsi_unknown: do not call f_mm_auth() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16889 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26fe18093e49bc9f53ac0234338c2b5cf9e4f07c Gerrit-Change-Number: 16889 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Jan 2020 12:01:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: MSC: fix TC_iu_cmserv_imsi_unknown: do not call f_mm_auth()
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16889 ) Change subject: MSC: fix TC_iu_cmserv_imsi_unknown: do not call f_mm_auth() .. MSC: fix TC_iu_cmserv_imsi_unknown: do not call f_mm_auth() It does not make sense to expect Authentication procedure for an unknown IMSI. For GERAN tests authentication is disabled by default, so that's why TC_cmserv_imsi_unknown passess. Change-Id: I26fe18093e49bc9f53ac0234338c2b5cf9e4f07c --- M msc/MSC_Tests.ttcn 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/16889/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index ccfc154..04ea386 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -638,7 +638,6 @@ /* Send BSSAP_Conn_Req with COMPL L3 INFO to MSC */ f_cl3_or_initial_ue(l3_info); - f_mm_auth(); timer T := 10.0; T.start; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16889 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26fe18093e49bc9f53ac0234338c2b5cf9e4f07c Gerrit-Change-Number: 16889 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
