Change in osmo-ttcn3-hacks[master]: MSC_Tests: Extend timeout waiting for Clear Cmd in TC_establish_and_n...

2018-05-17 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/9219 )

Change subject: MSC_Tests: Extend timeout waiting for Clear Cmd in 
TC_establish_and_nothing
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9219
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I998cfb52a3813dd9f76d3787e4d0d448752ec847
Gerrit-Change-Number: 9219
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Thu, 17 May 2018 15:35:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-ttcn3-hacks[master]: MSC_Tests: Extend timeout waiting for Clear Cmd in TC_establish_and_n...

2018-05-17 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/9219


Change subject: MSC_Tests: Extend timeout waiting for Clear Cmd in 
TC_establish_and_nothing
..

MSC_Tests: Extend timeout waiting for Clear Cmd in TC_establish_and_nothing

This should fix the bogus failures we are seeing in this test. The pcap
usually shows that the Clear Command does arrive after about 5 seconds,
but sometimes the internal timer fires before that. Double the timeout
of the test here.

Change-Id: I998cfb52a3813dd9f76d3787e4d0d448752ec847
---
M msc/MSC_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/19/9219/1

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index edaa61b..56ac3d3 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -1173,7 +1173,7 @@
f_perform_lu();

f_establish_fully();
-   f_expect_clear();
+   f_expect_clear(10.0);
 }
 testcase TC_establish_and_nothing() runs on MTC_CT {
var BSC_ConnHdlr vc_conn;

--
To view, visit https://gerrit.osmocom.org/9219
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I998cfb52a3813dd9f76d3787e4d0d448752ec847
Gerrit-Change-Number: 9219
Gerrit-PatchSet: 1
Gerrit-Owner: daniel