Change in osmo-ttcn3-hacks[master]: MSC_Tests: fix iterator in f_init()
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/9203 )
Change subject: MSC_Tests: fix iterator in f_init()
..
MSC_Tests: fix iterator in f_init()
With f_init(), the user has the option to specifiy how many bsc
instances should be created. A for loop then iterates over the
prepared configurations and calls f_bssap_init(). The first
parameter g_bssap is tied to index 0 constantly but should be
tied to the iterator i.
- use i instad of 0 as iterator for g_bssap
Change-Id: I490bab70224d236ab576a2ea3863f6d0afd5f22a
---
M msc/MSC_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 1ede8e6..edaa61b 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -227,7 +227,7 @@
for (var integer i := 0; i < num_bsc; i := i + 1) {
if (isbound(mp_bssap_cfg[i])) {
- f_bssap_init(g_bssap[0], mp_bssap_cfg[i], "MSC_Test_" &
int2str(i), BSC_BssmapOps);
+ f_bssap_init(g_bssap[i], mp_bssap_cfg[i], "MSC_Test_" &
int2str(i), BSC_BssmapOps);
} else {
setverdict(fail, "missing BSSAP configuration");
}
--
To view, visit https://gerrit.osmocom.org/9203
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I490bab70224d236ab576a2ea3863f6d0afd5f22a
Gerrit-Change-Number: 9203
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Change in osmo-ttcn3-hacks[master]: MSC_Tests: fix iterator in f_init()
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9203 ) Change subject: MSC_Tests: fix iterator in f_init() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9203 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I490bab70224d236ab576a2ea3863f6d0afd5f22a Gerrit-Change-Number: 9203 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 17 May 2018 07:23:30 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ttcn3-hacks[master]: MSC_Tests: fix iterator in f_init()
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9203
Change subject: MSC_Tests: fix iterator in f_init()
..
MSC_Tests: fix iterator in f_init()
With f_init(), the user has the option to specifiy how many bsc
instances should be created. A for loop then iterates over the
prepared configurations and calls f_bssap_init(). The first
parameter g_bssap is tied to index 0 constantly but should be
tied to the iterator i.
- use i instad of 0 as iterator for g_bssap
Change-Id: I490bab70224d236ab576a2ea3863f6d0afd5f22a
---
M msc/MSC_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/03/9203/1
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 1ede8e6..edaa61b 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -227,7 +227,7 @@
for (var integer i := 0; i < num_bsc; i := i + 1) {
if (isbound(mp_bssap_cfg[i])) {
- f_bssap_init(g_bssap[0], mp_bssap_cfg[i], "MSC_Test_" &
int2str(i), BSC_BssmapOps);
+ f_bssap_init(g_bssap[i], mp_bssap_cfg[i], "MSC_Test_" &
int2str(i), BSC_BssmapOps);
} else {
setverdict(fail, "missing BSSAP configuration");
}
--
To view, visit https://gerrit.osmocom.org/9203
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I490bab70224d236ab576a2ea3863f6d0afd5f22a
Gerrit-Change-Number: 9203
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
