Change in osmo-ttcn3-hacks[master]: SGSN: add TC_hlr_location_cancel_request

2018-05-26 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9248 )

Change subject: SGSN: add TC_hlr_location_cancel_request
..

SGSN: add TC_hlr_location_cancel_request

MS <-> SGSN: GMM Attach
HLR -> SGSN: Cancel Location Request
HLR <- SGSN: Cancel Location Ack
MS  <- SGSN: Detach Request
SGSN->   MS: Detach Complete

Change-Id: Id5d6b018a5a4389eefa8f5d950324aab91709f5a
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 32 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index e1d35c5..1a68014 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1249,6 +1249,37 @@
 }


+private function f_TC_hlr_location_cancel_request_withdraw(charstring id) runs 
on BSSGP_ConnHdlr {
+   /* MS: perform regular attach */
+   f_TC_attach(id);
+
+   /* HLR: cancel the location request */
+   GSUP.send(ts_GSUP_CL_REQ(g_pars.imsi, OSMO_GSUP_CANCEL_TYPE_WITHDRAW));
+   GSUP.receive(tr_GSUP_CL_RES(g_pars.imsi));
+   GSUP.send(ts_GSUP_UL_RES(g_pars.imsi));
+
+   /* MS: receive a Detach Request */
+   BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_REQ_MT(c_GMM_DTT_MT_IMSI_DETACH, 
?, ?)));
+   BSSGP.send(ts_GMM_DET_ACCEPT_MO);
+
+   setverdict(pass);
+}
+
+testcase TC_hlr_location_cancel_request_withdraw() runs on test_CT {
+   /* MS <-> SGSN: GMM Attach
+* HLR -> SGSN: Cancel Location Request
+* HLR <- SGSN: Cancel Location Ack
+* MS  <- SGSN: Detach Request
+* SGSN->   MS: Detach Complete
+*/
+   var BSSGP_ConnHdlr vc_conn;
+   f_init();
+   f_sleep(1.0);
+   vc_conn := 
f_start_handler(refers(f_TC_hlr_location_cancel_request_withdraw), 
testcasename(), g_gb[0], 29);
+   vc_conn.done;
+}
+
+
 control {
execute( TC_attach() );
execute( TC_attach_mnc3() );
@@ -1262,6 +1293,7 @@
execute( TC_attach_combined() );
execute( TC_attach_accept_all() );
execute( TC_attach_closed() );
+   execute( TC_hlr_location_cancel_request_withdraw(), 5.0 );
execute( TC_rau_unknown() );
execute( TC_attach_rau() );
execute( TC_detach_unknown_nopoweroff() );

--
To view, visit https://gerrit.osmocom.org/9248
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5d6b018a5a4389eefa8f5d950324aab91709f5a
Gerrit-Change-Number: 9248
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-ttcn3-hacks[master]: SGSN: add TC_hlr_location_cancel_request

2018-05-26 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9248 )

Change subject: SGSN: add TC_hlr_location_cancel_request
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9248
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5d6b018a5a4389eefa8f5d950324aab91709f5a
Gerrit-Change-Number: 9248
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sat, 26 May 2018 21:00:00 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: SGSN: add TC_hlr_location_cancel_request

2018-05-26 Thread lynxis lazus 
Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9248

to look at the new patch set (#4).

Change subject: SGSN: add TC_hlr_location_cancel_request
..

SGSN: add TC_hlr_location_cancel_request

MS <-> SGSN: GMM Attach
HLR -> SGSN: Cancel Location Request
HLR <- SGSN: Cancel Location Ack
MS  <- SGSN: Detach Request
SGSN->   MS: Detach Complete

Change-Id: Id5d6b018a5a4389eefa8f5d950324aab91709f5a
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 32 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/48/9248/4
--
To view, visit https://gerrit.osmocom.org/9248
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5d6b018a5a4389eefa8f5d950324aab91709f5a
Gerrit-Change-Number: 9248
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-ttcn3-hacks[master]: SGSN: add TC_hlr_location_cancel_request

2018-05-26 Thread lynxis lazus 
Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9248

to look at the new patch set (#2).

Change subject: SGSN: add TC_hlr_location_cancel_request
..

SGSN: add TC_hlr_location_cancel_request

MS <-> SGSN: GMM Attach
HLR -> SGSN: Cancel Location Request
HLR <- SGSN: Cancel Location Ack
MS  <- SGSN: Detach Request
SGSN->   MS: Detach Complete

Change-Id: Id5d6b018a5a4389eefa8f5d950324aab91709f5a
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 32 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/48/9248/2
--
To view, visit https://gerrit.osmocom.org/9248
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5d6b018a5a4389eefa8f5d950324aab91709f5a
Gerrit-Change-Number: 9248
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-ttcn3-hacks[master]: SGSN: add TC_hlr_location_cancel_request

2018-05-26 Thread lynxis lazus 
Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9248

to look at the new patch set (#3).

Change subject: SGSN: add TC_hlr_location_cancel_request
..

SGSN: add TC_hlr_location_cancel_request

MS <-> SGSN: GMM Attach
HLR -> SGSN: Cancel Location Request
HLR <- SGSN: Cancel Location Ack
MS  <- SGSN: Detach Request
SGSN->   MS: Detach Complete

Change-Id: Id5d6b018a5a4389eefa8f5d950324aab91709f5a
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 32 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/48/9248/3
--
To view, visit https://gerrit.osmocom.org/9248
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5d6b018a5a4389eefa8f5d950324aab91709f5a
Gerrit-Change-Number: 9248
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-ttcn3-hacks[master]: SGSN: add TC_hlr_location_cancel_request

2018-05-23 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9248 )

Change subject: SGSN: add TC_hlr_location_cancel_request
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/9248/1/sgsn/SGSN_Tests.ttcn
File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/#/c/9248/1/sgsn/SGSN_Tests.ttcn@1257
PS1, Line 1257:
  : gsup :=
You can do without the gsup variable here, directly sending the template



--
To view, visit https://gerrit.osmocom.org/9248
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5d6b018a5a4389eefa8f5d950324aab91709f5a
Gerrit-Change-Number: 9248
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 23 May 2018 07:13:41 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: SGSN: add TC_hlr_location_cancel_request

2018-05-22 Thread lynxis lazus 
lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9248


Change subject: SGSN: add TC_hlr_location_cancel_request
..

SGSN: add TC_hlr_location_cancel_request

MS <-> SGSN: GMM Attach
HLR -> SGSN: Cancel Location Request
HLR <- SGSN: Cancel Location Ack
MS  <- SGSN: Detach Request
SGSN->   MS: Detach Complete

Change-Id: Id5d6b018a5a4389eefa8f5d950324aab91709f5a
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 34 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/48/9248/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 36a4700..a2679cf 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1249,6 +1249,39 @@
 }


+private function f_TC_hlr_location_cancel_request_withdraw(charstring id) runs 
on BSSGP_ConnHdlr {
+   /* MS: perform regular attach */
+   f_TC_attach(id);
+
+   /* HLR: cancel the location request */
+   var GSUP_PDU gsup;
+   gsup := valueof(ts_GSUP_CL_REQ(g_pars.imsi, 
OSMO_GSUP_CANCEL_TYPE_WITHDRAW));
+   GSUP.send(gsup);
+   GSUP.receive(tr_GSUP_CL_RES(g_pars.imsi));
+   GSUP.send(ts_GSUP_UL_RES(g_pars.imsi));
+
+   /* MS: receive a Detach Request */
+   BSSGP.receive(tr_BD_L3_MT(tr_GMM_DET_REQ_MT(c_GMM_DTT_MT_IMSI_DETACH, 
?, ?)));
+   BSSGP.send(ts_GMM_DET_ACCEPT_MT);
+
+   setverdict(pass);
+}
+
+testcase TC_hlr_location_cancel_request_withdraw() runs on test_CT {
+   /* MS <-> SGSN: GMM Attach
+* HLR -> SGSN: Cancel Location Request
+* HLR <- SGSN: Cancel Location Ack
+* MS  <- SGSN: Detach Request
+* SGSN->   MS: Detach Complete
+*/
+   var BSSGP_ConnHdlr vc_conn;
+   f_init();
+   f_sleep(1.0);
+   vc_conn := 
f_start_handler(refers(f_TC_hlr_location_cancel_request_withdraw), 
testcasename(), g_gb[0], 29);
+   vc_conn.done;
+}
+
+
 control {
execute( TC_attach() );
execute( TC_attach_mnc3() );
@@ -1262,6 +1295,7 @@
execute( TC_attach_combined() );
execute( TC_attach_accept_all() );
execute( TC_attach_closed() );
+   execute( TC_hlr_location_cancel_request_withdraw(), 5.0 );
execute( TC_rau_unknown() );
execute( TC_attach_rau() );
execute( TC_detach_unknown_nopoweroff() );

--
To view, visit https://gerrit.osmocom.org/9248
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5d6b018a5a4389eefa8f5d950324aab91709f5a
Gerrit-Change-Number: 9248
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus