Change in osmo-ttcn3-hacks[master]: library/TRXC_Types.ttcn: correct FAKE_RSSI command template
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11433 ) Change subject: library/TRXC_Types.ttcn: correct FAKE_RSSI command template .. library/TRXC_Types.ttcn: correct FAKE_RSSI command template Absolute form of FAKE_RSSI command shall contain an optional threshold value. Otherwise it's interpreted as relative form. Change-Id: Ief89b2601277488bb1782b981aff1061ddaa6637 --- M library/TRXC_Types.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Pau Espin Pedrol: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/TRXC_Types.ttcn b/library/TRXC_Types.ttcn index 1a37a8c..77666d9 100644 --- a/library/TRXC_Types.ttcn +++ b/library/TRXC_Types.ttcn @@ -58,10 +58,10 @@ external function dec_TrxcMessage(in charstring id) return TrxcMessage with { extension "prototype(convert) decode(TEXT)" }; -template (value) TrxcMessage ts_TRXC_FAKE_RSSI(uint8_t rssi) := { +template (value) TrxcMessage ts_TRXC_FAKE_RSSI(uint8_t rssi, int16_t thresh := 0) := { cmd := { verb := "FAKE_RSSI", - params := { int2str(rssi) } + params := { int2str(rssi), int2str(thresh) } } } -- To view, visit https://gerrit.osmocom.org/11433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ief89b2601277488bb1782b981aff1061ddaa6637 Gerrit-Change-Number: 11433 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol
Change in osmo-ttcn3-hacks[master]: library/TRXC_Types.ttcn: correct FAKE_RSSI command template
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11433 ) Change subject: library/TRXC_Types.ttcn: correct FAKE_RSSI command template .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief89b2601277488bb1782b981aff1061ddaa6637 Gerrit-Change-Number: 11433 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Tue, 23 Oct 2018 10:27:52 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ttcn3-hacks[master]: library/TRXC_Types.ttcn: correct FAKE_RSSI command template
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11433 Change subject: library/TRXC_Types.ttcn: correct FAKE_RSSI command template .. library/TRXC_Types.ttcn: correct FAKE_RSSI command template Absolute form of FAKE_RSSI command shall contain an optional threshold value. Otherwise it's interpreted as relative form. Change-Id: Ief89b2601277488bb1782b981aff1061ddaa6637 --- M library/TRXC_Types.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/11433/1 diff --git a/library/TRXC_Types.ttcn b/library/TRXC_Types.ttcn index 1a37a8c..77666d9 100644 --- a/library/TRXC_Types.ttcn +++ b/library/TRXC_Types.ttcn @@ -58,10 +58,10 @@ external function dec_TrxcMessage(in charstring id) return TrxcMessage with { extension "prototype(convert) decode(TEXT)" }; -template (value) TrxcMessage ts_TRXC_FAKE_RSSI(uint8_t rssi) := { +template (value) TrxcMessage ts_TRXC_FAKE_RSSI(uint8_t rssi, int16_t thresh := 0) := { cmd := { verb := "FAKE_RSSI", - params := { int2str(rssi) } + params := { int2str(rssi), int2str(thresh) } } } -- To view, visit https://gerrit.osmocom.org/11433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ief89b2601277488bb1782b981aff1061ddaa6637 Gerrit-Change-Number: 11433 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy