Change in osmo-ttcn3-hacks[master]: msc: add MSC_Tests.TC_call_re_establishment_auth

2021-08-06 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073 )

Change subject: msc: add MSC_Tests.TC_call_re_establishment_auth
..

msc: add MSC_Tests.TC_call_re_establishment_auth

Invoke TC_call_re_establishment with authentication required.

Related: SYS#5130
Change-Id: I8110a6b432de734d53b111c7b69aabca12129691
---
M msc/MSC_Tests.ttcn
1 file changed, 21 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index c9207aa..dae27d0 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -6754,6 +6754,26 @@
vc_conn2.done;
 }

+testcase TC_call_re_establishment_auth() runs on MTC_CT {
+   var BSC_ConnHdlr vc_conn1;
+   var BSC_ConnHdlr vc_conn2;
+   f_init();
+
+   f_vty_config(MSCVTY, "network", "authentication required");
+
+   var BSC_ConnHdlrPars pars1 := f_init_pars(92);
+   pars1.net.expect_auth := true;
+   var BSC_ConnHdlrPars pars2 := pars1;
+
+   vc_conn1 := f_start_handler_create(pars1);
+   vc_conn2 := f_start_handler_create(pars2);
+   connect(vc_conn1:COORD, vc_conn2:COORD);
+   f_start_handler_run(vc_conn1, refers(f_tc_call_re_establishment_1), 
pars1);
+   f_start_handler_run(vc_conn2, refers(f_tc_call_re_establishment_2), 
pars2);
+   vc_conn1.done;
+   vc_conn2.done;
+}
+
 control {
execute( TC_cr_before_reset() );
execute( TC_lu_imsi_noauth_tmsi() );
@@ -6914,6 +6934,7 @@
execute( TC_paging_response_tmsi_unknown() );

execute( TC_call_re_establishment() );
+   execute( TC_call_re_establishment_auth() );
 }



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8110a6b432de734d53b111c7b69aabca12129691
Gerrit-Change-Number: 25073
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-ttcn3-hacks[master]: msc: add MSC_Tests.TC_call_re_establishment_auth

2021-08-02 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073 )

Change subject: msc: add MSC_Tests.TC_call_re_establishment_auth
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8110a6b432de734d53b111c7b69aabca12129691
Gerrit-Change-Number: 25073
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 02 Aug 2021 15:08:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: msc: add MSC_Tests.TC_call_re_establishment_auth

2021-07-29 Thread osmith 
osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073 )

Change subject: msc: add MSC_Tests.TC_call_re_establishment_auth
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8110a6b432de734d53b111c7b69aabca12129691
Gerrit-Change-Number: 25073
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 29 Jul 2021 16:31:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: msc: add MSC_Tests.TC_call_re_establishment_auth

2021-07-28 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073 )

Change subject: msc: add MSC_Tests.TC_call_re_establishment_auth
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8110a6b432de734d53b111c7b69aabca12129691
Gerrit-Change-Number: 25073
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 28 Jul 2021 16:25:21 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: msc: add MSC_Tests.TC_call_re_establishment_auth

2021-07-28 Thread neels 
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073

to look at the new patch set (#2).

Change subject: msc: add MSC_Tests.TC_call_re_establishment_auth
..

msc: add MSC_Tests.TC_call_re_establishment_auth

Invoke TC_call_re_establishment with authentication required.

Related: SYS#5130
Change-Id: I8110a6b432de734d53b111c7b69aabca12129691
---
M msc/MSC_Tests.ttcn
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/73/25073/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8110a6b432de734d53b111c7b69aabca12129691
Gerrit-Change-Number: 25073
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-ttcn3-hacks[master]: msc: add MSC_Tests.TC_call_re_establishment_auth

2021-07-28 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073 )

Change subject: msc: add MSC_Tests.TC_call_re_establishment_auth
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073/1/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073/1/msc/MSC_Tests.ttcn@6749
PS1, Line 6749: connect(vc_conn1:COORD, vc_conn2:COORD);
Can't you have a race condition here since you start vc_conn1 and vc_conn2 
previously? It may be that one of them tries to use COORD and it's not yet 
connected?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8110a6b432de734d53b111c7b69aabca12129691
Gerrit-Change-Number: 25073
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Comment-Date: Wed, 28 Jul 2021 12:10:33 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: msc: add MSC_Tests.TC_call_re_establishment_auth

2021-07-27 Thread neels 
neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073 )


Change subject: msc: add MSC_Tests.TC_call_re_establishment_auth
..

msc: add MSC_Tests.TC_call_re_establishment_auth

Invoke TC_call_re_establishment with authentication required.

Related: SYS#5130
Change-Id: I8110a6b432de734d53b111c7b69aabca12129691
---
M msc/MSC_Tests.ttcn
1 file changed, 22 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/73/25073/1

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 428dae3..a46a25f 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -6652,6 +6652,9 @@
COORD.receive(REEST_LOST_CONNECTION);
COORD.receive(tr_CallParams) -> value cpars;

+   f_gsup_imsi_steal(hex2str(g_pars.imsi));
+   f_create_smpp_expect(hex2str(pars.msisdn));
+
/* The MS has lost the first channel and decides to show up on a new 
conn (on a nearby neighbor cell) to ask for
 * CM Re-Establishment. Send a Complete Layer 3 to osmo-msc with a CM 
Re-Establishment Request. */
var MobileIdentityLV mi := valueof(ts_MI_IMSI_LV(g_pars.imsi));
@@ -6730,6 +6733,24 @@
vc_conn2.done;
 }

+testcase TC_call_re_establishment_auth() runs on MTC_CT {
+   var BSC_ConnHdlr vc_conn1;
+   var BSC_ConnHdlr vc_conn2;
+   f_init();
+
+   f_vty_config(MSCVTY, "network", "authentication required");
+
+   var BSC_ConnHdlrPars pars1 := f_init_pars(92);
+   pars1.net.expect_auth := true;
+   var BSC_ConnHdlrPars pars2 := pars1;
+
+   vc_conn1 := 
f_start_handler_with_pars(refers(f_tc_call_re_establishment_1), pars1);
+   vc_conn2 := 
f_start_handler_with_pars(refers(f_tc_call_re_establishment_2), pars2);
+   connect(vc_conn1:COORD, vc_conn2:COORD);
+   vc_conn1.done;
+   vc_conn2.done;
+}
+

 control {
execute( TC_cr_before_reset() );
@@ -6891,6 +6912,7 @@
execute( TC_paging_response_tmsi_unknown() );

execute( TC_call_re_establishment() );
+   execute( TC_call_re_establishment_auth() );
 }



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8110a6b432de734d53b111c7b69aabca12129691
Gerrit-Change-Number: 25073
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange