Change in osmocom-bb[master]: trxcon/sched_trx.h: add missing parentheses to PRIM_IS_*

2018-08-15 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10453 )

Change subject: trxcon/sched_trx.h: add missing parentheses to PRIM_IS_*
..

trxcon/sched_trx.h: add missing parentheses to PRIM_IS_*

Change-Id: Ifa7d9f806b3f18f2dfec931252f5119441b30e8a
---
M src/host/trxcon/sched_trx.h
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/host/trxcon/sched_trx.h b/src/host/trxcon/sched_trx.h
index 17e30bf..cd9c0e4 100644
--- a/src/host/trxcon/sched_trx.h
+++ b/src/host/trxcon/sched_trx.h
@@ -296,10 +296,10 @@
(trx_lchan_desc[chan].link_id & TRX_CH_LID_SACCH)

 #define PRIM_IS_TCH(prim) \
-   CHAN_IS_TCH(prim->chan) && prim->payload_len != GSM_MACBLOCK_LEN
+   (CHAN_IS_TCH(prim->chan) && prim->payload_len != GSM_MACBLOCK_LEN)

 #define PRIM_IS_FACCH(prim) \
-   CHAN_IS_TCH(prim->chan) && prim->payload_len == GSM_MACBLOCK_LEN
+   (CHAN_IS_TCH(prim->chan) && prim->payload_len == GSM_MACBLOCK_LEN)

 struct trx_ts_prim *sched_prim_dequeue(struct llist_head *queue,
enum trx_lchan_type lchan_type);

--
To view, visit https://gerrit.osmocom.org/10453
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa7d9f806b3f18f2dfec931252f5119441b30e8a
Gerrit-Change-Number: 10453
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder


Change in osmocom-bb[master]: trxcon/sched_trx.h: add missing parentheses to PRIM_IS_*

2018-08-15 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10453 )

Change subject: trxcon/sched_trx.h: add missing parentheses to PRIM_IS_*
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10453
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa7d9f806b3f18f2dfec931252f5119441b30e8a
Gerrit-Change-Number: 10453
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 15 Aug 2018 07:56:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmocom-bb[master]: trxcon/sched_trx.h: add missing parentheses to PRIM_IS_*

2018-08-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/10453


Change subject: trxcon/sched_trx.h: add missing parentheses to PRIM_IS_*
..

trxcon/sched_trx.h: add missing parentheses to PRIM_IS_*

Change-Id: Ifa7d9f806b3f18f2dfec931252f5119441b30e8a
---
M src/host/trxcon/sched_trx.h
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/53/10453/1

diff --git a/src/host/trxcon/sched_trx.h b/src/host/trxcon/sched_trx.h
index 17e30bf..cd9c0e4 100644
--- a/src/host/trxcon/sched_trx.h
+++ b/src/host/trxcon/sched_trx.h
@@ -296,10 +296,10 @@
(trx_lchan_desc[chan].link_id & TRX_CH_LID_SACCH)

 #define PRIM_IS_TCH(prim) \
-   CHAN_IS_TCH(prim->chan) && prim->payload_len != GSM_MACBLOCK_LEN
+   (CHAN_IS_TCH(prim->chan) && prim->payload_len != GSM_MACBLOCK_LEN)

 #define PRIM_IS_FACCH(prim) \
-   CHAN_IS_TCH(prim->chan) && prim->payload_len == GSM_MACBLOCK_LEN
+   (CHAN_IS_TCH(prim->chan) && prim->payload_len == GSM_MACBLOCK_LEN)

 struct trx_ts_prim *sched_prim_dequeue(struct llist_head *queue,
enum trx_lchan_type lchan_type);

--
To view, visit https://gerrit.osmocom.org/10453
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa7d9f806b3f18f2dfec931252f5119441b30e8a
Gerrit-Change-Number: 10453
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy