docker-playground[master]: ttcn3-bsc-test: bsc cfg: fix ARFCN-BSIC collisions

2018-04-11 Thread Neels Hofmeyr 

Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.osmocom.org/7744
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29a117aa54aa06ca49646f25a08af8521832fd8d
Gerrit-PatchSet: 2
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

[MERGED] docker-playground[master]: ttcn3-bsc-test: bsc cfg: fix ARFCN-BSIC collisions

2018-04-11 Thread Neels Hofmeyr 
Neels Hofmeyr has submitted this change and it was merged.

Change subject: ttcn3-bsc-test: bsc cfg: fix ARFCN-BSIC collisions
..


ttcn3-bsc-test: bsc cfg: fix ARFCN-BSIC collisions

All three BTS are configured for ARFCN 871 and BSIC 63, which causes trouble
for handover tests. Set BSICs to 10, 11 and 12 (not 0,1,2 to mark the
distinction from the cell_identity).

It wasn't a problem so far since we cheated by passing the BTS target number
from VTY. But as soon as we will start identifying handover target cells by
ARFCN+BSIC exclusively, TC_ho_int would fall on its face without this patch.

See also: osmo-ttcn3-hacks I2ea8889ea40953f5a23eab40db52585556a410bc
Change-Id: I29a117aa54aa06ca49646f25a08af8521832fd8d
---
M ttcn3-bsc-test/osmo-bsc.cfg
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Neels Hofmeyr: Verified
  Harald Welte: Looks good to me, approved



diff --git a/ttcn3-bsc-test/osmo-bsc.cfg b/ttcn3-bsc-test/osmo-bsc.cfg
index 610bdf3..9d5a9c3 100644
--- a/ttcn3-bsc-test/osmo-bsc.cfg
+++ b/ttcn3-bsc-test/osmo-bsc.cfg
@@ -79,7 +79,7 @@
   location_area_code 1
   dtx uplink force
   dtx downlink
-  base_station_id_code 63
+  base_station_id_code 10
   ms max power 15
   cell reselection hysteresis 4
   rxlev access min 0
@@ -169,7 +169,7 @@
   location_area_code 2
   dtx uplink force
   dtx downlink
-  base_station_id_code 63
+  base_station_id_code 11
   ms max power 15
   cell reselection hysteresis 4
   rxlev access min 0
@@ -259,7 +259,7 @@
   location_area_code 1
   dtx uplink force
   dtx downlink
-  base_station_id_code 63
+  base_station_id_code 12
   ms max power 15
   cell reselection hysteresis 4
   rxlev access min 0

-- 
To view, visit https://gerrit.osmocom.org/7744
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I29a117aa54aa06ca49646f25a08af8521832fd8d
Gerrit-PatchSet: 2
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr

docker-playground[master]: ttcn3-bsc-test: bsc cfg: fix ARFCN-BSIC collisions

2018-04-10 Thread Harald Welte 

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7744
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29a117aa54aa06ca49646f25a08af8521832fd8d
Gerrit-PatchSet: 2
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-HasComments: No

[PATCH] docker-playground[master]: ttcn3-bsc-test: bsc cfg: fix ARFCN-BSIC collisions

2018-04-10 Thread Neels Hofmeyr 

ttcn3-bsc-test: bsc cfg: fix ARFCN-BSIC collisions

All three BTS are configured for ARFCN 871 and BSIC 63, which causes trouble
for handover tests. Set BSICs to 10, 11 and 12 (not 0,1,2 to mark the
distinction from the cell_identity).

It wasn't a problem so far since we cheated by passing the BTS target number
from VTY. But as soon as we will start identifying handover target cells by
ARFCN+BSIC exclusively, TC_ho_int would fall on its face without this patch.

See also: osmo-ttcn3-hacks I2ea8889ea40953f5a23eab40db52585556a410bc
Change-Id: I29a117aa54aa06ca49646f25a08af8521832fd8d
---
M ttcn3-bsc-test/osmo-bsc.cfg
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/44/7744/2

diff --git a/ttcn3-bsc-test/osmo-bsc.cfg b/ttcn3-bsc-test/osmo-bsc.cfg
index 610bdf3..9d5a9c3 100644
--- a/ttcn3-bsc-test/osmo-bsc.cfg
+++ b/ttcn3-bsc-test/osmo-bsc.cfg
@@ -79,7 +79,7 @@
   location_area_code 1
   dtx uplink force
   dtx downlink
-  base_station_id_code 63
+  base_station_id_code 10
   ms max power 15
   cell reselection hysteresis 4
   rxlev access min 0
@@ -169,7 +169,7 @@
   location_area_code 2
   dtx uplink force
   dtx downlink
-  base_station_id_code 63
+  base_station_id_code 11
   ms max power 15
   cell reselection hysteresis 4
   rxlev access min 0
@@ -259,7 +259,7 @@
   location_area_code 1
   dtx uplink force
   dtx downlink
-  base_station_id_code 63
+  base_station_id_code 12
   ms max power 15
   cell reselection hysteresis 4
   rxlev access min 0

-- 
To view, visit https://gerrit.osmocom.org/7744
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29a117aa54aa06ca49646f25a08af8521832fd8d
Gerrit-PatchSet: 2
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr

[PATCH] docker-playground[master]: ttcn3-bsc-test: bsc cfg: fix ARFCN-BSIC collisions

2018-04-10 Thread Neels Hofmeyr 

Review at  https://gerrit.osmocom.org/7744

ttcn3-bsc-test: bsc cfg: fix ARFCN-BSIC collisions

All three BTS are configured for ARFCN 871 and BSIC 63, which causes trouble
for handover tests. Set BSICs to 10, 11 and 12 (not 0,1,2 to mark the
distinction from the cell_identity).

It wasn't a problem so far since we cheated by passing the BTS target number
from VTY. But as soon as we will start identifying handover target cells by
ARFCN+BSIC exclusively, TC_ho_int would fall on its face without this patch.

Change-Id: I29a117aa54aa06ca49646f25a08af8521832fd8d
---
M ttcn3-bsc-test/osmo-bsc.cfg
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/44/7744/1

diff --git a/ttcn3-bsc-test/osmo-bsc.cfg b/ttcn3-bsc-test/osmo-bsc.cfg
index 610bdf3..9d5a9c3 100644
--- a/ttcn3-bsc-test/osmo-bsc.cfg
+++ b/ttcn3-bsc-test/osmo-bsc.cfg
@@ -79,7 +79,7 @@
   location_area_code 1
   dtx uplink force
   dtx downlink
-  base_station_id_code 63
+  base_station_id_code 10
   ms max power 15
   cell reselection hysteresis 4
   rxlev access min 0
@@ -169,7 +169,7 @@
   location_area_code 2
   dtx uplink force
   dtx downlink
-  base_station_id_code 63
+  base_station_id_code 11
   ms max power 15
   cell reselection hysteresis 4
   rxlev access min 0
@@ -259,7 +259,7 @@
   location_area_code 1
   dtx uplink force
   dtx downlink
-  base_station_id_code 63
+  base_station_id_code 12
   ms max power 15
   cell reselection hysteresis 4
   rxlev access min 0

-- 
To view, visit https://gerrit.osmocom.org/7744
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29a117aa54aa06ca49646f25a08af8521832fd8d
Gerrit-PatchSet: 1
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr