[ABANDON] libosmo-sccp[master]: vty: command to set local ip of ASP

[dexter]

dexter has abandoned this change.

Change subject: vty: command to set local ip of ASP
..


Abandoned

This change violates the command concept of Cisco ITP

-- 
To view, visit https://gerrit.osmocom.org/3271
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I115b87b08bdc4b07772b7afb9c25bc713e79945a
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 

[PATCH] libosmo-sccp[master]: vty: command to set local ip of ASP

[dexter]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3271

to look at the new patch set (#3).

vty: command to set local ip of ASP

The local ip of an ASP can not be set, while the same is possible
for the remote ip.

Add VTY command to set the local ip of an ASP

Change-Id: I115b87b08bdc4b07772b7afb9c25bc713e79945a
---
M src/osmo_ss7_vty.c
1 file changed, 16 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/71/3271/3

diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index 9343edd..ca77bf6 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -565,6 +565,16 @@
return CMD_SUCCESS;
 }
 
+DEFUN(asp_local_ip, asp_local_ip_cmd,
+   "local-ip A.B.C.D",
+   "Specify Local IP Address of ASP\n"
+   "Local IP Address of ASP\n")
+{
+   struct osmo_ss7_asp *asp = vty->index;
+   osmo_talloc_replace_string(asp, >cfg.local.host, argv[0]);
+   return CMD_SUCCESS;
+}
+
 DEFUN(asp_qos_clas, asp_qos_class_cmd,
"qos-class <0-255>",
"Specify QoS Class of ASP\n"
@@ -633,6 +643,10 @@
if (asp->cfg.description)
vty_out(vty, "  description %s%s", asp->cfg.description, 
VTY_NEWLINE);
vty_out(vty, "  remote-ip %s%s", asp->cfg.remote.host, VTY_NEWLINE);
+
+   if (cs7_role == CS7_ROLE_ASP)
+   vty_out(vty, "  local-ipy %s%s", asp->cfg.local.host, 
VTY_NEWLINE);
+
if (asp->cfg.qos_class)
vty_out(vty, "  qos-class %u%s", asp->cfg.qos_class, 
VTY_NEWLINE);
 }
@@ -1725,6 +1739,8 @@
 {
cs7_role = CS7_ROLE_ASP;
vty_init_shared(ctx);
+
+   install_element(L_CS7_ASP_NODE, _local_ip_cmd);
 }
 
 void osmo_ss7_vty_init_sg(void *ctx)

-- 
To view, visit https://gerrit.osmocom.org/3271
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I115b87b08bdc4b07772b7afb9c25bc713e79945a
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 

libosmo-sccp[master]: vty: command to set local ip of ASP

[Harald Welte]

Patch Set 1:

please clarify when/how this is used.  The existing VTY interface is designed 
to be compatible with the Cisco ITP.  The specification of the local IP address 
(on a SG/STP) is done at the time you bind the given M3UA or SUA listener 
process, see xua_local_ip_cmd

Is this command intended to be used in ASP-client mode? If yes, please state it 
here.  Also, it probably would not work in SG/STP mode, so we should make sure 
not to offer/install it in that case?

-- 
To view, visit https://gerrit.osmocom.org/3271
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115b87b08bdc4b07772b7afb9c25bc713e79945a
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[PATCH] libosmo-sccp[master]: vty: command to set local ip of ASP

[dexter]

Review at  https://gerrit.osmocom.org/3271

vty: command to set local ip of ASP

The local ip of an ASP can not be set, while the same is possible
for the remote ip.

Add VTY command to set the local ip of an ASP

Change-Id: I115b87b08bdc4b07772b7afb9c25bc713e79945a
---
M src/osmo_ss7_vty.c
1 file changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/71/3271/1

diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index b06f554..e79ca20 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -563,6 +563,16 @@
return CMD_SUCCESS;
 }
 
+DEFUN(asp_local_ip, asp_local_ip_cmd,
+   "local-ip A.B.C.D",
+   "Specify Local IP Address of ASP\n"
+   "Local IP Address of ASP\n")
+{
+   struct osmo_ss7_asp *asp = vty->index;
+   osmo_talloc_replace_string(asp, >cfg.local.host, argv[0]);
+   return CMD_SUCCESS;
+}
+
 DEFUN(asp_qos_clas, asp_qos_class_cmd,
"qos-class <0-255>",
"Specify QoS Class of ASP\n"
@@ -1611,6 +1621,7 @@
install_element(L_CS7_NODE, _cs7_asp_cmd);
install_element(L_CS7_ASP_NODE, _description_cmd);
install_element(L_CS7_ASP_NODE, _remote_ip_cmd);
+   install_element(L_CS7_ASP_NODE, _local_ip_cmd);
install_element(L_CS7_ASP_NODE, _qos_class_cmd);
install_element(L_CS7_ASP_NODE, _block_cmd);
install_element(L_CS7_ASP_NODE, _shutdown_cmd);

-- 
To view, visit https://gerrit.osmocom.org/3271
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I115b87b08bdc4b07772b7afb9c25bc713e79945a
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter