[MERGED] libosmocore[master]: l1sap: Add RSSI, BER and quarter-bit accurate timing to PH-R...
Harald Welte has submitted this change and it was merged. Change subject: l1sap: Add RSSI, BER and quarter-bit accurate timing to PH-RACH.ind .. l1sap: Add RSSI, BER and quarter-bit accurate timing to PH-RACH.ind Let's extend PH-RACH.ind with some useful data across the L1SAP boundary. Change-Id: I9439810c3a3ad89ea0302753617b850749af887c Related: OS#3003 --- M include/osmocom/gsm/l1sap.h 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/gsm/l1sap.h b/include/osmocom/gsm/l1sap.h index 1bc1818..18ad7d2 100644 --- a/include/osmocom/gsm/l1sap.h +++ b/include/osmocom/gsm/l1sap.h @@ -64,6 +64,10 @@ uint32_t fn;/*!< GSM Frame Number at time of RA */ uint8_t is_11bit; /*!< no.of bits in RACH*/ enum ph_burst_type burst_type; /*!< type of burst*/ + /* elements added on 2018-02-26 */ + int8_t rssi;/*!< RSSI of RACH indication */ + uint16_t ber10k;/*!< BER in units of 0.01% */ + int16_t acc_delay_256bits;/* !< Burst TA Offset in 1/256th bits */ }; /*! for PH-[UNIT]DATA.{req,ind} | PH-RTS.ind */ -- To view, visit https://gerrit.osmocom.org/6926 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9439810c3a3ad89ea0302753617b850749af887c Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder
libosmocore[master]: l1sap: Add RSSI, BER and quarter-bit accurate timing to PH-R...
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6926 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9439810c3a3ad89ea0302753617b850749af887c Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
[PATCH] libosmocore[master]: l1sap: Add RSSI, BER and quarter-bit accurate timing to PH-R...
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6926 to look at the new patch set (#4). l1sap: Add RSSI, BER and quarter-bit accurate timing to PH-RACH.ind Let's extend PH-RACH.ind with some useful data across the L1SAP boundary. Change-Id: I9439810c3a3ad89ea0302753617b850749af887c Related: OS#3003 --- M include/osmocom/gsm/l1sap.h 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/26/6926/4 diff --git a/include/osmocom/gsm/l1sap.h b/include/osmocom/gsm/l1sap.h index 1bc1818..18ad7d2 100644 --- a/include/osmocom/gsm/l1sap.h +++ b/include/osmocom/gsm/l1sap.h @@ -64,6 +64,10 @@ uint32_t fn;/*!< GSM Frame Number at time of RA */ uint8_t is_11bit; /*!< no.of bits in RACH*/ enum ph_burst_type burst_type; /*!< type of burst*/ + /* elements added on 2018-02-26 */ + int8_t rssi;/*!< RSSI of RACH indication */ + uint16_t ber10k;/*!< BER in units of 0.01% */ + int16_t acc_delay_256bits;/* !< Burst TA Offset in 1/256th bits */ }; /*! for PH-[UNIT]DATA.{req,ind} | PH-RTS.ind */ -- To view, visit https://gerrit.osmocom.org/6926 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9439810c3a3ad89ea0302753617b850749af887c Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder
libosmocore[master]: l1sap: Add RSSI, BER and quarter-bit accurate timing to PH-R...
Patch Set 2: Code-Review-2 this was too early. not sure we want to this this way. -- To view, visit https://gerrit.osmocom.org/6926 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9439810c3a3ad89ea0302753617b850749af887c Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
[PATCH] libosmocore[master]: l1sap: Add RSSI, BER and quarter-bit accurate timing to PH-R...
Review at https://gerrit.osmocom.org/6926 l1sap: Add RSSI, BER and quarter-bit accurate timing to PH-RACH.ind Let's extend PH-RACH.ind with some useful data accross the L1SAP boundary. Change-Id: I9439810c3a3ad89ea0302753617b850749af887c Related: OS#3003 --- M include/osmocom/gsm/l1sap.h 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/26/6926/1 diff --git a/include/osmocom/gsm/l1sap.h b/include/osmocom/gsm/l1sap.h index 1bc1818..3abb569 100644 --- a/include/osmocom/gsm/l1sap.h +++ b/include/osmocom/gsm/l1sap.h @@ -64,6 +64,10 @@ uint32_t fn;/*!< GSM Frame Number at time of RA */ uint8_t is_11bit; /*!< no.of bits in RACH*/ enum ph_burst_type burst_type; /*!< type of burst*/ + /* elements added on 2018-02-26 */ + int8_t rssi;/*!< RSSI of RACH indication */ + uint16_t ber10k;/*!< BER in units of 0.01% */ + int16_t acc_delay_qbits;/* !< Burst TA Offset in quarter bits */ }; /*! for PH-[UNIT]DATA.{req,ind} | PH-RTS.ind */ -- To view, visit https://gerrit.osmocom.org/6926 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9439810c3a3ad89ea0302753617b850749af887c Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Harald Welte