libsmpp34[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr

Patch Set 1: Code-Review+2

marking +2 because I'm (barely) allowed to by the comment at 
https://gerrit.osmocom.org/7096 (03-09 13:04 CET)

-- 
To view, visit https://gerrit.osmocom.org/7107
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib09a4aa3167e5dc24d02e3e59307baa6f7ee3f2c
Gerrit-PatchSet: 1
Gerrit-Project: libsmpp34
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No


[MERGED] libsmpp34[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged.

Change subject: jenkins.sh: use --enable-werror configure flag, not CFLAGS
..


jenkins.sh: use --enable-werror configure flag, not CFLAGS

Change-Id: Ib09a4aa3167e5dc24d02e3e59307baa6f7ee3f2c
---
M contrib/jenkins.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 0768d71..8680cde 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -6,8 +6,8 @@
 osmo-clean-workspace.sh
 
 autoreconf --install --force
-./configure --enable-sanitize
-$MAKE CFLAGS="-Werror" CPPFLAGS="-Werror"
+./configure --enable-sanitize --enable-werror
+$MAKE
 $MAKE $PARALLEL_MAKE
 $MAKE distcheck || cat-testlogs.sh
 

-- 
To view, visit https://gerrit.osmocom.org/7107
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib09a4aa3167e5dc24d02e3e59307baa6f7ee3f2c
Gerrit-PatchSet: 1
Gerrit-Project: libsmpp34
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 


[PATCH] libsmpp34[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-05 Thread Neels Hofmeyr

Review at  https://gerrit.osmocom.org/7107

jenkins.sh: use --enable-werror configure flag, not CFLAGS

Change-Id: Ib09a4aa3167e5dc24d02e3e59307baa6f7ee3f2c
---
M contrib/jenkins.sh
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/07/7107/1

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 0768d71..8680cde 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -6,8 +6,8 @@
 osmo-clean-workspace.sh
 
 autoreconf --install --force
-./configure --enable-sanitize
-$MAKE CFLAGS="-Werror" CPPFLAGS="-Werror"
+./configure --enable-sanitize --enable-werror
+$MAKE
 $MAKE $PARALLEL_MAKE
 $MAKE distcheck || cat-testlogs.sh
 

-- 
To view, visit https://gerrit.osmocom.org/7107
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib09a4aa3167e5dc24d02e3e59307baa6f7ee3f2c
Gerrit-PatchSet: 1
Gerrit-Project: libsmpp34
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr