[MERGED] openbsc[master]: Gb: use textual representation for parse log
Harald Welte has submitted this change and it was merged. Change subject: Gb: use textual representation for parse log .. Gb: use textual representation for parse log Use textual representation for message type and protocol descriminator in case of Gb parsing errors. Change-Id: Ida925258be119619d8705361730c554a130b75bc Related: SYS#3610 --- M openbsc/src/gprs/gprs_gb_parse.c 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/openbsc/src/gprs/gprs_gb_parse.c b/openbsc/src/gprs/gprs_gb_parse.c index 9befa39..d5a122b 100644 --- a/openbsc/src/gprs/gprs_gb_parse.c +++ b/openbsc/src/gprs/gprs_gb_parse.c @@ -380,9 +380,8 @@ default: LOGP(DLLC, LOGL_NOTICE, -"Unknown GSM 04.08 message type 0x%02hhx for protocol" -" discriminator 0x%02hhx.\n", -msg_type, pdisc); +"Unhandled GSM 04.08 message type %s for protocol discriminator %s.\n", +get_value_string(gprs_msgt_gmm_names, msg_type), get_value_string(gsm48_pdisc_names, pdisc)); break; }; -- To view, visit https://gerrit.osmocom.org/2482 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida925258be119619d8705361730c554a130b75bc Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder
openbsc[master]: Gb: use textual representation for parse log
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2482 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida925258be119619d8705361730c554a130b75bc Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
[PATCH] openbsc[master]: Gb: use textual representation for parse log
Gb: use textual representation for parse log Use textual representation for message type and protocol descriminator in case of Gb parsing errors. Change-Id: Ida925258be119619d8705361730c554a130b75bc Related: SYS#3610 --- M openbsc/src/gprs/gprs_gb_parse.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/82/2482/2 diff --git a/openbsc/src/gprs/gprs_gb_parse.c b/openbsc/src/gprs/gprs_gb_parse.c index 9befa39..d5a122b 100644 --- a/openbsc/src/gprs/gprs_gb_parse.c +++ b/openbsc/src/gprs/gprs_gb_parse.c @@ -380,9 +380,8 @@ default: LOGP(DLLC, LOGL_NOTICE, -"Unknown GSM 04.08 message type 0x%02hhx for protocol" -" discriminator 0x%02hhx.\n", -msg_type, pdisc); +"Unhandled GSM 04.08 message type %s for protocol discriminator %s.\n", +get_value_string(gprs_msgt_gmm_names, msg_type), get_value_string(gsm48_pdisc_names, pdisc)); break; }; -- To view, visit https://gerrit.osmocom.org/2482 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ida925258be119619d8705361730c554a130b75bc Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder