[ABANDON] openbsc[master]: lchan: add members for BFI

[dexter]

dexter has abandoned this change.

Change subject: lchan: add members for BFI
..


Abandoned

-- 
To view, visit https://gerrit.osmocom.org/2934
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I2ed78a9dd8747736d01ccf700396d7996f9f4e5d
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 

openbsc[master]: lchan: add members for BFI

[dexter]

Patch Set 2:

> Isn't this basically the link failure counter "s" ? which we also
 > already have in lchan->s ?
 > 
 > If there's something mandate by specs but we're missing it, pleaes
 > include relevant spec references in the commit log.

I thin GSM 05.08 Chapter 5 (Radio link failure) is the right one. The 
implementation seems to be done in ./src/common/l1sap.c, so its in the common 
part.

However. I think what we have her is unrelated to that. The result that is 
stored in the counters only affects the log output. I think this was intended 
to be used for lab-testing. I will ask Octasic whats their intention behind 
this.

-- 
To view, visit https://gerrit.osmocom.org/2934
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ed78a9dd8747736d01ccf700396d7996f9f4e5d
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 
Gerrit-HasComments: No

openbsc[master]: lchan: add members for BFI

[Harald Welte]

Patch Set 2:

Isn't this basically the link failure counter "s" ? which we also already have 
in lchan->s ?

If there's something mandate by specs but we're missing it, pleaes include 
relevant spec references in the commit log.

-- 
To view, visit https://gerrit.osmocom.org/2934
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ed78a9dd8747736d01ccf700396d7996f9f4e5d
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

[PATCH] openbsc[master]: lchan: add members for BFI

[dexter]

Hello Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/2934

to look at the new patch set (#2).

lchan: add members for BFI

The lchan struct lacks structures to keep track of the
BFI (Bad Frame Indication) counters. There are independed
counters for SACCH and TCH. When a bad block is received,
the corresponding counter is incremented. A good block
will decrement the counter again.

This commit is required by osmo-bts changes:
Change-Id I02edc4724f3d272905bee13384628aca18ea9781
Change-Id Idf044e58863aeab7239ba420b71e1676be62cacb

(Patch by Octasic Inc.)

Change-Id: I2ed78a9dd8747736d01ccf700396d7996f9f4e5d
---
M openbsc/include/openbsc/gsm_data_shared.h
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/34/2934/2

diff --git a/openbsc/include/openbsc/gsm_data_shared.h 
b/openbsc/include/openbsc/gsm_data_shared.h
index d3fd757..6cecc78 100644
--- a/openbsc/include/openbsc/gsm_data_shared.h
+++ b/openbsc/include/openbsc/gsm_data_shared.h
@@ -314,6 +314,8 @@
uint8_t bts_tx_pwr;
/* number of measurements stored in array below */
uint8_t num_ul_meas;
+   uint32_t num_sacch_bfi;
+   uint32_t num_tch_bfi;
struct bts_ul_meas uplink[MAX_NUM_UL_MEAS];
/* last L1 header from the MS */
uint8_t l1_info[2];

-- 
To view, visit https://gerrit.osmocom.org/2934
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2ed78a9dd8747736d01ccf700396d7996f9f4e5d
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 

openbsc[master]: lchan: add members for BFI

[Harald Welte]

Patch Set 1:

what I'm missing here is *why* we are adding those fields, and what they will 
be used for.  The radio link timeout / connection failure criterion also has 
some way of counting bad  SACCHs, so I want to make sure we're not adding 
redundant information here.

-- 
To view, visit https://gerrit.osmocom.org/2934
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ed78a9dd8747736d01ccf700396d7996f9f4e5d
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

openbsc[master]: lchan: add members for BFI

[Neels Hofmeyr]

Patch Set 1: Code-Review-1

(and add the change-id of the corresponding change in that other repos)

-- 
To view, visit https://gerrit.osmocom.org/2934
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ed78a9dd8747736d01ccf700396d7996f9f4e5d
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

[PATCH] openbsc[master]: lchan: add members for BFI

[dexter]

Review at  https://gerrit.osmocom.org/2934

lchan: add members for BFI

The lchan struct lacks structures to keep track of the
BFI (Bad Frame Indication) counters. This commit adds the
needed structures.

(Patch by Octasic Inc.)

Change-Id: I2ed78a9dd8747736d01ccf700396d7996f9f4e5d
---
M openbsc/include/openbsc/gsm_data_shared.h
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/34/2934/1

diff --git a/openbsc/include/openbsc/gsm_data_shared.h 
b/openbsc/include/openbsc/gsm_data_shared.h
index d3fd757..6cecc78 100644
--- a/openbsc/include/openbsc/gsm_data_shared.h
+++ b/openbsc/include/openbsc/gsm_data_shared.h
@@ -314,6 +314,8 @@
uint8_t bts_tx_pwr;
/* number of measurements stored in array below */
uint8_t num_ul_meas;
+   uint32_t num_sacch_bfi;
+   uint32_t num_tch_bfi;
struct bts_ul_meas uplink[MAX_NUM_UL_MEAS];
/* last L1 header from the MS */
uint8_t l1_info[2];

-- 
To view, visit https://gerrit.osmocom.org/2934
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ed78a9dd8747736d01ccf700396d7996f9f4e5d
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter