[MERGED] openbsc[master]: vty: skip installing cmds now always installed by default

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: vty: skip installing cmds now always installed by default
..


vty: skip installing cmds now always installed by default

vty_install_default() and install_default() will soon be deprecated.

Depends: I5021c64a787b63314e0f2f1cba0b8fc7bff4f09b
Change-Id: I4951982fc78ae167d8e16a672d7af44d703721a9
---
0 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified




-- 
To view, visit https://gerrit.osmocom.org/4608
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4951982fc78ae167d8e16a672d7af44d703721a9
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 

openbsc[master]: vty: skip installing cmds now always installed by default

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/4608
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4951982fc78ae167d8e16a672d7af44d703721a9
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[PATCH] openbsc[master]: vty: skip installing cmds now always installed by default

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/4608

vty: skip installing cmds now always installed by default

vty_install_default() and install_default() will soon be deprecated.

Depends: I5021c64a787b63314e0f2f1cba0b8fc7bff4f09b
Change-Id: I4951982fc78ae167d8e16a672d7af44d703721a9
---
M openbsc/src/libbsc/abis_nm_vty.c
M openbsc/src/libbsc/abis_om2000_vty.c
M openbsc/src/libbsc/bsc_vty.c
M openbsc/src/libcommon-cs/common_cs_vty.c
M openbsc/src/libmgcp/mgcp_vty.c
M openbsc/src/libmsc/smpp_vty.c
M openbsc/src/libmsc/vty_interface_layer3.c
M openbsc/src/osmo-bsc/osmo_bsc_vty.c
M openbsc/src/osmo-bsc_nat/bsc_nat_vty.c
9 files changed, 0 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/08/4608/1

diff --git a/openbsc/src/libbsc/abis_nm_vty.c b/openbsc/src/libbsc/abis_nm_vty.c
index 6ec0a4a..4dae212 100644
--- a/openbsc/src/libbsc/abis_nm_vty.c
+++ b/openbsc/src/libbsc/abis_nm_vty.c
@@ -183,7 +183,6 @@
install_element(ENABLE_NODE, _classnum_inst_cmd);
install_node(_node, dummy_config_write);
 
-   vty_install_default(OML_NODE);
install_element(OML_NODE, _chg_adm_state_cmd);
install_element(OML_NODE, _opstart_cmd);
 
diff --git a/openbsc/src/libbsc/abis_om2000_vty.c 
b/openbsc/src/libbsc/abis_om2000_vty.c
index a6bc4c7..11dd131 100644
--- a/openbsc/src/libbsc/abis_om2000_vty.c
+++ b/openbsc/src/libbsc/abis_om2000_vty.c
@@ -582,7 +582,6 @@
install_element(ENABLE_NODE, _classnum_inst_cmd);
install_node(_node, dummy_config_write);
 
-   vty_install_default(OM2K_NODE);
install_element(OM2K_NODE, _reset_cmd);
install_element(OM2K_NODE, _start_cmd);
install_element(OM2K_NODE, _status_cmd);
@@ -596,7 +595,6 @@
install_element(OM2K_NODE, _conf_req_cmd);
 
install_node(_con_group_node, dummy_config_write);
-   vty_install_default(OM2K_CON_GROUP_NODE);
install_element(OM2K_CON_GROUP_NODE, _om2k_con_path_dec_cmd);
install_element(OM2K_CON_GROUP_NODE, _om2k_con_path_conc_cmd);
 
diff --git a/openbsc/src/libbsc/bsc_vty.c b/openbsc/src/libbsc/bsc_vty.c
index 5fb1c5d..60bea4f 100644
--- a/openbsc/src/libbsc/bsc_vty.c
+++ b/openbsc/src/libbsc/bsc_vty.c
@@ -4229,7 +4229,6 @@
 
install_element(GSMNET_NODE, _bts_cmd);
install_node(_node, config_write_bts);
-   vty_install_default(BTS_NODE);
install_element(BTS_NODE, _bts_type_cmd);
install_element(BTS_NODE, _description_cmd);
install_element(BTS_NODE, _no_description_cmd);
@@ -4336,7 +4335,6 @@
 
install_element(BTS_NODE, _trx_cmd);
install_node(_node, dummy_config_write);
-   vty_install_default(TRX_NODE);
install_element(TRX_NODE, _trx_arfcn_cmd);
install_element(TRX_NODE, _description_cmd);
install_element(TRX_NODE, _no_description_cmd);
@@ -4348,7 +4346,6 @@
 
install_element(TRX_NODE, _ts_cmd);
install_node(_node, dummy_config_write);
-   vty_install_default(TS_NODE);
install_element(TS_NODE, _ts_pchan_cmd);
install_element(TS_NODE, _ts_pchan_compat_cmd);
install_element(TS_NODE, _ts_tsc_cmd);
diff --git a/openbsc/src/libcommon-cs/common_cs_vty.c 
b/openbsc/src/libcommon-cs/common_cs_vty.c
index bcc001d..f7b4886 100644
--- a/openbsc/src/libcommon-cs/common_cs_vty.c
+++ b/openbsc/src/libcommon-cs/common_cs_vty.c
@@ -292,7 +292,6 @@
 
install_element(CONFIG_NODE, _net_cmd);
install_node(_node, config_write_net);
-   vty_install_default(GSMNET_NODE);
install_element(GSMNET_NODE, _net_ncc_cmd);
install_element(GSMNET_NODE, _net_mnc_cmd);
install_element(GSMNET_NODE, _net_name_short_cmd);
diff --git a/openbsc/src/libmgcp/mgcp_vty.c b/openbsc/src/libmgcp/mgcp_vty.c
index 7d4b2da..b97d7f8 100644
--- a/openbsc/src/libmgcp/mgcp_vty.c
+++ b/openbsc/src/libmgcp/mgcp_vty.c
@@ -1345,7 +1345,6 @@
install_element(CONFIG_NODE, _mgcp_cmd);
install_node(_node, config_write_mgcp);
 
-   vty_install_default(MGCP_NODE);
install_element(MGCP_NODE, _mgcp_local_ip_cmd);
install_element(MGCP_NODE, _mgcp_bts_ip_cmd);
install_element(MGCP_NODE, _mgcp_bind_ip_cmd);
@@ -1404,7 +1403,6 @@
 
install_element(MGCP_NODE, _mgcp_trunk_cmd);
install_node(_node, config_write_trunk);
-   vty_install_default(TRUNK_NODE);
install_element(TRUNK_NODE, _trunk_rtp_keepalive_cmd);
install_element(TRUNK_NODE, _trunk_rtp_keepalive_once_cmd);
install_element(TRUNK_NODE, _trunk_no_rtp_keepalive_cmd);
diff --git a/openbsc/src/libmsc/smpp_vty.c b/openbsc/src/libmsc/smpp_vty.c
index 13467f1..0a84358 100644
--- a/openbsc/src/libmsc/smpp_vty.c
+++ b/openbsc/src/libmsc/smpp_vty.c
@@ -579,7 +579,6 @@
 int smpp_vty_init(void)
 {
install_node(_node, config_write_smpp);
-   vty_install_default(SMPP_NODE);
install_element(CONFIG_NODE, _smpp_cmd);
 
install_element(SMPP_NODE, _smpp_first_cmd);