[MERGED] osmo-bts[master]: l1sap.c: l1sap_tch_rts_ind: Remove unused variables

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: l1sap.c: l1sap_tch_rts_ind: Remove unused variables
..


l1sap.c: l1sap_tch_rts_ind: Remove unused variables

Commit a1fa955212e18ddca286a2c7d30333116406f56b added them without
really making use of them.

Change-Id: Ie7cd648a4b8a5ae59efc8953d6424a91a0f025ef
---
M src/common/l1sap.c
1 file changed, 1 insertion(+), 6 deletions(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index a36ad88..d3f3111 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -827,8 +827,7 @@
struct gsm_time g_time;
struct gsm_lchan *lchan;
uint8_t chan_nr, marker = 0;
-   uint16_t seq;
-   uint32_t fn, timestamp;
+   uint32_t fn;
int rc;
 
chan_nr = rts_ind->chan_nr;
@@ -863,10 +862,6 @@
} else {
/* Obtain RTP header Marker bit from control buffer */
marker = rtpmsg_marker_bit(resp_msg);
-   /* Obtain RTP header Sequence Number from control buffer */
-   seq = rtpmsg_seq(resp_msg);
-   /* Obtain RTP header Timestamp from control buffer */
-   timestamp = rtpmsg_ts(resp_msg);
 
resp_msg->l2h = resp_msg->data;
msgb_push(resp_msg, sizeof(*resp_l1sap));

-- 
To view, visit https://gerrit.osmocom.org/6250
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7cd648a4b8a5ae59efc8953d6424a91a0f025ef
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 

osmo-bts[master]: l1sap.c: l1sap_tch_rts_ind: Remove unused variables

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6250
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7cd648a4b8a5ae59efc8953d6424a91a0f025ef
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-HasComments: No

osmo-bts[master]: l1sap.c: l1sap_tch_rts_ind: Remove unused variables

[Vadim Yanitskiy]

Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.osmocom.org/6250
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7cd648a4b8a5ae59efc8953d6424a91a0f025ef
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-HasComments: No

osmo-bts[master]: l1sap.c: l1sap_tch_rts_ind: Remove unused variables

[Max]

Patch Set 1: Code-Review+1

I think it's a left over from log message which was skipped in the commit which 
made it into master.

-- 
To view, visit https://gerrit.osmocom.org/6250
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7cd648a4b8a5ae59efc8953d6424a91a0f025ef
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-HasComments: No

osmo-bts[master]: l1sap.c: l1sap_tch_rts_ind: Remove unused variables

[Vadim Yanitskiy]

Patch Set 1: Code-Review-1

I think, it would be better to ask the commit author - @Max.

Probably, the mentioned commit was incomplete, and may be
finished / improved. Max?

-- 
To view, visit https://gerrit.osmocom.org/6250
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7cd648a4b8a5ae59efc8953d6424a91a0f025ef
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-HasComments: No

[PATCH] osmo-bts[master]: l1sap.c: l1sap_tch_rts_ind: Remove unused variables

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/6250

l1sap.c: l1sap_tch_rts_ind: Remove unused variables

Commit a1fa955212e18ddca286a2c7d30333116406f56b added them without
really making use of them.

Change-Id: Ie7cd648a4b8a5ae59efc8953d6424a91a0f025ef
---
M src/common/l1sap.c
1 file changed, 1 insertion(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/50/6250/1

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index a36ad88..d3f3111 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -827,8 +827,7 @@
struct gsm_time g_time;
struct gsm_lchan *lchan;
uint8_t chan_nr, marker = 0;
-   uint16_t seq;
-   uint32_t fn, timestamp;
+   uint32_t fn;
int rc;
 
chan_nr = rts_ind->chan_nr;
@@ -863,10 +862,6 @@
} else {
/* Obtain RTP header Marker bit from control buffer */
marker = rtpmsg_marker_bit(resp_msg);
-   /* Obtain RTP header Sequence Number from control buffer */
-   seq = rtpmsg_seq(resp_msg);
-   /* Obtain RTP header Timestamp from control buffer */
-   timestamp = rtpmsg_ts(resp_msg);
 
resp_msg->l2h = resp_msg->data;
msgb_push(resp_msg, sizeof(*resp_l1sap));

-- 
To view, visit https://gerrit.osmocom.org/6250
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7cd648a4b8a5ae59efc8953d6424a91a0f025ef
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol