[MERGED] osmo-gsm-manuals[master]: OsmoGsmTester: Move coredump section and add reference to ke...

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: OsmoGsmTester: Move coredump section and add reference to 
kernel.core_pattern sysctl
..


OsmoGsmTester: Move coredump section and add reference to kernel.core_pattern 
sysctl

This section is moved further below in order to have it after section
which explains how to create user jenkins and osmo-gsm-tester group, as
we need this group already created anyway for the config to work
correctly.

Change-Id: I5bdde0a9960f9806f081e9a876b8b66db9e7f37c
---
M OsmoGSMTester/chapters/install.adoc
1 file changed, 32 insertions(+), 25 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/OsmoGSMTester/chapters/install.adoc 
b/OsmoGSMTester/chapters/install.adoc
index f58c611..4d2b677 100644
--- a/OsmoGSMTester/chapters/install.adoc
+++ b/OsmoGSMTester/chapters/install.adoc
@@ -330,31 +330,6 @@
 
 This assumes you have already created the jenkins user (see 
<>).
 
- Allow Core Files
-
-In case a binary run for the test crashes, a core file of the crash should be
-written. This requires a limit rule. Copy the following config file from the
-osmo-gsm-tester source tree to the main unit:
-
-
-sudo -s
-echo "@osmo-gsm-tester - core unlimited" > 
/etc/security/limits.d/osmo-gsm-tester_allow-core.conf
-
-
-Re-login the user to make these changes take effect.
-
- Allow Realtime Priority
-
-Certain binaries should be run with real-time priority, like 'osmo-bts-trx'.
-Add this permission on the main unit:
-
-
-sudo -s
-echo "@osmo-gsm-tester - rtprio 99" > 
/etc/security/limits.d/osmo-gsm-tester_allow-rtprio.conf
-
-
-Re-login the user to make these changes take effect.
-
  User Permissions
 
 On the main unit, create a group for all users that should be allowed to use
@@ -467,6 +442,38 @@
 
 TODO: allow skipping pcaps by configuration if access to tcpdump is not wanted
 
+ Allow Core Files
+
+In case a binary run for the test crashes, a core file of the crash should be
+written. This requires a limit rule. Create a file with the required rule:
+
+
+sudo -s
+echo "@osmo-gsm-tester - core unlimited" > 
/etc/security/limits.d/osmo-gsm-tester_allow-core.conf
+
+
+Re-login the user to make these changes take effect.
+
+Set the *kernel.core_pattern* sysctl to *core* (usually the default). For each
+binary run by osmo-gsm-tester, a core file will then appear in the same dir 
that
+contains stdout and stderr for that process (because this dir is set as CWD).
+
+
+sysctl -w kernel.core_pattern=core
+
+
+ Allow Realtime Priority
+
+Certain binaries should be run with real-time priority, like 'osmo-bts-trx'.
+Add this permission on the main unit:
+
+
+sudo -s
+echo "@osmo-gsm-tester - rtprio 99" > 
/etc/security/limits.d/osmo-gsm-tester_allow-rtprio.conf
+
+
+Re-login the user to make these changes take effect.
+
 [[user_config_uhd]]
  UHD
 

-- 
To view, visit https://gerrit.osmocom.org/3711
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5bdde0a9960f9806f081e9a876b8b66db9e7f37c
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

osmo-gsm-manuals[master]: OsmoGsmTester: Move coredump section and add reference to ke...

[Neels Hofmeyr]

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3711
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdde0a9960f9806f081e9a876b8b66db9e7f37c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

[PATCH] osmo-gsm-manuals[master]: OsmoGsmTester: Move coredump section and add reference to ke...

[Pau Espin Pedrol]

Hello Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3711

to look at the new patch set (#2).

OsmoGsmTester: Move coredump section and add reference to kernel.core_pattern 
sysctl

This section is moved further below in order to have it after section
which explains how to create user jenkins and osmo-gsm-tester group, as
we need this group already created anyway for the config to work
correctly.

Change-Id: I5bdde0a9960f9806f081e9a876b8b66db9e7f37c
---
M OsmoGSMTester/chapters/install.adoc
1 file changed, 32 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals 
refs/changes/11/3711/2

diff --git a/OsmoGSMTester/chapters/install.adoc 
b/OsmoGSMTester/chapters/install.adoc
index f58c611..4d2b677 100644
--- a/OsmoGSMTester/chapters/install.adoc
+++ b/OsmoGSMTester/chapters/install.adoc
@@ -330,31 +330,6 @@
 
 This assumes you have already created the jenkins user (see 
<>).
 
- Allow Core Files
-
-In case a binary run for the test crashes, a core file of the crash should be
-written. This requires a limit rule. Copy the following config file from the
-osmo-gsm-tester source tree to the main unit:
-
-
-sudo -s
-echo "@osmo-gsm-tester - core unlimited" > 
/etc/security/limits.d/osmo-gsm-tester_allow-core.conf
-
-
-Re-login the user to make these changes take effect.
-
- Allow Realtime Priority
-
-Certain binaries should be run with real-time priority, like 'osmo-bts-trx'.
-Add this permission on the main unit:
-
-
-sudo -s
-echo "@osmo-gsm-tester - rtprio 99" > 
/etc/security/limits.d/osmo-gsm-tester_allow-rtprio.conf
-
-
-Re-login the user to make these changes take effect.
-
  User Permissions
 
 On the main unit, create a group for all users that should be allowed to use
@@ -467,6 +442,38 @@
 
 TODO: allow skipping pcaps by configuration if access to tcpdump is not wanted
 
+ Allow Core Files
+
+In case a binary run for the test crashes, a core file of the crash should be
+written. This requires a limit rule. Create a file with the required rule:
+
+
+sudo -s
+echo "@osmo-gsm-tester - core unlimited" > 
/etc/security/limits.d/osmo-gsm-tester_allow-core.conf
+
+
+Re-login the user to make these changes take effect.
+
+Set the *kernel.core_pattern* sysctl to *core* (usually the default). For each
+binary run by osmo-gsm-tester, a core file will then appear in the same dir 
that
+contains stdout and stderr for that process (because this dir is set as CWD).
+
+
+sysctl -w kernel.core_pattern=core
+
+
+ Allow Realtime Priority
+
+Certain binaries should be run with real-time priority, like 'osmo-bts-trx'.
+Add this permission on the main unit:
+
+
+sudo -s
+echo "@osmo-gsm-tester - rtprio 99" > 
/etc/security/limits.d/osmo-gsm-tester_allow-rtprio.conf
+
+
+Re-login the user to make these changes take effect.
+
 [[user_config_uhd]]
  UHD
 

-- 
To view, visit https://gerrit.osmocom.org/3711
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5bdde0a9960f9806f081e9a876b8b66db9e7f37c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

osmo-gsm-manuals[master]: OsmoGsmTester: Move coredump section and add reference to ke...

[Neels Hofmeyr]

Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/3711/1//COMMIT_MSG
Commit Message:

Line 7: OsmoGsmTester: Move coredump section and add reference to 
kernel.core_pattern sysctl
> So do you want me to split this into 2 commits? Is it really needed? The am
maybe next time.


-- 
To view, visit https://gerrit.osmocom.org/3711
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdde0a9960f9806f081e9a876b8b66db9e7f37c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: Yes

osmo-gsm-manuals[master]: OsmoGsmTester: Move coredump section and add reference to ke...

[Neels Hofmeyr]

Patch Set 1: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/3711/1//COMMIT_MSG
Commit Message:

Line 7: OsmoGsmTester: Move coredump section and add reference to 
kernel.core_pattern sysctl
Sneaky! Editing while moving. Makes it hard to spot the edits.


https://gerrit.osmocom.org/#/c/3711/1/OsmoGSMTester/chapters/install.adoc
File OsmoGSMTester/chapters/install.adoc:

Line 449: osmo-gsm-tester source tree to the main unit:
(oops, it says "copy file" yet I have replaced the copy with an echo of the 
rule)


Line 464: value of that sysctl parameter:
"Please excuse the length of my letter, I didn't have the time to make it 
shorter"

What do you think about:

  Set the @kernel.core_pattern@ to @core@ (usually the default). For each 
binary run by
  osmo-gsm-tester, a core file will then appear in the same dir that contains 
stdout and
  stderr for that process (because this dir is set as CWD).

  
  sysctl ...
  


-- 
To view, visit https://gerrit.osmocom.org/3711
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdde0a9960f9806f081e9a876b8b66db9e7f37c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: Yes

[PATCH] osmo-gsm-manuals[master]: OsmoGsmTester: Move coredump section and add reference to ke...

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/3711

OsmoGsmTester: Move coredump section and add reference to kernel.core_pattern 
sysctl

This section is moved further below in order to have it after section
which explains how to create user jenkins and osmo-gsm-tester group, as
we need this group already created anyway for the config to work
correctly.

Change-Id: I5bdde0a9960f9806f081e9a876b8b66db9e7f37c
---
M OsmoGSMTester/chapters/install.adoc
1 file changed, 37 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals 
refs/changes/11/3711/1

diff --git a/OsmoGSMTester/chapters/install.adoc 
b/OsmoGSMTester/chapters/install.adoc
index f58c611..d01b823 100644
--- a/OsmoGSMTester/chapters/install.adoc
+++ b/OsmoGSMTester/chapters/install.adoc
@@ -330,31 +330,6 @@
 
 This assumes you have already created the jenkins user (see 
<>).
 
- Allow Core Files
-
-In case a binary run for the test crashes, a core file of the crash should be
-written. This requires a limit rule. Copy the following config file from the
-osmo-gsm-tester source tree to the main unit:
-
-
-sudo -s
-echo "@osmo-gsm-tester - core unlimited" > 
/etc/security/limits.d/osmo-gsm-tester_allow-core.conf
-
-
-Re-login the user to make these changes take effect.
-
- Allow Realtime Priority
-
-Certain binaries should be run with real-time priority, like 'osmo-bts-trx'.
-Add this permission on the main unit:
-
-
-sudo -s
-echo "@osmo-gsm-tester - rtprio 99" > 
/etc/security/limits.d/osmo-gsm-tester_allow-rtprio.conf
-
-
-Re-login the user to make these changes take effect.
-
  User Permissions
 
 On the main unit, create a group for all users that should be allowed to use
@@ -467,6 +442,43 @@
 
 TODO: allow skipping pcaps by configuration if access to tcpdump is not wanted
 
+ Allow Core Files
+
+In case a binary run for the test crashes, a core file of the crash should be
+written. This requires a limit rule. Copy the following config file from the
+osmo-gsm-tester source tree to the main unit:
+
+
+sudo -s
+echo "@osmo-gsm-tester - core unlimited" > 
/etc/security/limits.d/osmo-gsm-tester_allow-core.conf
+
+
+Re-login the user to make these changes take effect.
+
+The most logical idea is usually to store the core file inside the run
+directory, and more specifically in the directory where osmo-gsm-tester is
+writing stderr and stdout for that same process. Luckily, osmo-gsm-tester makes
+that easy, as it sets the CWD to that mentioned directory. This means setting
+sysctl *kernel.core_pattern* to any value specifying a relative path is going 
to
+be enough to have it stored there. This is usually the case for the default
+value of that sysctl parameter:
+
+
+sysctl -w kernel.core_pattern=core
+
+
+ Allow Realtime Priority
+
+Certain binaries should be run with real-time priority, like 'osmo-bts-trx'.
+Add this permission on the main unit:
+
+
+sudo -s
+echo "@osmo-gsm-tester - rtprio 99" > 
/etc/security/limits.d/osmo-gsm-tester_allow-rtprio.conf
+
+
+Re-login the user to make these changes take effect.
+
 [[user_config_uhd]]
  UHD
 

-- 
To view, visit https://gerrit.osmocom.org/3711
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bdde0a9960f9806f081e9a876b8b66db9e7f37c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol