[MERGED] osmo-gsm-tester[master]: Revert "osmo-bts-trx config: remove settsc"

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged.

Change subject: Revert "osmo-bts-trx config: remove settsc"
..


Revert "osmo-bts-trx config: remove settsc"

According to pespin, this makes all osmo-bts-trx test runs fail.
We will still figure out the details, but for the time being
let's go with the known working config.

This reverts commit 72ded64705a85df362f918879ddc075d1a0191fe.

Change-Id: I57a3db0d060203ad6540c9a3cc7735e273ee0048
---
M src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl 
b/src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl
index c82f367..452b920 100644
--- a/src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl
+++ b/src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl
@@ -20,6 +20,7 @@
  band ${osmo_bts_trx.band}
  ipa unit-id ${osmo_bts_trx.ipa_unit_id} 0
  oml remote-ip ${osmo_bts_trx.oml_remote_ip}
+ settsc
  gsmtap-sapi bcch
  gsmtap-sapi ccch
  gsmtap-sapi rach

-- 
To view, visit https://gerrit.osmocom.org/3068
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I57a3db0d060203ad6540c9a3cc7735e273ee0048
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

osmo-gsm-tester[master]: Revert "osmo-bts-trx config: remove settsc"

[Pau Espin Pedrol]

Patch Set 1:

Without reverting this patch, we end up in an scenario in which the 2 MS are 
registered but then they unregister at some point later, the tets fail with a 
Wait Timeout on registration.

-- 
To view, visit https://gerrit.osmocom.org/3068
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57a3db0d060203ad6540c9a3cc7735e273ee0048
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

osmo-gsm-tester[master]: Revert "osmo-bts-trx config: remove settsc"

[Pau Espin Pedrol]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3068
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57a3db0d060203ad6540c9a3cc7735e273ee0048
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

osmo-gsm-tester[master]: Revert "osmo-bts-trx config: remove settsc"

[Neels Hofmeyr]

Neels Hofmeyr has reverted this change.

Change subject: Revert "osmo-bts-trx config: remove settsc"
..


Uploaded patch set 1.

-- 
To view, visit https://gerrit.osmocom.org/3068
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: revert
Gerrit-Change-Id: I57a3db0d060203ad6540c9a3cc7735e273ee0048
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-gsm-tester[master]: Revert "osmo-bts-trx config: remove settsc"

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/3068

Revert "osmo-bts-trx config: remove settsc"

According to pespin, this makes all osmo-bts-trx test runs fail.
We will still figure out the details, but for the time being
let's go with the known working config.

This reverts commit 72ded64705a85df362f918879ddc075d1a0191fe.

Change-Id: I57a3db0d060203ad6540c9a3cc7735e273ee0048
---
M src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/68/3068/1

diff --git a/src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl 
b/src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl
index c82f367..452b920 100644
--- a/src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl
+++ b/src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl
@@ -20,6 +20,7 @@
  band ${osmo_bts_trx.band}
  ipa unit-id ${osmo_bts_trx.ipa_unit_id} 0
  oml remote-ip ${osmo_bts_trx.oml_remote_ip}
+ settsc
  gsmtap-sapi bcch
  gsmtap-sapi ccch
  gsmtap-sapi rach

-- 
To view, visit https://gerrit.osmocom.org/3068
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I57a3db0d060203ad6540c9a3cc7735e273ee0048
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr