[MERGED] osmo-gsm-tester[master]: esme: Remove temporary workaround for non-implemented delive...

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged.

Change subject: esme: Remove temporary workaround for non-implemented deliver_sm
..


esme: Remove temporary workaround for non-implemented deliver_sm

Openbsc has SMS Delivery Reports since recently, which means we are now
receiving deliver_sm messages and this workaround introduced in commit
db0d8ab4fcfac67e76729241d92ca128d4526240 is not required anymore.

Closes OS-#2353.

Change-Id: Iecf3983bfc24fec8023ba5d589c2d7620ec5d921
---
M src/osmo_gsm_tester/esme.py
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/esme.py b/src/osmo_gsm_tester/esme.py
index 9dbc5a3..63a1ded 100644
--- a/src/osmo_gsm_tester/esme.py
+++ b/src/osmo_gsm_tester/esme.py
@@ -126,9 +126,7 @@
 self.references_pending_receipt.remove(umref)
 
 def receipt_was_received(self, umref):
-# return umref not in self.references_pending_receipt
-self.log('FIXME: wait_receipt disabled because receipts are not 
received, see OsmoNITB #2353')
-return True
+return umref not in self.references_pending_receipt
 
 def run_method_expect_failure(self, errcode, method, *args):
 try:

-- 
To view, visit https://gerrit.osmocom.org/3557
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iecf3983bfc24fec8023ba5d589c2d7620ec5d921
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

osmo-gsm-tester[master]: esme: Remove temporary workaround for non-implemented delive...

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3557
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecf3983bfc24fec8023ba5d589c2d7620ec5d921
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[PATCH] osmo-gsm-tester[master]: esme: Remove temporary workaround for non-implemented delive...

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/3557

esme: Remove temporary workaround for non-implemented deliver_sm

Openbsc has SMS Delivery Reports since recently, which means we are now
receiving deliver_sm messages and this workaround introduced in commit
db0d8ab4fcfac67e76729241d92ca128d4526240 is not required anymore.

Closes OS-#2353.

Change-Id: Iecf3983bfc24fec8023ba5d589c2d7620ec5d921
---
M src/osmo_gsm_tester/esme.py
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/57/3557/1

diff --git a/src/osmo_gsm_tester/esme.py b/src/osmo_gsm_tester/esme.py
index 9dbc5a3..63a1ded 100644
--- a/src/osmo_gsm_tester/esme.py
+++ b/src/osmo_gsm_tester/esme.py
@@ -126,9 +126,7 @@
 self.references_pending_receipt.remove(umref)
 
 def receipt_was_received(self, umref):
-# return umref not in self.references_pending_receipt
-self.log('FIXME: wait_receipt disabled because receipts are not 
received, see OsmoNITB #2353')
-return True
+return umref not in self.references_pending_receipt
 
 def run_method_expect_failure(self, errcode, method, *args):
 try:

-- 
To view, visit https://gerrit.osmocom.org/3557
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecf3983bfc24fec8023ba5d589c2d7620ec5d921
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol