osmo-iuh[master]: hnbgw_hnbap: fix missing return in rx [un]successful outcome

2018-01-16 Thread Harald Welte

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/5807
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddf76d23c2c7d5824e82708f7da013c88411e832
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No


[MERGED] osmo-iuh[master]: hnbgw_hnbap: fix missing return in rx [un]successful outcome

2018-01-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged.

Change subject: hnbgw_hnbap: fix missing return in rx [un]successful outcome
..


hnbgw_hnbap: fix missing return in rx [un]successful outcome

Fixes: CID#57732 CID#57733
Change-Id: Iddf76d23c2c7d5824e82708f7da013c88411e832
---
M src/hnbgw_hnbap.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/hnbgw_hnbap.c b/src/hnbgw_hnbap.c
index 058a42a..fab520d 100644
--- a/src/hnbgw_hnbap.c
+++ b/src/hnbgw_hnbap.c
@@ -522,12 +522,14 @@
 
 static int hnbgw_rx_successful_outcome_msg(struct hnb_context *hnb, 
SuccessfulOutcome_t *msg)
 {
-
+   /* We don't care much about HNBAP */
+   return 0;
 }
 
 static int hnbgw_rx_unsuccessful_outcome_msg(struct hnb_context *hnb, 
UnsuccessfulOutcome_t *msg)
 {
-
+   /* We don't care much about HNBAP */
+   return 0;
 }
 
 

-- 
To view, visit https://gerrit.osmocom.org/5807
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iddf76d23c2c7d5824e82708f7da013c88411e832
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder


[PATCH] osmo-iuh[master]: hnbgw_hnbap: fix missing return in rx [un]successful outcome

2018-01-15 Thread Neels Hofmeyr

Review at  https://gerrit.osmocom.org/5807

hnbgw_hnbap: fix missing return in rx [un]successful outcome

Fixes: CID#57732 CID#57733
Change-Id: Iddf76d23c2c7d5824e82708f7da013c88411e832
---
M src/hnbgw_hnbap.c
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/07/5807/1

diff --git a/src/hnbgw_hnbap.c b/src/hnbgw_hnbap.c
index 058a42a..fab520d 100644
--- a/src/hnbgw_hnbap.c
+++ b/src/hnbgw_hnbap.c
@@ -522,12 +522,14 @@
 
 static int hnbgw_rx_successful_outcome_msg(struct hnb_context *hnb, 
SuccessfulOutcome_t *msg)
 {
-
+   /* We don't care much about HNBAP */
+   return 0;
 }
 
 static int hnbgw_rx_unsuccessful_outcome_msg(struct hnb_context *hnb, 
UnsuccessfulOutcome_t *msg)
 {
-
+   /* We don't care much about HNBAP */
+   return 0;
 }
 
 

-- 
To view, visit https://gerrit.osmocom.org/5807
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddf76d23c2c7d5824e82708f7da013c88411e832
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr