[ABANDON] osmo-msc[master]: reset: check length of the reset context name

[dexter]

dexter has abandoned this change.

Change subject: reset: check length of the reset context name
..


Abandoned

We have removed the name variable, see also 4754

-- 
To view, visit https://gerrit.osmocom.org/4716
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id7c4a7ff17e1c8ceb6e543ab6f0f07c87df603c7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

osmo-msc[master]: reset: check length of the reset context name

[Harald Welte]

Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/4716/1//COMMIT_MSG
Commit Message:

Line 15: This fixes CID 178664
please use "Fixes: Coverity CID#178664" like in our other related comits.  
Thisis machine-parseable. We don't have any code that parses it yet (AFAIK) but 
this is useful in the future.


https://gerrit.osmocom.org/#/c/4716/1/src/libcommon-cs/a_reset.c
File src/libcommon-cs/a_reset.c:

Line 141:   if (strlen(name) >= sizeof(reset->name))
where does 'reset->name' come from? why is there a separate name at all? Isn't 
the fsm->name sufficient which we allocate/create below?  I think I raised this 
question before in code review but don't recall an answer, sorry.


-- 
To view, visit https://gerrit.osmocom.org/4716
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7c4a7ff17e1c8ceb6e543ab6f0f07c87df603c7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

[PATCH] osmo-msc[master]: reset: check length of the reset context name

[dexter]

Review at  https://gerrit.osmocom.org/4716

reset: check length of the reset context name

When allocating a reset context, the user must supply a human
readable string name. At the moment the length of this name
is not checked

Check the length of the string name.

This fixes CID 178664

Change-Id: Id7c4a7ff17e1c8ceb6e543ab6f0f07c87df603c7
---
M src/libcommon-cs/a_reset.c
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/16/4716/1

diff --git a/src/libcommon-cs/a_reset.c b/src/libcommon-cs/a_reset.c
index 7dbd014..0bf36c6 100644
--- a/src/libcommon-cs/a_reset.c
+++ b/src/libcommon-cs/a_reset.c
@@ -138,6 +138,9 @@
 
struct a_reset_ctx *reset;
 
+   if (strlen(name) >= sizeof(reset->name))
+   return NULL;
+
/* Register the fsm description (if not already done) */
if (osmo_fsm_find_by_name(fsm.name) != )
osmo_fsm_register();

-- 
To view, visit https://gerrit.osmocom.org/4716
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7c4a7ff17e1c8ceb6e543ab6f0f07c87df603c7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: dexter